From: siddarth <siddarthsgml@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] selftests/mm: use long for dwRegionSize
Date: Mon, 28 Apr 2025 13:57:35 +0530 [thread overview]
Message-ID: <CAKWSiC5gd0qDnOcSk4AxpCbnVfc5BFAbSofjN3HXJf-5CqaqwQ@mail.gmail.com> (raw)
In-Reply-To: <20250427171307.876badf3d5606cf502b7f46f@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
On Mon, Apr 28, 2025 at 5:43 AM Andrew Morton <akpm@linux-foundation.org>
wrote:
> On Sun, 27 Apr 2025 15:56:39 +0530 Siddarth G <siddarthsgml@gmail.com>
> wrote:
>
> > Change the type of 'dwRegionSize' in wp_init() and wp_free()
> > from int to long to match callers that pass long or
> > unsigned long long values.
> >
> > wp_addr_range function is left unchanged because it passes
> > 'dwRegionSize' parameter directly to pagemap_ioctl, which expects
> > an int.
>
> Thanks. Does this fix any known compile-time or runtime issues?
>
On Mon, Apr 28, 2025 at 5:43 AM Andrew Morton <akpm@linux-foundation.org>
wrote:
On Sun, 27 Apr 2025 15:56:39 +0530 Siddarth G <siddarthsgml@gmail.com>
wrote:
> Change the type of 'dwRegionSize' in wp_init() and wp_free()
> from int to long to match callers that pass long or
> unsigned long long values.
>
> wp_addr_range function is left unchanged because it passes
> 'dwRegionSize' parameter directly to pagemap_ioctl, which expects
> an int.
Thanks. Does this fix any known compile-time or runtime issues?
Hi, thanks for the review. This patch does not fix any actual known issues.
It aligns parameter types with their actual usage and avoids any potential
future issues.
With gratitude
Siddarth G
[-- Attachment #2: Type: text/html, Size: 1926 bytes --]
prev parent reply other threads:[~2025-04-28 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-27 10:26 Siddarth G
2025-04-28 0:13 ` Andrew Morton
2025-04-28 8:27 ` siddarth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKWSiC5gd0qDnOcSk4AxpCbnVfc5BFAbSofjN3HXJf-5CqaqwQ@mail.gmail.com \
--to=siddarthsgml@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox