linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Peter Zijlstra <peterz@infradead.org>,
	Linux MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.cz>
Subject: Re: [RFC PATCH v2 0/7] Speculative page faults
Date: Thu, 1 Dec 2016 23:50:24 +1100	[thread overview]
Message-ID: <CAKTCnz=0QZ55L5=WbLoCQwB8sXZ_2dgqrBCgdtt=jCqejy=wHA@mail.gmail.com> (raw)
In-Reply-To: <885a17ba-fed8-e312-c2d3-e28a996f5424@linux.vnet.ibm.com>

On Thu, Dec 1, 2016 at 7:34 PM, Laurent Dufour
<ldufour@linux.vnet.ibm.com> wrote:
> On 18/11/2016 15:08, Andi Kleen wrote:
>> Laurent Dufour <ldufour@linux.vnet.ibm.com> writes:
>>
>>> This is a port on kernel 4.8 of the work done by Peter Zijlstra to
>>> handle page fault without holding the mm semaphore.
>>
>> One of the big problems with patches like this today is that it is
>> unclear what mmap_sem actually protects. It's a big lock covering lots
>> of code. Parts in the core VM, but also do VM callbacks in file systems
>> and drivers rely on it too?
>>
>> IMHO the first step is a comprehensive audit and then writing clear
>> documentation on what it is supposed to protect. Then based on that such
>> changes can be properly evaluated.
>
> Hi Andi,
>
> Sorry for the late answer...
>
> I do agree, this semaphore is massively used and it would be nice to
> have all its usage documented.
>
> I'm currently tracking all the mmap_sem use in 4.8 kernel (about 380
> hits) and I'm trying to identify which it is protecting.
>
> In addition, I think it may be nice to limit its usage to code under mm/
> so that in the future it may be easier to find its usage.

Is this possible? All sorts of arch's fault
handling/virtualization/file system and drivers (IO/DRM/) hold
mmap_sem.

Balbir Singh.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-12-01 12:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 12:33 mmap_sem bottleneck Laurent Dufour
2016-10-17 12:51 ` Peter Zijlstra
2016-10-18 14:50   ` Laurent Dufour
2016-10-18 15:01     ` Kirill A. Shutemov
2016-10-18 15:02     ` Peter Zijlstra
2016-11-18 11:08       ` [RFC PATCH v2 0/7] Speculative page faults Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 1/7] mm: Dont assume page-table invariance during faults Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 2/7] mm: Prepare for FAULT_FLAG_SPECULATIVE Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 3/7] mm: Introduce pte_spinlock Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 4/7] mm: VMA sequence count Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 5/7] SRCU free VMAs Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 6/7] mm: Provide speculative fault infrastructure Laurent Dufour
2016-11-18 11:08         ` [RFC PATCH v2 7/7] mm,x86: Add speculative pagefault handling Laurent Dufour
2016-11-18 14:08         ` [RFC PATCH v2 0/7] Speculative page faults Andi Kleen
2016-12-01  8:34           ` Laurent Dufour
2016-12-01 12:50             ` Balbir Singh [this message]
2016-12-01 13:26               ` Laurent Dufour
2016-12-02 14:10         ` Michal Hocko
2016-10-17 12:57 ` mmap_sem bottleneck Michal Hocko
2016-10-20  7:23   ` Laurent Dufour
2016-10-20 10:55     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKTCnz=0QZ55L5=WbLoCQwB8sXZ_2dgqrBCgdtt=jCqejy=wHA@mail.gmail.com' \
    --to=bsingharora@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=kirill@shutemov.name \
    --cc=ldufour@linux.vnet.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox