From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2FFC83F07 for ; Mon, 7 Jul 2025 15:32:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FF636B0346; Mon, 7 Jul 2025 11:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D73D6B0347; Mon, 7 Jul 2025 11:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 213E96B0348; Mon, 7 Jul 2025 11:32:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1288F6B0346 for ; Mon, 7 Jul 2025 11:32:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AE6E816010D for ; Mon, 7 Jul 2025 15:32:25 +0000 (UTC) X-FDA: 83637860250.27.E90C64F Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf27.hostedemail.com (Postfix) with ESMTP id CF77340002 for ; Mon, 7 Jul 2025 15:32:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bnJihgEg; spf=pass (imf27.hostedemail.com: domain of ylavic.dev@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=ylavic.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751902343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z2RtvBnwq2IfJ0CHGCYGxVehGv3P86Mh/6/45Jb+Dlk=; b=un1RcIAW6IQep9HlCrueAUvL6x4kBBotmseFe6X8PJ/IwNfrnGcdBRoNMVyKAqbOgQ619H /tMmrs2Y6J8oU27ENaBad84NQVDNVMV35dmFJgPYsd/SMcFfPrGQMNCzXRSxdxp2cN+0Ky Lcry4XgpYuSf26a985VVDSzjDb8AF+M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bnJihgEg; spf=pass (imf27.hostedemail.com: domain of ylavic.dev@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=ylavic.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751902343; a=rsa-sha256; cv=none; b=fdRa5g8EGrZ5V8biMUMRkZMOwMRT/dRYu82cxswrTndty+iol+FuiyxQZls/ng7pBZMZOq RDUlQ5E57N5jktWqVyEEDdIx/b6QcT1zCZVi38k8s20x8fh7MDGNNOK3gwYe1txTBgZxLV ewBL3Bnp1uu9W9b944uAlB5fjYus8Gs= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e7387d4a336so2593812276.2 for ; Mon, 07 Jul 2025 08:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751902343; x=1752507143; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z2RtvBnwq2IfJ0CHGCYGxVehGv3P86Mh/6/45Jb+Dlk=; b=bnJihgEgNvoJBAmWr73NUTx0Za+RchtiLb9ZReHoqEk1yOYGgU9Hbe2DR5O/wAUfIy 1znagEW4gYQhvpYjqVCiShFIfhSwmy5ac54d5VbGoF5DKlpJobetwMd2TQ1yPjlNpg2M U9c70LHSA7iiPxop+wcem1K9/EskY7mO1czuqN6KMdzoTdAtZ22NE9x1t+SVrh/5/9zS IupNYyuRz8oSoQCqXnlZEbCYSwCS53wgYe1PZdCsqTfHO5CYNfYPZbRpa/zJ3xzh1zFo Ge4B/lCDOrZvlDQK88yp9DdNZCYuo8sfW/eTsICzdNjc3XZ6Hv7ciWd/aCtY6prOojGV exIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751902343; x=1752507143; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2RtvBnwq2IfJ0CHGCYGxVehGv3P86Mh/6/45Jb+Dlk=; b=tO/Vcxy/vZp+VOxzGFIRBBNhAsI58dCUOXT5rurVBCgOWppciOODWmWdvvAAAquqdA enb8jI7rKHjlpbkyYFdO3hIzU12x9MCbydeShXrU/IkAVlZ5u/U7ZjOzR8qC2kR2W+QR nfGLmwPP2VeEYjZdBsE2u6qVLlV1oddUGsMBX1uOw9bJ6t2/XdHl3UK0DO9TJWsBHfLx DvDB8GkGKT1ePn/GOPvwkP/mod13VaX7GvAyExxbGD+CderspM9Ygt5gPlokyUWLxFZM 2sn+zQykA59xVJufPhBo+I6q1oOtppLgPWzuL0Z1KNxji2ihruL5Qq5rhtssWGQNeVGq jFoA== X-Forwarded-Encrypted: i=1; AJvYcCW0AToHTVl1W8/QVw2o5tG+qKaSVF08+shUQc2yJjX8HeE53kGIjstvixzoj+j06bk83LuIgkq0gg==@kvack.org X-Gm-Message-State: AOJu0YzfGKgSpOKi2U5b/fyUcy9xLENYX6eToOhKSyiYaCWrl44beBec JaD92GjaU1ljEU/Fwhs+DJsSfhXz3Kd2Qxp26N1pjmGASDFiH9fhlJKT7rOOpEaaJR3VIllptLc 21PZQON7/e2hH4F5z3PqH9Lv42QsqfLU= X-Gm-Gg: ASbGnctCMEbNAD7uexBDJhcskUJ31tew8Zjrnb0Jm7NS0aNVunf8Zc3VCrDuqRbLDCi gXRrOolFiK1frBGKTXiy0Tfh/X4PfQnYReDG/m9BHpXMHUzz7CACiR/jHIhLIiN2aHY7zNf/pbf +myncN5gE37AbY5gwHAetg9KowfAWkC1Bkbs9H6fbzlf5Y26U9rROvyigN7vgc/I+zirY5o8QeT H76 X-Google-Smtp-Source: AGHT+IHobRt0IVZ9y2H5aHieKxZBuZ9kYKxX7bRopQYtEGb00kgxf2fb/BJfcAAzEetydaLae4Xw+yKZZLvrXk3th6Q= X-Received: by 2002:a05:690c:6911:b0:70e:2a0c:bc5 with SMTP id 00721157ae682-7176ccf0b4amr110470747b3.38.1751902342763; Mon, 07 Jul 2025 08:32:22 -0700 (PDT) MIME-Version: 1.0 References: <20250704134943.3524829-1-rppt@kernel.org> <20250704134943.3524829-4-rppt@kernel.org> In-Reply-To: <20250704134943.3524829-4-rppt@kernel.org> From: Yann Ylavic Date: Mon, 7 Jul 2025 17:32:11 +0200 X-Gm-Features: Ac12FXyaAajnDBmF1qqrRhSguxWKBF3vJJ9uNxcN4-zDud7xknCeyy1uyLlWfCY Message-ID: Subject: Re: [PATCH 3/8] execmem: rework execmem_cache_free() To: Mike Rapoport Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Daniel Gomez , Dave Hansen , Ingo Molnar , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Peter Zijlstra , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CF77340002 X-Stat-Signature: zisk3rso61s93h8tirp1maxt8z1s5uhh X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751902343-958825 X-HE-Meta: U2FsdGVkX184Tw9SXLoMdf0j67swxZu+NrOOFFm/q6+fVCNoBd4Eb0dOEwS9H4toKQxuKbYo8WWLKB62aQERLHLB/sSc1PqecbQF7pjkhGCSOGoBzL5lOYo2T4BfXAUp/fJ8aTE9+1XYJiExEJTcIpFYdBlBXL/a9xamQa6LfJvTYhsD8tG3eQja3iva9wrufwgJ+Kd/5L742ejAsMUtIhkWN8GBhkPLZYDGrNZ7mWz9lMz+37SJVYfE1PPYjaInj9wX6Ngfv7lHyFRHJBH1PAPoIKarqOpbFAMvYrba30TYO+4zcYGnnXuVDkODuEmEfLnd7s96HlIAfp9Lvey5Py8nRM7tREj0O1wSE8cT502iZtGiAK/VC5u2nk9nsKeqGXfEGotBxYBstr7pElyJQtwk+XDzNeOeIrsp96qEqNLNQeEBIr7mcyTvbr3qyzfWr7ClnltlxA6n6/Y4vSXX48cBZ6w6LegE6/DZujCxpg/W/UTTOPHA0EoQdvS7yDdlAunAtYuwsh01x2d1LBaPx9NQ/AMKu8WTyGivlONAIAHyna1KnlpfWirrThKB8YVHYfBogN3bKgWSgkmEDDegVYWdWcX9dJ1npFQlbEaiQ9vHryLdusmgg0rTbxngzjg9KJyFer19zjvA8HJhU7Y0zoNXYQtD/tF/ThHMajbCZ6055fcGxox8RxedupBNpSDsevJ3bMkH6QQTzOCGobZfZS0LP7VFJJ2NkvSxR7h1iiSyfvgBrJROW2tFh57D6OxARrQfQT+i8p0I7ee/qGXoB41124v5jGNOJgwqMxXPlAaMHi2wqYA1Ca973OlK8skyJ1GKG8FGk4jwoAa5+UWzxgiqkYjJBHSSWepcRC3bSEVLVwE2ue10DjhklrsuPZuJPL+Z4JEFrxVQxFeyWcpz+3FE8STCX90pjn/ur4GRFf90q3wk0zau3k0uiXZ32978G8UKbCuth9DSgJIJNit 6ASGxn66 NJ+Nc3lLy++RBirrZb8cg26gwXghtyXe3TWdDnqqiIy7vgGdUbRzObt6Kr70QrVdm+sUZdUkwkbXJ+0cEPjkR/vU9pmUma9aHHbODcsN4mURrPnSSdDion15UlcpCr6QSIERP1uG6GkSonfI7jSvh3/Op3jSXwLTjoIXtGje75ptbxYJE8pCBVkBoBfJUjGPTgx1u2sAN6kKe0jhaGynBrGPmKwTjULifsNBIRD1Y6Y43O+fwRQ34CWMc2ZvL8wqsOOj9L/eroWfmkbFUhD+GojxwBVzzNqcRXCmfERhL3VfFjDLxi+YxYpL64Y263ayoAFAxxvWCp70R2EvMdRPdcd66758dhCNH8IaLDp498PjlbbwphO6uyKPEbaHWNa3/TeOls/Lxg7IEnN/jt+7q8c2fPToV96bHYXqrmM+aPZY87fQug7A8bYiT3lYxw8ehsB0O0J/ALCfjZ8c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 4, 2025 at 3:54=E2=80=AFPM Mike Rapoport wrot= e: > + > +static void execmem_cache_free_slow(struct work_struct *work) > +{ > + struct maple_tree *busy_areas =3D &execmem_cache.busy_areas; > + MA_STATE(mas, busy_areas, 0, ULONG_MAX); > + void *area; > + > + guard(mutex)(&execmem_cache.mutex); > + > + if (!execmem_cache.pending_free_cnt) > + return; > + > + mas_for_each(&mas, area, ULONG_MAX) { > + if (!is_pending_free(area)) > + continue; > + > + pending_free_clear(area); Probably: area =3D pending_free_clear(area); ? > + if (__execmem_cache_free(&mas, area, GFP_KERNEL)) > + continue; > + > + execmem_cache.pending_free_cnt--; > + } > + > + if (execmem_cache.pending_free_cnt) > + schedule_delayed_work(&execmem_cache_free_work, FREE_DELA= Y); > + else > + schedule_work(&execmem_cache_clean_work); > +} Regards; Yann.