From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4146ECD128A for ; Mon, 1 Apr 2024 23:23:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C49B16B0085; Mon, 1 Apr 2024 19:23:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD2C76B008A; Mon, 1 Apr 2024 19:23:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A73D86B008C; Mon, 1 Apr 2024 19:23:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 835116B0085 for ; Mon, 1 Apr 2024 19:23:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 49FB1A040C for ; Mon, 1 Apr 2024 23:23:02 +0000 (UTC) X-FDA: 81962540604.27.1D13CB7 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 0C6901C0002 for ; Mon, 1 Apr 2024 23:22:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=alA969eu; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712013780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nmDExLHPetBlj71YsBEElhTCPTwdlxD6er48VBd3ewo=; b=tIsgSd1QEuei9iO7yq2P6V2FnXeNXGAmr2/bgjva6lbKv24CGG9EIh6oRBGptQu+dRLyIr YCkaLExwg+GlZE5rGaAaFR80owsSs0ZPLyd7NYzfDCYcpaPz3pY4Q77J1U2HDqdrofIYuq +e/201cIrpXqksZyPi+qgOmykqmZODg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=alA969eu; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712013780; a=rsa-sha256; cv=none; b=bvlo1YKjA6ckYgr4IXY4PxqrTExRtppNEaK+4e6QYzlivP7pgMvl9gA1oQOLvlg3AocqeJ krE47o6UVqGV5MskSjDYeGS9XEj1K9XRar2RdLo1aECCTMwCgmI0YH4MXc0KGmtVrPoaBD +YUnMDjplxYBhZv+KO6/MVK14pWwi8Y= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dc745927098so4296371276.3 for ; Mon, 01 Apr 2024 16:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712013778; x=1712618578; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nmDExLHPetBlj71YsBEElhTCPTwdlxD6er48VBd3ewo=; b=alA969euPeLW7aIDPH1/U/81zQa4zlLvDmIV7z4A84AtcwAW6AgQE8dZDVIVhKRdQF TBbvzM6sWnOvjpaZcJrpNq/1mJdD65n872CHQk+tphlMGdKVhCNUKkwCeQdNJUXzLWXU hSCMq5OdvBPEkQaLHts2Vnq5TB+bsCdrRnr0DkhU9uzdUxFzR9l7kbK8cgDw2BlUj+qt g1p3kUt1EgVD6y/Janfm3tsuaAZKl9J68IR//x5e3kNs8WHDAHWeBhaITdBbzdAzgtGh 5z7mwIdIU77YcSRo6asHDh7P+y9rCEsKwfaQN1ILOggABTV2luqjn1P4IZWVdwIfpdtI xz2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712013778; x=1712618578; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nmDExLHPetBlj71YsBEElhTCPTwdlxD6er48VBd3ewo=; b=B03NbG5EUiiKmjZTWtTeGrxymgpr2XyKU2kBpQQOt90jawvh0NkDWyPbZN/Pv4LMEp 63zcvySW7wK8eJ1kW/NnIhJKJqOStkLF4DD5G4XF1vLFa9ALa9OEGmuvcZgWBiu7s65Q 9MHpM9YJykvsYz598ri7ZPZexKncOdOJfw78mbXVdFyj6Y5SSW2+gVWSS2P4y2jEH+pd WcqOvGSdqZ+mrPU2Nt+oraeemdciIkEDdesz4LX8UCBGCtcjeHupMM805Ywvnqc8AeAe 2CLR5QxzUGE37UxqqvJ5sAcUFOf3o/udMmxem2LAE0M7T9Y5WSKvylggiTuxVWlt0/jY zeqQ== X-Forwarded-Encrypted: i=1; AJvYcCXE6/x5z477PEsnP2AV68j7CtCfnn0jndjlfDPzEgWbDPI37NMYNC75dPeZXj7yMGmOE9RaxXq8etE66uf1Qe/TrW8= X-Gm-Message-State: AOJu0YwunmNbqvuHRTEhV3jOUTVYLlfSIxFqWXv6tSL7WtrhOS9C0lKN d2+mM01JrxDdXSkHac6WDB7la3o+eAKVTA9v5TvFEQGi6v3rtDEGs8rfr9cuMeUvTdBw+9Mv2QY 0AePAaIRpahUz7v1uv7YoutBdRhVI2B1PI/ogbDUfxa5oksCu X-Google-Smtp-Source: AGHT+IE7W33XJtOHycwYLTDjAhQzEGA5aAS4snSRR2F2mQp7U6D2wfzXYWPdZ29cRbSKMf5UOMBV+YapP7ToStevg1k= X-Received: by 2002:a25:144:0:b0:dcc:f3fe:19c with SMTP id 65-20020a250144000000b00dccf3fe019cmr3380575ybb.59.1712013777822; Mon, 01 Apr 2024 16:22:57 -0700 (PDT) MIME-Version: 1.0 References: <202403311826.SNOu8jAt-lkp@intel.com> In-Reply-To: <202403311826.SNOu8jAt-lkp@intel.com> From: "Ho-Ren (Jack) Chuang" Date: Mon, 1 Apr 2024 16:22:47 -0700 Message-ID: Subject: Re: [External] [akpm-mm:mm-unstable 263/270] mm/memory-tiers.c:769:13: warning: variable 'rc' set but not used To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Hao Xiang , "Huang, Ying" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0C6901C0002 X-Stat-Signature: 7apo1x1abjkqyd8u6d9ro673aw4bgqr6 X-HE-Tag: 1712013778-841466 X-HE-Meta: U2FsdGVkX196wrRS87k12+l62BpYyu6h+7LLXDu9ebbgVpoNPriC77z7xHcbL6clvZ29a3O+4lPRO/z5msKMYikabB61StDUPgye5rF3N5Lkduu0R4fcARVqkTvafeGf4QwwR+NlcFwVVCNWZ7aVzfK4tp7iPVqDlx4jbXr2CCtSGoCM5ex2edLYoNnREbwA4x5t6SeVJPGwE8T1HOSIP1kh2vgh2nAjJ/Mzzv0iSEnJqP//uwA9xeIhSwqdOYIg8yhffhe3Qj2ZkfpIbAnOYLYpgbqavdjNiSy0rGubxtND8bUeJrmRNU44oFHjpUyvVvNlz7h9gowiaSadyT3AKiPiTgBDeWbfJ+L46qjIrDeZgKq+MHFenvhUaRmGWEsSwk+gckVd6eBnWkLQmpC+wlFyl/RIVEtBHnqAEwfPG1avSTgK1TIc5tveyMePvQyIxb4RPhdyFAXDLCvDbBRZy1/kLHU5ag5x0HLYtFEHu2riyZaFHv477a6zIOpFYRJmpnsk8OsLdRm9uqu78QvKij+328m/2/FRbdCsVZbYxuXGOpBHFKkEhsUw2amNvsSydi6rG2ZrLoXObjH81vgUpw49wuV3c+UcCgi3x4b5GqCdjyS2grGrTyUv1QzEGoPndEHMduPXc9s0wFO7jHpZPApWD7VcQMRybZNXuumoACq0ulq+Iam/iMgZh1cfmdvQJIYJP18cKfVkBKUFw5XTsXaO+P1q6jjII2QB8ub6j8/6pC+stGB35+KOrR6VYsaoX1lxYynVWQUJ1+IYbkl5Z5oeqSMqcggkkQ3vNXGF9Ftxh5uPOiP+I+AvnBgxO4Co+GhbwijuvsLClhlPM+RJ4416oB1MBqsmemEEPqm2O2N7MLe7l1VH9HofRfAkMnR3SXi1B572DCMUTHopcBy3R/VYlGO7p6Hbg4+Pe52PjMkB/K4gIeb0stpkr053lbPaSFTHwFJ3ZjPRxk3bgSe 8vARWJNu 3r6X1XYTj/jfRv0RePDE4iHAYeN7NiAf76dJl2P+xS0EMO5950o9M4T2J3wvplBStvq2ykIyrXGZQ5urTNOSC2WQzHPWF6oJu8zzi0sR0xSlagfg71SnWJcCm2JTilo3pyml56zrID7lsbLl385V0ISvAeDQf9dxFlFvalI0LhXMvxtSzz84AuGGMD/t4j8ILPYmoT7C3u79Sdwy5zb6HmgyPiFSR7WOj7coGJOkPZcCnFOFOS8zXkJFHQ21gzB9IUGEVPvvX9E0nb39+Gn1luvXXtshbbBG7v2kIS/bsBjI4FapQ6S9qkrL3U7vbSaTKS3gb+FcAPQaPmBrDX1nNBXAXzACeBsjkAe3YUe4Vw6J7Low7Ci1eODuFAO6KxxA3hQIulKWuSsvsbShFZz+dz3qayw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Will fix it in V10. Thanks, On Sun, Mar 31, 2024 at 3:23=E2=80=AFAM kernel test robot w= rote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: 0cef2c0a2a356137b170c3cb46cb9c1dd2ca3e6b > commit: fbc8b54896eef0b4d9aaa793523867c7eb86e788 [263/270] memory tier: c= reate CPUless memory tiers after obtaining HMAT info > config: x86_64-defconfig (https://download.01.org/0day-ci/archive/2024033= 1/202403311826.SNOu8jAt-lkp@intel.com/config) > compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20240331/202403311826.SNOu8jAt-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202403311826.SNOu8jAt-lkp= @intel.com/ > > All warnings (new ones prefixed by >>): > > mm/memory-tiers.c: In function 'mt_perf_to_adistance': > >> mm/memory-tiers.c:769:13: warning: variable 'rc' set but not used [-Wu= nused-but-set-variable] > 769 | int rc =3D 0; > | ^~ > > > vim +/rc +769 mm/memory-tiers.c > > 766 > 767 int mt_perf_to_adistance(struct access_coordinate *perf, int *adi= st) > 768 { > > 769 int rc =3D 0; > 770 > 771 mutex_lock(&default_dram_perf_lock); > 772 if (default_dram_perf_error) { > 773 rc =3D -EIO; > 774 goto out; > 775 } > 776 > 777 if (perf->read_latency + perf->write_latency =3D=3D 0 || > 778 perf->read_bandwidth + perf->write_bandwidth =3D=3D 0= ) { > 779 rc =3D -EINVAL; > 780 goto out; > 781 } > 782 > 783 if (default_dram_perf_ref_nid =3D=3D NUMA_NO_NODE) { > 784 rc =3D -ENOENT; > 785 goto out; > 786 } > 787 /* > 788 * The abstract distance of a memory node is in direct pr= oportion to > 789 * its memory latency (read + write) and inversely propor= tional to its > 790 * memory bandwidth (read + write). The abstract distanc= e, memory > 791 * latency, and memory bandwidth of the default DRAM node= s are used as > 792 * the base. > 793 */ > 794 *adist =3D MEMTIER_ADISTANCE_DRAM * > 795 (perf->read_latency + perf->write_latency) / > 796 (default_dram_perf.read_latency + default_dram_pe= rf.write_latency) * > 797 (default_dram_perf.read_bandwidth + default_dram_= perf.write_bandwidth) / > 798 (perf->read_bandwidth + perf->write_bandwidth); > 799 > 800 out: > 801 mutex_unlock(&default_dram_perf_lock); > 802 return 0; > 803 } > 804 EXPORT_SYMBOL_GPL(mt_perf_to_adistance); > 805 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki --=20 Best regards, Ho-Ren (Jack) Chuang =E8=8E=8A=E8=B3=80=E4=BB=BB