From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EE5CD1292 for ; Thu, 4 Apr 2024 21:05:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91F3D6B009A; Thu, 4 Apr 2024 17:05:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CEBB6B009B; Thu, 4 Apr 2024 17:05:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F976B009C; Thu, 4 Apr 2024 17:05:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 58B1F6B009A for ; Thu, 4 Apr 2024 17:05:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 18E88A1721 for ; Thu, 4 Apr 2024 21:05:06 +0000 (UTC) X-FDA: 81973079412.18.2774F26 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf18.hostedemail.com (Postfix) with ESMTP id A26131C0015 for ; Thu, 4 Apr 2024 21:05:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=HVnTBkG6; spf=pass (imf18.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712264704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3BEwoI7vaLN7STH+6B1HZ1H40SSE9uFhmcRIVexkA4A=; b=W6CLvJoYppVIEYHPdCQWHFmCwCpwEjCQN8TXx+BVgUsswRtxI86gJKNPXjEiyQBJi07r4S ePtuOcdvISDtXPztO2cyz8o50qJ1xhmE61D100k4itaz2DIMA66rxm6NoiCVPFM66WXRIk l9wpgVEkP43qdnSBxRY9mXFDivEhgLM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712264704; a=rsa-sha256; cv=none; b=c7pSU6slviwzQ176R9a+jYyUjKEe0wnjjTl3j1SKDoNKBVyZYvvsDuT9Ye7GKesjyWQY5A 00QAiYowDpwcFcguBCyJ7+gTuKBaXHeBsva15w0KEjLqkpzJJuCj/yTlAx45zUqzdo+HkV cPg6OOOZs1I6VdxiWLZYjrOrEgqTCas= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=HVnTBkG6; spf=pass (imf18.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-614b02f8ed6so22803687b3.0 for ; Thu, 04 Apr 2024 14:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712264702; x=1712869502; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3BEwoI7vaLN7STH+6B1HZ1H40SSE9uFhmcRIVexkA4A=; b=HVnTBkG6h+vkg8+jnolKsyOqGrFh4rn9C3kVXHUGQznICKbkR24B/mCS5L76OdENvr hlPBKXXY3eFizl1LoKBKfZsERjow9j9Qm4PUDxr96bZooWwUmT/RKaueEsavC3YSNguG D6g9WBbwRsM2rjWtBxMMiuNbWS+pN0B0cU69tBCrveI5QqoCDUU20Yt7H/5OX9JLebKx 8zKFk9uKLaRBYr0xQ87sPNPZyV2qc28U5u6suT1wlaXunnrQ9wJrc4tvfKhW4J9PsVaK wGMwjMaQA3Im4QbXGf1jqKO+1AwlcdKEYiGazAtEt8c0M8LH48+SAFD6vi26L8ZxgXSw fp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712264702; x=1712869502; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3BEwoI7vaLN7STH+6B1HZ1H40SSE9uFhmcRIVexkA4A=; b=TtxqsYmQPEfDIHhQEThYPmadAr4oZ7lJX+kyooTI5LM0mLihL/LkISbauvKy26fJCq yAsvO5nYyim7f9b4QASqDkS6hhh2H73s7fCaA0bXpQF9LXvHklnhfqw8FLe5xDcIadsY P33BeUM+8uynZhbynRqO7uk6ecV7hxGODWuVXwYylLLhxllGm1V74Iit+q59sS41fL3h MhCdWwtIOwoxKsDh74pFiIOHeAhKeha6pVLwnrJHbzXFIz6mzFzpZ70tFv0tQxqd2N3X LHvjm9eVzhoGxmbQnzP+UWHVjkxhuYBMUb2tl3vwJe1hkJS3V6ZBKsNsXFjUAaU/ESLj GWwA== X-Forwarded-Encrypted: i=1; AJvYcCVfBi3IalPECNA8CyyNw/B4qL6vwic3LCn7IkAhkj2V3IrgIlz2+yKtjeYegF9BipsfGfpGgBkXizMQGDpHjMWYL0U= X-Gm-Message-State: AOJu0Yw9Eqqpqt+10DZluWusVSR6KDTa8qtmwtJ7iD5ATrsuV62HruCD ZOZbHCI1ndTHtishu2RGpqf8ndY30prs9ISqGk1sWnO28fuIoSRHhJlXy/XSa2nRrey4ZJFDkRQ fIbmFtfvPkwTYsK/SaVoEJdFUhFyGhOFNhl3M3g== X-Google-Smtp-Source: AGHT+IG6KpWakGj8bl6wl0XaCmeiykXs6HQkS3DMCudH9AT087DNiiXeU48IwUZnyWYEgunzOmtd5Z4JvSn2JDWo2cM= X-Received: by 2002:a25:bc50:0:b0:dcc:5b7e:ddfe with SMTP id d16-20020a25bc50000000b00dcc5b7eddfemr549930ybk.4.1712264702360; Thu, 04 Apr 2024 14:05:02 -0700 (PDT) MIME-Version: 1.0 References: <20240402001739.2521623-1-horenchuang@bytedance.com> <20240402001739.2521623-3-horenchuang@bytedance.com> <20240403180425.00003be0@Huawei.com> <20240404143733.00004594@Huawei.com> In-Reply-To: <20240404143733.00004594@Huawei.com> From: "Ho-Ren (Jack) Chuang" Date: Thu, 4 Apr 2024 14:04:51 -0700 Message-ID: Subject: Re: [External] Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info To: Jonathan Cameron Cc: "Huang, Ying" , Gregory Price , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, Eishan Mirakhur , Vinicius Tavares Petrucci , Ravis OpenSrc , Alistair Popple , Srinivasulu Thanneeru , SeongJae Park , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Memory Management List , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org, Hao Xiang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A26131C0015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5wao3f3xndfxgngzthdtny87fpjann6s X-HE-Tag: 1712264703-471478 X-HE-Meta: U2FsdGVkX19DfiEx7p7Jd2JG1Iji0DzDmLXDRErZ9e3JoI0DoGWTjdEa/lRG8RfHUHoviBf6Pavmnqjbpm8qJTCa5p+rlQHHX4MYHSMTpOpmL/esHjlUI3Tkk01d95jGQ/1oWWKXjpSYFqvWg6VSTe2KK3q4lhsXSm+B4ebDOq5LvcSjCiWW1T5o3UAQf/ZqIRZQEYCeAdj0atMpBbkHTSqZmpg+Qq5P77bmazgV0eyI48CIWRW1gQbzRTb7/DlgQBv2I95wv6nBUNzR4YA18MUlj8XaRF2WTK565QgP1tvby8TVKzSoGqIkrDGZa9SPkkbD56CjtU4tZCKSP5iXiBtVJkvB66eSsE1l1WKOH0xN3SVktUjykk3aH3qzT3M5W3Q71isN6Jd+koivrQUgSSAnRP6ZJJDi4Vm79C4tJNZRR3MnD4q9rtKgLROKhidITPbvCN5KymcyJ6JRugiMSruaVyoFQTqADqENQGZWPeRBhkj5yC4hX13VsSsvO0DSjQrQKwFc+Q27qQR9zMlN540JMTZXXaFtqEw5NgVqDUdIyzoYy0h5pzDYMGtfhPp74cVYPrfCK2F2KqjBnpX9pabvA3YbuecJZNS9J3uIzfLYOXXntEEfebeLKgRND1QDgOk2AwaDVRIo5WycznXjWu+LSvGl3Nmn9iNKmfoM/+aOdnHs2lcINxFO79aLH01figQMmqFuyr/bvalrNtfODUa5HqaERP586xhsgifpnlGm/6JWvDxiI/Vq6s7tzTUMljyxQbOsIyyBd5Ao3jqx7Q6esqSOtiBy+GHP539Y3zrwb1hcJrUpqmecEfM9nAxdDOuO/Jh0iAOXxa74WDrn3kqjK7WQC1JGcLKfBptfiyUi/VQnXhyyc7ZOpKoCEqiGruVT0Pftq7BhEytZYKreR2H8IRB57UlzaWJVqUnO870ODlAtv88lIJRExEv5rcRRymYMuREUuY/bpPBlm7n RJOLSaKB w3ZBmZaMcU2mwhzXjNH80g+teY04YApWXNo9CXkS6BJDxUdVcYA4jAy8GeEG5knxYnTYXmHsjKNsSPO/YwdXQ8E5rcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jonathan, Thank you! I will fix them and send a V11 soon. On Thu, Apr 4, 2024 at 6:37=E2=80=AFAM Jonathan Cameron wrote: > > > > > > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) > > > > * For now we can have 4 faster memory tiers with smaller adi= stance > > > > * than default DRAM tier. > > > > */ > > > > - default_dram_type =3D alloc_memory_type(MEMTIER_ADISTANCE_DRA= M); > > > > + default_dram_type =3D mt_find_alloc_memory_type(MEMTIER_ADIST= ANCE_DRAM, > > > > + = &default_memory_types); > > > > > > Unusual indenting. Align with just after ( > > > > > > > Aligning with "(" will exceed 100 columns. Would that be acceptable? > I think we are talking cross purposes. > > default_dram_type =3D mt_find_alloc_memory_type(MEMTIER_ADISTANCE= _DRAM, > &default_memory_typ= es); > > Is what I was suggesting. > Oh, now I see. Thanks! > > > > > > if (IS_ERR(default_dram_type)) > > > > panic("%s() failed to allocate default DRAM tier\n", = __func__); > > > > > > > > @@ -868,6 +921,14 @@ static int __init memory_tier_init(void) > > > > * types assigned. > > > > */ > > > > for_each_node_state(node, N_MEMORY) { > > > > + if (!node_state(node, N_CPU)) > > > > + /* > > > > + * Defer memory tier initialization on CPUles= s numa nodes. > > > > + * These will be initialized after firmware a= nd devices are > > > > > > I think this wraps at just over 80 chars. Seems silly to wrap so tig= htly and not > > > quite fit under 80. (this is about 83 chars. > > > > > > > I can fix this. > > I have a question. From my patch, this is <80 chars. However, > > in an email, this is >80 chars. Does that mean we need to > > count the number of chars in an email, not in a patch? Or if I > > missed something? like vim configuration or? > > 3 tabs + 1 space + the text from * (58) > =3D 24 + 1 + 58 =3D 83 > > Advantage of using claws email for kernel stuff is it has a nice per char= acter > ruler at the top of the window. > > I wonder if you have a different tab indent size? The kernel uses 8 > characters. It might explain the few other odd indents if perhaps > you have it at 4 in your editor? > > https://www.kernel.org/doc/html/v4.10/process/coding-style.html > Got it. I was using tab=3D4. I will change to 8. Thanks! > Jonathan > > > > > > > + * initialized. > > > > + */ > > > > + continue; > > > > + > > > > memtier =3D set_node_memory_tier(node); > > > > if (IS_ERR(memtier)) > > > > /* > > > > > > > > --=20 Best regards, Ho-Ren (Jack) Chuang =E8=8E=8A=E8=B3=80=E4=BB=BB