From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A72C4829E for ; Thu, 15 Feb 2024 19:36:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 033F58D0006; Thu, 15 Feb 2024 14:36:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F25DB8D0001; Thu, 15 Feb 2024 14:36:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEEEE8D0006; Thu, 15 Feb 2024 14:36:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CCCB58D0001 for ; Thu, 15 Feb 2024 14:36:13 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 714721A089E for ; Thu, 15 Feb 2024 19:36:13 +0000 (UTC) X-FDA: 81795044226.05.CB961B2 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 619B6A0003 for ; Thu, 15 Feb 2024 19:36:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=Q7Ml8WMp; spf=pass (imf25.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708025771; a=rsa-sha256; cv=none; b=OlUvNCglsQIxQt10UpF1YOT2gIT/IZVoIRmSrOLBkdqjLZY4SGF/NVDmUZSCOixplR+cMF RfbKJ3528kBkZIMa644cocstPRWD7Eem77/ndibwQ81DVkKXVt9OuoCO5x9MghXefoIyI0 JhIQS1E5ki+R+ERPOfgRsXTPYzzDus8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b=Q7Ml8WMp; spf=pass (imf25.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com; dmarc=pass (policy=quarantine) header.from=ionos.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708025771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5YGsYL4MexNc49XeQvb25R/CmGSgGiGGhpjv3r0dFM=; b=mK0UjtwPBvTnTF6fzlyYT+PAOpW5LwsGph1ngGEENnNFIAwu/B8//oQBpjNE/q6L/D0ZD3 pv2FSidcfmh5laocz2mEhJHiPutEoh+IzDlxyZ871jAJ8stUmvgVFfnT4/w3JPCmtJJWBy RDyOmUK7kfY5813n71N9AQUeq8Zfj8U= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d109e82bd0so15241931fa.3 for ; Thu, 15 Feb 2024 11:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1708025770; x=1708630570; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V5YGsYL4MexNc49XeQvb25R/CmGSgGiGGhpjv3r0dFM=; b=Q7Ml8WMp2sNwN/aqgL7tYTBq5Lu6gUEwZcoztl4U2/lE7oZRUzpkIbbE0xukC9NTeV S9GgfC7vPSjtU+qjciZaWMuNHoy/s0G1632LTQdfyWlKO2CS0YriFu9DsruV2n/wmwUI nGhMzfsQBtfK9r+JyCK+k/cxF6bPzNO5hYcrCDNkZiSDGZpvnhTwn2wDARw0u2two02h lnCelVLn399kv6zb2WFULAwHV981irFUHZjM5rZScgEI/aDRjEPtzzRrLoMOOZga6ugM pfPiZ6bqbOwFHH/jq/jEasQ4EeZ/KdvIDQ5/L+z4qFHfoy+DvO/urW6tX/YJnq8Spd9p f9zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708025770; x=1708630570; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V5YGsYL4MexNc49XeQvb25R/CmGSgGiGGhpjv3r0dFM=; b=SaqooYGtdlZ/nr/3D1QuFXowEeFjoq00y6GX2PeayJISz09UHTVW1nN/Z3fs1i5VLf xRjkBau7DeERJZQb062adY9tHreh9wFAzZfTTwwiDC0z95AFpZeoYWtFWMHoEHxG7HKO ZCfE+ddgt0bXDv0lsoGzHnkxqHIDhu37yQLoiCA/DAKduY68AAlSetPgnxx+I0RuhH9s JpfXzwzpyD9SaFM4TXvnbgu1NUaQJkluMP601vmC2BHxOydI0UraPN4lUDXbTowloe8j ehix4VxnbQiFl4bf7Ug6NcsslruLidRSYeCMmMwWPi3rAHgRUUmdPasUXSdF5kH/0Nqr BkHw== X-Forwarded-Encrypted: i=1; AJvYcCUBuo+Yeboh46owjvz5iJZ1OdY2UcU1o7QFl13+G+1gKqGwN7dLtpQZCOotMb2gns14Sraz+n+agnC7b17jO9iemCA= X-Gm-Message-State: AOJu0Yz5jdOvTwVXPp4oh+YLLmPon65I2Y/a5ZNQZE2/NJ9v8eX5r3tn hYupvlEQoim+FN1TQA2bEdeQAZ8PjlMmXxuk+IszPDBN+/LIBkm9BuXqmWxLyv7S1KeS5ws8OYn s8MdqidgNMINtxRE/TAb/t4IXCFDanUFd0Q/WguZ/V5zbsVL4 X-Google-Smtp-Source: AGHT+IE3fm9OGO/kR/idSF9H8ByFMb/mw9m08bcxZR9I435MatzVxuon1xBWUvPmSxShuXEB5wmZs22NzOP1a1LdWXw= X-Received: by 2002:a2e:9e8a:0:b0:2d0:b025:f1ee with SMTP id f10-20020a2e9e8a000000b002d0b025f1eemr1854739ljk.21.1708025769727; Thu, 15 Feb 2024 11:36:09 -0800 (PST) MIME-Version: 1.0 References: <20240215145602.1371274-1-max.kellermann@ionos.com> <20240215145602.1371274-7-max.kellermann@ionos.com> In-Reply-To: From: Max Kellermann Date: Thu, 15 Feb 2024 20:35:58 +0100 Message-ID: Subject: Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page_size.h To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 619B6A0003 X-Stat-Signature: eagdriqfz44ojwqnpuzfu7bschhrbcou X-Rspam-User: X-HE-Tag: 1708025771-930930 X-HE-Meta: U2FsdGVkX196IQeLWTSwPoUmH2qeqkSUYz8xvacy9OQUPkw4/JSwgQxkp+H6d+ZNTiIbX0SwNYxkDegjI4pq3XaXpShHol0ftBQqwlSeXI7DlbpIMgGMLrF4fli0ML0M+V3VCZQXIfbFVNtTC/UTU7VN800Qns/R/oV6gyF4ar2UAZtVPib3vFhJnEkDnszmt7bs7LkftBeRyzuVDeqXXYf6cGn5cRrc7+3aDYph6VRn3jrX27BLDUGjYB3mY3uG53a2MkcvXLxdbk85/XND5u3AMSYb0ot6y8UGdXI5Ll8WbWFwxmnz3GvEcpZRIegdjX+7mc+Sglv1D7jE0ZScJHlsTs89jwQctexSSwMpdgvEE3HtPTK6553RIwIrT2X+auvXCyVzZ475HbvBtUEQY1RHORGt7eee02bBSlmV2JTTmV7Vxf1U4+k/q0JJDd6lZd6dMMwIoszw/CIaMZp7NcMHa7W7dQ2IBsgfrY5zlDvDDFLo01xHy1K/C9uKLO5Yd3uXwpiYKp2hszSe0VHpmm0lROz9G/UTy0qY9XmbDwJh4hyLdwiAel+HqzpQjrp6PFF1++MP/ixfdqaLybNB61ui5gQFF7odIrW1bLuQ/rO0CCc7S4niXyB9a2xhw1AQ2tyxAtI7CePmuL5ZFfHdVb62L1MYn7MzSYOySSQvUQ49xNQb7Eq2QXAGXOwL5ypxfa0VYW0De7uMeGldquWUhJ7QIOq8lRivStVELY7TDmD1pPmeF6Urjc9T1qS4InVE0RXal4ZKxuRJWylFvP62LOMDqk9cPBzZfAg+39DiihCDkk3V7wEu7ep5y8TNC/TqhuZJKJxJ+pl+MCfIDgIzMiq5aXRwvzKjEBKFdhjYhY+il6GokhH84zo6LwiHWHhbyrGS/ZJMMyecr3znhcTDVc2QauxHovFvYqDxQna/0c2ShXHmpEh8FddpkdHbok+8buOFNVDqQMKIVUckJFa b5A507Vp wRgDWAYgXh2aOY7B2n/S+ao64zRrZEFcVYyPlrGNsPyqJ7Eje2Il0aolure/tS79GEry4BEyWjeIasiFSFstXa+s5BChqNJwC5Lrg//UzNwTrd2FJcgcOzCJGWejOiHgSS4LTBoOJN3IN7kIieQVSvINM2Nv0FELX6LtkUJ2BSAqirftn0eN7Aqr7BYIofSJCaHNAe744sMCNnJjhZMmdE5Jy+VVJiPhZNFQZsBiOfT45I/kGg57B7UAErRfoaYaGl/oDipohkdDYjJ+WtPxmobOxoK7I2udBBXCwXXVNdDp7qYL7yb9CwtfYUaSs/Ltx0Yf8YxDcj2VZdt0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 8:26=E2=80=AFPM Matthew Wilcox wrote: > We're really close to eliminating page_size(). Just 23 callers left. > As such, it would be a mistake to name the header after it. I don't > particularly like how you're splitting up mm.h; I think the real problem > is all the code that says "Oh, I'm allocating memory, I should include > mm.h" instead of including gfp.h or slab.h. Yes, a lot of source files do that, but that mistake is not something I'm addressing in this patch series; another patch series I posted two weeks ago is about that. This series is only about making sources lighter which currently indeed need mm.h. > But if you must split it like this, at least call it folio_size.h Okay, I will rename it for v2.