From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F94C25B78 for ; Tue, 4 Jun 2024 13:23:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2323B6B009D; Tue, 4 Jun 2024 09:23:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E2026B009F; Tue, 4 Jun 2024 09:23:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AAE26B00A1; Tue, 4 Jun 2024 09:23:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DEB8E6B009D for ; Tue, 4 Jun 2024 09:23:12 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8646F1A0973 for ; Tue, 4 Jun 2024 13:23:12 +0000 (UTC) X-FDA: 82193272224.11.BA863FD Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf20.hostedemail.com (Postfix) with ESMTP id 6FBF01C0025 for ; Tue, 4 Jun 2024 13:23:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b="IqstSFv/"; dmarc=pass (policy=quarantine) header.from=ionos.com; spf=pass (imf20.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717507390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jAbWUnTOBRaeWPYklSpI20QraPgo9d0o855WcgCKVIY=; b=CLBU7v0HOdHDc6k8Z3XWzv53GZMPaDI0dm5QlIlMVAnY7ZOW0F/YEJB7TZ9m9Eet51qGUn xjbLOXWr6ThQ4IYXjPEKbp2g0FHV7+cWoCEapzEgOtJ4H1swni88Iab67h+IMr7lB/glrw Nh4yvcBLibiq5l05YXZ/P5Oczn3BgyA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ionos.com header.s=google header.b="IqstSFv/"; dmarc=pass (policy=quarantine) header.from=ionos.com; spf=pass (imf20.hostedemail.com: domain of max.kellermann@ionos.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=max.kellermann@ionos.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717507390; a=rsa-sha256; cv=none; b=UJpqfknV3oHYx8E9qFT4Sf9kIV2VlrQDMBYAezUPNcDHobPLvMXnu8DHjMYT1MscBUwhOk xH6s5wK/0lsUbFdmumO8Mh/DzigkjpXscaswOmMjBTQGDMds5mPEPQWR6VnzoeiHdVSgVF K8OLz08gX8U6Oi08WdSLtYtmflW5TBI= Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a634e03339dso623451066b.3 for ; Tue, 04 Jun 2024 06:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1717507389; x=1718112189; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jAbWUnTOBRaeWPYklSpI20QraPgo9d0o855WcgCKVIY=; b=IqstSFv/nWR1/l21RIUT+BX4c+KMn7ho7MYzfHwzzw/1/HrMDirdAbbHuU4i3MnwO5 XtzZ5MJ0x3pbI/fLAuLqrWxOG6zzLqwk2pWFfE5UIG/Dy1+gU9CcJSiTpsPab9YDMR37 SH3tQ8y3E6rjBfLho7oM++nchMCe9lYGlM7eHg7BeG0MwJjxs8FzICKxSkt+xGD4lWvW DWmKwiSWxmaaqkYhccX7KnLQkkO+dSYz7uVVVVrqoZyft+fM+cqpLtWbvUh8wkY92BDt PF7krheLLykbcpTPpcvs4zvN+hrcEt3LRNns7YG7PwKonl/AXmYjhp9UqBbHYWmpEyh9 xuaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717507389; x=1718112189; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jAbWUnTOBRaeWPYklSpI20QraPgo9d0o855WcgCKVIY=; b=hFApohzMyRi6n2rc5W62b3q7oFwohocERArjU0wYCKZp48OfdLAlZJNPlOOMNLHSu2 RsUuXQuJub9zcrD8jk0FGjVPJvvxjkckIFvh6ogmAwAiqO+laA3i0gXah/YqsKJhlyV9 RTIxUS+LThS5BgRStNs+R1HFyPKeSHoktpDv/pOuDkHwxg6j7D+M/Q+6D7YTRjFdEPNo tJRImz8zIJl+I762gVimMzNQPQb4eiF3IkgnDZ0qBIc7yiYP2+/d1s42Np4wGGQZiKTH dP7icoGUkA+vi9dIJmujsIEbduIHlFpyjfn8gpIKfnA7HGZufVHBvw3LlB284qWYy4p1 qDNA== X-Forwarded-Encrypted: i=1; AJvYcCV6LCbKBaUyN9XwL5LdqWSoTE2nCNyJPf3IlQM1WNP3lvbZfHBG1UAl/wMa6zg3DXueITmJpLsx71Tq4H/zxjcss54= X-Gm-Message-State: AOJu0YzkuGtga6fwshvEI2jBf9q4JyaoS3gwf2fF9d96MxKtxosBVWbE RCw0J8NCnXmmCgm/ph6EZEX0M87fMN3Db1PTgkehPUJRrJkeZqXPFJrbtFvyGc/h0LO2vEzB1V6 iIgojt3roZZtnJkUunNCpIJHOWVSBEelrO8p9Ig== X-Google-Smtp-Source: AGHT+IHGGIMDZFU+gPynoc4Ujgj4qTVbZoLInIZYMo4VimoK30MrU/t+0tJSyI98tUhjB9Z3/I214BGwLD8bL8fSTko= X-Received: by 2002:a17:907:7ea1:b0:a68:ea13:f68 with SMTP id a640c23a62f3a-a68ea131343mr538713166b.54.1717507388810; Tue, 04 Jun 2024 06:23:08 -0700 (PDT) MIME-Version: 1.0 References: <20240604090845.2182265-1-max.kellermann@ionos.com> In-Reply-To: From: Max Kellermann Date: Tue, 4 Jun 2024 15:22:57 +0200 Message-ID: Subject: Re: [PATCH v6 00/15] Fast kernel headers: split linux/mm.h To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, david@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6FBF01C0025 X-Stat-Signature: ght3whaibu983wf19rjd7uj3bthpw858 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717507390-533330 X-HE-Meta: U2FsdGVkX1/kXpK5dl38a18+cTwtxl7FwXBY/oKGTbxFHomfINmvvGVjnMJ/2XYBDIevaW1dgnDZgnH/+8pFx09NphHJAegpWlgqiYjReblo6Ja1fSRPYhLAch8U6GjMOpjf0bMrMlEpnPVy7bjBbMyNOBABCFfnTDK458QMBNYOY/2AGXgGiApN9LQBDSYTJPeghSnyrt2oUVafY+xe3QSWoZjoOj7qkvSaO0d8Zky8iOiktKpslQ8k3cHnPihaYXuMxgcs0rJA50JSiPUhEF2giYGFa4NMCzAb68r0EVaj1qKM3d5hR9dv4UuUsGfdew4MLNhD9KSmLeo6SnNrLhmDVpFcTVCQpQAX+Uk4h9bEA90FS5o+mnV8TLtzBKdGWjMprZO+SHrDGoKEHAiokFn3awr/QXqevhuxa0eqMr/UxvRY+bYg3l0OE6CJGTBH6EAICFMS85y4e0HMzTKnsdkywf/+zOy26RV/ieZ1D4CZ8ip/osMBKvPZzG8+hx9GUPqcLniRtkw+l8m+cWZPy3yJcwlJTzALVSDoROQ15IihJBO1S+Vu3SQ5MI92GMC9Wv3AHZG4nh4sjVPzmGT0lTOjhcFIh4Pigltt+VRlRPJU1w+jmXUg8359LCgrEQCD72OSmJW47kCHlQBtWgVrbkL4Mhd7JHII3eH3UAZ0ADnwKjDf+eeLLVonnXEnyOpIqsYCuB97aFw9iFJWs4ENEy7KwPQD7BUqQO/UwWgxnCTao0LCx9o9XlQSVULlP8XSNjMp+unc9UzNYvB7h9ELpMK7ELrxmqXdd2rUiU1eeL+BRkiZXMtl5KfV/9g9KagECc8lYYCsamQCTBzaauNT7eHrFBwlE5u9iicf8JlNAcyD/Zwrm9LAvfnWSQKkffyyX/8FW/Uqf77adQwuewJnZwUKIEWMcUhIqIb1RSf7fu1KSUrOr7DUkofuv5O3IpS3H0ETvCk3Uw3V8co5v3x vgNkCNBJ VtMGOUbU9YnjZfAsnl9rgueh5dNLU1CNSFi/MgsEJfrUD2gAUyBgvlpQf5Xaze4wgZluFW93pqIATlHjdgIzL4+a0L6bY/mGwuIGuLKPYwPjVwIeJ++pYv+TZHQ1WpZuSMCfPg3e7BeRFBsbfs5chI7dPFje8jfcP7q2hakfduYNnjHgOK/Fa1h47XEcl5d2hWY3j526u+qKPEpgZx8GVP1k8EziSUyhZhGPbdM1lkK8QSsyThS4BGcYx8nkmTgkvHmGTdlnzogRdm2mSn63YGWLV+9tg4z+XZwkv+bY5eGmI5GTWpZyEfNF6yrWPGxSqfrQZErvkPAmkE2xBWfZ3TQnA5dcGPg/WVHegwi0ZAJyLkf0VZoeh6Ov5IpBaNDCYZOBCm6GnuczzDw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 4, 2024 at 3:02=E2=80=AFPM Matthew Wilcox = wrote: > I am not a fan of these patches. They will make it harder to work on > the MM system. We briefly discussed them at LSFMM and nobody was in > favour of them. I'm afraid you're shouting into the wind. Thanks for letting me know, but I'm confused because similar patches have been merged pretty often. For a very weird example, look at commit adeb04362d74 ("kernel.h: Move upper_*_bits() and lower_*_bits() to wordpart.h") which was submitted on Feb 14th; and then look at https://lore.kernel.org/lkml/20240209164027.2582906-34-max.kellermann@ionos= .com/ - it's exactly the same patch, but I submitted it 5 days earlier, yet the other one was merged. Other recent examples (though without offending earlier patches from me): - d186eb1ee885 ("cpumask: split out include/linux/cpumask_types.h") - f7515d9fe8fc4 ("objtool: Add objtool_types.h") - cb5a065b4ea9 ("headers/deps: mm: Split out of ") - 50d91c765825 ("hrtimers: Split out hrtimer_types.h") - 9983deb26d90 ("Split out irqflags_types.h") - 6d5e9d636830 ("pid: Split out pid_types.h") .... and so on ... If there is a general agreement that nobody is in favor of these patches, why are they merged when other people submit them? Max