From: Max Kellermann <max.kellermann@ionos.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
david@redhat.com
Subject: Re: [PATCH v6 00/15] Fast kernel headers: split linux/mm.h
Date: Tue, 4 Jun 2024 15:22:57 +0200 [thread overview]
Message-ID: <CAKPOu+8R_KUudoNNGM5m2q6oS0oGY3Hyc_7bKM+-DtFFjJicsg@mail.gmail.com> (raw)
In-Reply-To: <Zl8QW91FwZ9UpulZ@casper.infradead.org>
On Tue, Jun 4, 2024 at 3:02 PM Matthew Wilcox <willy@infradead.org> wrote:
> I am not a fan of these patches. They will make it harder to work on
> the MM system. We briefly discussed them at LSFMM and nobody was in
> favour of them. I'm afraid you're shouting into the wind.
Thanks for letting me know, but I'm confused because similar patches
have been merged pretty often.
For a very weird example, look at commit adeb04362d74 ("kernel.h: Move
upper_*_bits() and lower_*_bits() to wordpart.h") which was submitted
on Feb 14th; and then look at
https://lore.kernel.org/lkml/20240209164027.2582906-34-max.kellermann@ionos.com/
- it's exactly the same patch, but I submitted it 5 days earlier, yet
the other one was merged.
Other recent examples (though without offending earlier patches from me):
- d186eb1ee885 ("cpumask: split out include/linux/cpumask_types.h")
- f7515d9fe8fc4 ("objtool: Add objtool_types.h")
- cb5a065b4ea9 ("headers/deps: mm: Split <linux/gfp_types.h> out of
<linux/gfp.h>")
- 50d91c765825 ("hrtimers: Split out hrtimer_types.h")
- 9983deb26d90 ("Split out irqflags_types.h")
- 6d5e9d636830 ("pid: Split out pid_types.h")
.... and so on ...
If there is a general agreement that nobody is in favor of these
patches, why are they merged when other people submit them?
Max
prev parent reply other threads:[~2024-06-04 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 9:08 Max Kellermann
2024-06-04 9:08 ` [PATCH v6 01/15] drivers: add missing includes on linux/mm.h (and others) Max Kellermann
2024-06-04 9:08 ` [PATCH v6 02/15] include/drm/drm_gem.h: add poll_table_struct forward declaration Max Kellermann
2024-06-04 9:08 ` [PATCH v6 03/15] include/scsi/scsicam.h: forward-declare struct block_device Max Kellermann
2024-06-04 9:08 ` [PATCH v6 04/15] linux/mm.h: move page_kasan_tag() to mm/page_kasan_tag.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 05/15] linux/mm.h: move section functions to mm/page_section.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 06/15] linux/mm.h: move page_address() and others to mm/page_address.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 07/15] linux/mm.h: move folio_size(), ... to mm/folio_size.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 08/15] linux/mm.h: move folio_next() to mm/folio_next.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 09/15] linux/mm.h: move devmap-related declarations to mm/devmap_managed.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 10/15] linux/mm.h: move usage count functions to mm/folio_usage.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 11/15] linux/mm.h: move page_zone_id() and more to mm/folio_zone.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 12/15] linux/mm.h: move pfmemalloc-related functions to pfmemalloc.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 13/15] linux/mm.h: move is_vmalloc_addr() to mm/vmalloc_addr.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 14/15] linux/mm.h: move high_memory to mm/high_memory.h Max Kellermann
2024-06-04 9:08 ` [PATCH v6 15/15] include: reduce dependencies on linux/mm.h Max Kellermann
2024-06-04 13:02 ` [PATCH v6 00/15] Fast kernel headers: split linux/mm.h Matthew Wilcox
2024-06-04 13:22 ` Max Kellermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKPOu+8R_KUudoNNGM5m2q6oS0oGY3Hyc_7bKM+-DtFFjJicsg@mail.gmail.com \
--to=max.kellermann@ionos.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox