From: Max Kellermann <max.kellermann@ionos.com>
To: David Hildenbrand <david@redhat.com>
Cc: Kiryl Shutsemau <kirill@shutemov.name>,
akpm@linux-foundation.org, axelrasmussen@google.com,
yuanchu@google.com, willy@infradead.org, hughd@google.com,
mhocko@suse.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, vishal.moola@gmail.com
Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters
Date: Mon, 1 Sep 2025 12:36:40 +0200 [thread overview]
Message-ID: <CAKPOu+8JwdcK4RJDt7amCj9-V0K8Xjmtt=HHWsrET=EEyPBthw@mail.gmail.com> (raw)
In-Reply-To: <5636a473-2a0a-4d25-95a4-1db48a1752ec@redhat.com>
On Mon, Sep 1, 2025 at 12:07 PM David Hildenbrand <david@redhat.com> wrote:
>
> On 01.09.25 12:00, Max Kellermann wrote:
> > On Mon, Sep 1, 2025 at 11:53 AM David Hildenbrand <david@redhat.com> wrote:
> >> I'm sorry, I have no time to argue about the basics of writing a patch
> >> description. I even proposed a simple example of what we (multiple
> >> reviewers) would expect as a bare minimum.
> >
> > But Lorenzo Stoakes and Mike Rappoport wanted much more than that.
>
> Sure, if it's not a simple "test" function as the one I commented on, it
> might make sense to explain more why it is okay.
Lorenzo and Mike commented on the very same patch as you (i.e. 01/12).
I remember that you provided an example, and implementing that would
have been easy - but it would not have been enough.
Matthew's patches would not have been enough, had they been judged by
the same rules.
next prev parent reply other threads:[~2025-09-01 10:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 9:39 [PATCH v2 00/12] mm: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 01/12] mm/shmem: " Max Kellermann
2025-09-01 7:33 ` Kiryl Shutsemau
2025-09-01 8:05 ` Max Kellermann
2025-09-01 8:20 ` David Hildenbrand
2025-09-01 8:26 ` Max Kellermann
2025-09-01 8:35 ` David Hildenbrand
2025-09-01 9:26 ` Max Kellermann
2025-09-01 9:32 ` Vlastimil Babka
2025-09-01 9:45 ` Max Kellermann
2025-09-01 9:49 ` David Hildenbrand
2025-09-01 9:41 ` David Hildenbrand
2025-09-01 9:48 ` Max Kellermann
2025-09-01 9:52 ` David Hildenbrand
2025-09-01 10:00 ` Max Kellermann
2025-09-01 10:07 ` David Hildenbrand
2025-09-01 10:36 ` Max Kellermann [this message]
2025-09-01 10:40 ` David Hildenbrand
2025-09-01 9:01 ` Mike Rapoport
2025-08-31 9:39 ` [PATCH v2 02/12] include/pagemap.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 03/12] include/mmzone.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 04/12] include/fs.h: add `const` to several " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 05/12] mm/oom_kill: add `const` to pointer parameter Max Kellermann
2025-08-31 9:39 ` [PATCH v2 06/12] mm/util: add `const` to several pointer parameters Max Kellermann
2025-08-31 9:39 ` [PATCH v2 07/12] parisc/sys_parisc.c: add `const` to mmap_upper_limit() parameter Max Kellermann
2025-09-01 0:38 ` Matthew Wilcox
2025-09-01 6:06 ` Max Kellermann
2025-08-31 9:39 ` [PATCH v2 08/12] arch, mm/util: add const to arch_pick_mmap_layout() parameter Max Kellermann
2025-08-31 23:43 ` kernel test robot
2025-09-01 4:30 ` Max Kellermann
2025-08-31 9:39 ` [PATCH v2 09/12] include/mm_types.h: add `const` to several pointer parameters Max Kellermann
2025-08-31 9:39 ` [PATCH v2 10/12] include/mm_inline.h: add `const` to lots of " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 11/12] include/mm.h: " Max Kellermann
2025-08-31 9:39 ` [PATCH v2 12/12] mm/highmem: " Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKPOu+8JwdcK4RJDt7amCj9-V0K8Xjmtt=HHWsrET=EEyPBthw@mail.gmail.com' \
--to=max.kellermann@ionos.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox