From: Daniel Colascione <dancol@google.com>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Synchronize task mm counters on demand
Date: Thu, 22 Feb 2018 18:24:18 -0800 [thread overview]
Message-ID: <CAKOZues=wHgMu9vH7ixc-vzL7b7T7OK2jYecUKvnR45Fx=HDBw@mail.gmail.com> (raw)
In-Reply-To: <CAKOZuesZPy8rgo_pPy=cUtGcGhLzCq4X46ns7h7ta7ihrJSPWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
On Thu, Feb 22, 2018 at 6:09 PM, Daniel Colascione <dancol@google.com>
wrote:
> Thanks for taking a look.
>
> On Feb 22, 2018 6:01 PM, "Minchan Kim" <minchan@kernel.org> wrote:
>
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index ad06d42adb1a..f8129afebbdd 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -1507,14 +1507,28 @@ extern int mprotect_fixup(struct vm_area_struct
> *vma,
> > */
> > int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> > struct page **pages);
> > +
> > +#ifdef SPLIT_RSS_COUNTING
> > +/* Flush all task-buffered MM counters to the mm */
> > +void sync_mm_rss_all_users(struct mm_struct *mm);
>
> Really heavy functioin iterates all of processes and threads.
>
>
> Just all processes and the threads of each process attached to the mm.
> Maybe that's not much better.
>
Another option would be to maintain a list (with the list_head in the mm)
of all the tasks with unflushed counters. This way, we at least wouldn't
have to scan the world.
[-- Attachment #2: Type: text/html, Size: 2109 bytes --]
next prev parent reply other threads:[~2018-02-23 2:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 22:03 [PATCH] Synchronize task mm counters on context switch Daniel Colascione
2018-02-21 19:05 ` Daniel Colascione
2018-02-22 0:16 ` Minchan Kim
2018-02-22 0:23 ` Daniel Colascione
2018-02-22 2:06 ` Minchan Kim
2018-02-22 2:46 ` [PATCH] Synchronize task mm counters on demand Daniel Colascione
2018-02-23 2:01 ` Minchan Kim
2018-02-23 2:09 ` Daniel Colascione
2018-02-23 2:24 ` Daniel Colascione [this message]
2018-02-23 2:28 ` Minchan Kim
2018-02-23 2:43 ` Daniel Colascione
2018-02-23 3:12 ` Minchan Kim
2018-02-23 9:50 ` f66871fb4c: WARNING:inconsistent_lock_state kernel test robot
2018-02-22 2:49 ` [PATCH] Synchronize task mm counters on context switch Daniel Colascione
2018-02-23 8:11 ` Michal Hocko
2018-02-23 16:34 ` Daniel Colascione
2018-02-23 17:50 ` Michal Hocko
2018-02-23 18:47 ` Daniel Colascione
2018-02-27 10:02 ` Michal Hocko
2018-02-22 9:40 ` Peter Zijlstra
2018-02-22 13:06 ` Minchan Kim
2018-02-22 16:23 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOZues=wHgMu9vH7ixc-vzL7b7T7OK2jYecUKvnR45Fx=HDBw@mail.gmail.com' \
--to=dancol@google.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox