From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC2CC433E2 for ; Tue, 15 Sep 2020 10:39:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A901320B1F for ; Tue, 15 Sep 2020 10:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ig5tEx0h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A901320B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0F260900033; Tue, 15 Sep 2020 06:39:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07BB5900017; Tue, 15 Sep 2020 06:39:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E853A900033; Tue, 15 Sep 2020 06:39:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id CE71B900017 for ; Tue, 15 Sep 2020 06:39:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8F3828249980 for ; Tue, 15 Sep 2020 10:39:52 +0000 (UTC) X-FDA: 77264950224.12.cook66_301223127110 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 74CCD1800BD00 for ; Tue, 15 Sep 2020 10:39:52 +0000 (UTC) X-HE-Tag: cook66_301223127110 X-Filterd-Recvd-Size: 4636 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 10:39:51 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id n61so2722395ota.10 for ; Tue, 15 Sep 2020 03:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ulpeSnyY5/ewevGEpTqNXhDdyzWhPxYuGEnSEK0qUFE=; b=ig5tEx0h7bfKi5EybZqA+C68o6gYUIfa+RfL190q/C/6enFMceUUZeuDygc7lBryyo Y39LD8nxmbQQ2ZpJi/7Bu1MrZHh+9AmFkAC82cd1/Ss7084QYOZc1Q6UWRtMFDibGKuJ Yhfx18xPVi60zG4gPhH/H78zP9lEy3I29XQis= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ulpeSnyY5/ewevGEpTqNXhDdyzWhPxYuGEnSEK0qUFE=; b=qfmgAi8z1xpWPLNnOvRKHjjGwnaIVl7r3Ya++avzTV1YlC3dIYTN35JWgPjw88kqX/ 7wbL+OdUvl/Zhm/ciAIGyUn67gIuZo0C8NBAW1EqUHBbbqDEPplDDFtVBBpGSEbKVasB W3zifmKj5g01gbMwZtnk2LFI2staPrcn4c58QIJj1WQtmFAR9OKXujnhbinJ3Lx6LHDa tVur35x5Z5dn9ov/iV0HqxFUdXXJ2omnzr2JkB+JvoszBK8kv0AusRDXOEHqT1vn/Sn7 rOJt+AwBBAGGOJvwoKlVbK+MamtdJwxQCe0oiV8abpBIs21k10IKiLHWL4ZQWIIv7S1U fISw== X-Gm-Message-State: AOAM533E0LA4/kz/0gIT8dyDPo8qMZj6ZwtdzTkH5lLUPJ9cjE5TeAIU UIVbHhyweqbDUgYqlvlpJZMcdK7XAZG7DlXuECosaQ== X-Google-Smtp-Source: ABdhPJzbKPKIRS8EfyunRCEi31t2CsfncQrKriVKuMZ+LvqfMKqrLvYa64Bhcsp3AhwdlFX/YDNiySv4RihZaKzNLEU= X-Received: by 2002:a05:6830:1e56:: with SMTP id e22mr11974578otj.303.1600166390649; Tue, 15 Sep 2020 03:39:50 -0700 (PDT) MIME-Version: 1.0 References: <20200914132920.59183-1-christian.koenig@amd.com> <20200914132920.59183-2-christian.koenig@amd.com> In-Reply-To: <20200914132920.59183-2-christian.koenig@amd.com> From: Daniel Vetter Date: Tue, 15 Sep 2020 12:39:39 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Andrew Morton , Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 74CCD1800BD00 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 14, 2020 at 3:29 PM Christian K=C3=B6nig wrote: > > This reverts commit 26d3ac3cb04d171a861952e89324e347598a347f. > > We need to figure out if dma_buf_mmap() is valid or not first. > > Signed-off-by: Christian K=C3=B6nig The trouble is that doing dma-buf mmap by looking at the struct pages behind the sg list and just inserting those into userspace doesn't really work any better. You still won't get the unmap_mapping_range and hence pte shoot-down. So maybe dma_buf_mmap forwarding doesn't work, but this doesn't make it any better. Also commit message should probably explain a bit the context here, not a lot of people have been in our private discussion on this. -Daniel > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm= _gem_shmem_helper.c > index 0a952f27c184..cd727343f72b 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -594,9 +594,6 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj, st= ruct vm_area_struct *vma) > /* Remove the fake offset */ > vma->vm_pgoff -=3D drm_vma_node_start(&obj->vma_node); > > - if (obj->import_attach) > - return dma_buf_mmap(obj->dma_buf, vma, 0); > - > shmem =3D to_drm_gem_shmem_obj(obj); > > ret =3D drm_gem_shmem_get_pages(shmem); > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch