From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4CCC5517A for ; Fri, 23 Oct 2020 14:46:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FF8721527 for ; Fri, 23 Oct 2020 14:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Spx4hwCa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FF8721527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 089316B005D; Fri, 23 Oct 2020 10:46:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03AC56B0062; Fri, 23 Oct 2020 10:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1CB96B0068; Fri, 23 Oct 2020 10:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id B496F6B005D for ; Fri, 23 Oct 2020 10:46:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B64E181AEF09 for ; Fri, 23 Oct 2020 14:46:02 +0000 (UTC) X-FDA: 77403464964.30.hot95_540616e2725a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id BB9B1180B3C8B for ; Fri, 23 Oct 2020 14:46:01 +0000 (UTC) X-HE-Tag: hot95_540616e2725a X-Filterd-Recvd-Size: 4591 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 23 Oct 2020 14:46:00 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id k27so2087947oij.11 for ; Fri, 23 Oct 2020 07:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cmGjJdbt9z1UYbT5/ZpSCpz1o50MyYCTMK9AHq0Aakg=; b=Spx4hwCaXf34JyFBNZU5P3z2Yc6125/UltDMuzpO1FUom3Imvy74oVwjnfX6eEVi0B zjkOgtlhaqtz+7NG7zdnSLUt5Rs0WTD2wX6fxpxq0VZide9nyesLxotL7/nXMV4OBZYk nvC79EU7g32SfEqeva4RGwvPB0L1tnqWAT7KQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cmGjJdbt9z1UYbT5/ZpSCpz1o50MyYCTMK9AHq0Aakg=; b=H7o7KywGcN5wceMML33OXEaT3HSpfuWkPWb3H1FT7lc/M09HdsCHo8oV1CpKf80S96 J6rHoxudKTXO4RkrH4MuIP3SPVHJnnv5oMRLyuBKNUYcXpBRu+/uPxrTkgAouLrzCSOi g3Giq77MxiSuU8FqeEQNLoPtNLW7Nw5nmKmUfGhU94i+QV2TQJ90Un9RFfIR+aDHvLTr 8A4W2cl7yjD2r17L77baYcKahYS5G/eIgKN84RedHlegdSe0ZG+Fu0DIRjrElzZvW5Mr rT0L+rdgzOot+K/74pqYV9yuW/HvCt/QcvnY0pAHIF1K1onKIOFz6UOjB5bVwj/zPiZZ 9V9A== X-Gm-Message-State: AOAM530NsnojKclhcmPtHmeOsKo2nhK2u2C7lb7aa//oxK2tVbrUnQ+B NOxHKR0hfrRp9MFeIrIyecuvrc7NbW8JZmTUAushpg== X-Google-Smtp-Source: ABdhPJxzM7Q4pHq2VPzHFl40r08AFCr6VXVCJPwfsZqO2s0Hja92tgFb3rm5wRQVurhNjcBpW7T188EV4zJA1keqdEo= X-Received: by 2002:aca:cc01:: with SMTP id c1mr2005619oig.128.1603464360217; Fri, 23 Oct 2020 07:46:00 -0700 (PDT) MIME-Version: 1.0 References: <20201021163242.1458885-1-daniel.vetter@ffwll.ch> <20201023122216.2373294-1-daniel.vetter@ffwll.ch> <20201023122216.2373294-4-daniel.vetter@ffwll.ch> <20201023141619.GC20115@casper.infradead.org> In-Reply-To: From: Daniel Vetter Date: Fri, 23 Oct 2020 16:45:49 +0200 Message-ID: Subject: Re: [PATCH 04/65] mm: Extract might_alloc() debug check To: Matthew Wilcox Cc: DRI Development , Intel Graphics Development , "Paul E . McKenney" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Mathieu Desnoyers , Sebastian Andrzej Siewior , Michel Lespinasse , Waiman Long , Thomas Gleixner , Randy Dunlap , Linux MM , linux-fsdevel@vger.kernel.org, Dave Chinner , Qian Cai , linux-xfs@vger.kernel.org, Daniel Vetter Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 23, 2020 at 4:37 PM Daniel Vetter wrote: > > On Fri, Oct 23, 2020 at 4:16 PM Matthew Wilcox wrote: > > > > On Fri, Oct 23, 2020 at 02:21:15PM +0200, Daniel Vetter wrote: > > > Note that unlike fs_reclaim_acquire/release gfpflags_allow_blocking > > > does not consult the PF_MEMALLOC flags. But there is no flag > > > equivalent for GFP_NOWAIT, hence this check can't go wrong due to > > > memalloc_no*_save/restore contexts. > > > > I have a patch series that adds memalloc_nowait_save/restore. > > tbh this was a typoed git send-email, but thanks for the heads-up, > I'll adjust the patch accordingly. On 2nd thought I think your patch should update gfpflags_allow_blocking to take into account the new ->memalloc_nowait flag you're adding. I'll comment over there in that thread. -Daniel > > > https://lore.kernel.org/linux-mm/20200625113122.7540-7-willy@infradead.org/ > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch