From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C05C56201 for ; Wed, 25 Nov 2020 16:28:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41D5721527 for ; Wed, 25 Nov 2020 16:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="K4nmwFze" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D5721527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA1036B005C; Wed, 25 Nov 2020 11:28:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4F346B0070; Wed, 25 Nov 2020 11:28:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9651D6B0072; Wed, 25 Nov 2020 11:28:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 80C276B005C for ; Wed, 25 Nov 2020 11:28:45 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 40968180AD801 for ; Wed, 25 Nov 2020 16:28:45 +0000 (UTC) X-FDA: 77523474210.27.cast50_5f06a4727378 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 24B5E3D663 for ; Wed, 25 Nov 2020 16:28:45 +0000 (UTC) X-HE-Tag: cast50_5f06a4727378 X-Filterd-Recvd-Size: 5466 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 16:28:44 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id d9so3457165oib.3 for ; Wed, 25 Nov 2020 08:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dRACjaFJh4AZpkepxixl78ErKCZI3elRJ+hcGP1uvRc=; b=K4nmwFzet4CmWQbz4zwRTZ6CI5hxzbxZ25gbBnhWnCJH8Q8rKXsL79Ql5rlCpu29Lr bPggFh1VtIOTIpQaTQqFAtXfwAgUPiNMU07nzL7WEAwSqk0xgspIBThT1z03Zvfxcs3b aqQEsY9KeNryZDXQ07y5HihJ9KhEL6DoeL6A8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dRACjaFJh4AZpkepxixl78ErKCZI3elRJ+hcGP1uvRc=; b=dixljMLfyez/S2fhi/+7Y450Fb6OLDaOadYuMWY/3O/C1W8aPLGkdjqs2WHAXfTDe4 Y6bsO8fpBZ01/q1QcwFOUoNZFhf4n1CtCmLTx92YobOg0UpOCX1bXy8mTkm9Cm1LvyR0 c2+hOrhW1pPTe+DF/tsS8YgH9rVcJsgY8iD7MB1GXtFI/5wy21dw1ZZaPRCkefR+q/ut jPstrdoZWafsaFazpQK8aY7TaY8iR2U5rEIC23avQxei+IpB2LT7P2Ddg3ogcCmIyLtD oRh9VNt/KMc3QI5tBC2jQZihCJjiO9zzdNFyNjQUCfDxE+AQQKDz3Y9bXF1SaS1wkwYf RTiA== X-Gm-Message-State: AOAM531kf+Dfx67XJwsZtWXF2RFDXfPvRsgq0KO6jYv97f+I2/b3fDUJ NUV1Th58m1+jUZOnwGCJAS5Z8/wR0R/u1oXYuRC5OA== X-Google-Smtp-Source: ABdhPJxFp4HuSi30fm1PHbzKdfrYvQxr8zUWpRKb+OichQq/lnbRaStrtSKPxiYo68cqfG34JDlvPm/6dqfZjcK5iGw= X-Received: by 2002:aca:7506:: with SMTP id q6mr2814868oic.128.1606321723817; Wed, 25 Nov 2020 08:28:43 -0800 (PST) MIME-Version: 1.0 References: <20201125162532.1299794-1-daniel.vetter@ffwll.ch> <20201125162532.1299794-5-daniel.vetter@ffwll.ch> In-Reply-To: <20201125162532.1299794-5-daniel.vetter@ffwll.ch> From: Daniel Vetter Date: Wed, 25 Nov 2020 17:28:32 +0100 Message-ID: Subject: Re: [PATCH] drm/ttm: don't set page->mapping To: DRI Development Cc: Intel Graphics Development , Linux MM , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, LKML , Thomas Hellstrom , Brian Paul , Daniel Vetter , Christian Koenig , Huang Rui Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 5:25 PM Daniel Vetter wrote: > > Random observation while trying to review Christian's patch series to > stop looking at struct page for dma-buf imports. > > This was originally added in > > commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 > Author: Thomas Hellstrom > Date: Fri Jan 3 11:47:23 2014 +0100 > > drm/ttm: Correctly set page mapping and -index members > > Needed for some vm operations; most notably unmap_mapping_range() with > even_cows = 0. > > Signed-off-by: Thomas Hellstrom > Reviewed-by: Brian Paul > > but we do not have a single caller of unmap_mapping_range with > even_cows == 0. And all the gem drivers don't do this, so another > small thing we could standardize between drm and ttm drivers. > > Plus I don't really see a need for unamp_mapping_range where we don't > want to indiscriminately shoot down all ptes. > > Cc: Thomas Hellstrom > Cc: Brian Paul > Signed-off-by: Daniel Vetter > Cc: Christian Koenig > Cc: Huang Rui Apologies again, this shouldn't have been included. But at least I have an idea now why this patch somehow was included in the git send-email. Lovely interface :-/ -Daniel > --- > drivers/gpu/drm/ttm/ttm_tt.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index da9eeffe0c6d..5b2eb6d58bb7 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > @@ -284,17 +284,6 @@ int ttm_tt_swapout(struct ttm_bo_device *bdev, struct ttm_tt *ttm) > return ret; > } > > -static void ttm_tt_add_mapping(struct ttm_bo_device *bdev, struct ttm_tt *ttm) > -{ > - pgoff_t i; > - > - if (ttm->page_flags & TTM_PAGE_FLAG_SG) > - return; > - > - for (i = 0; i < ttm->num_pages; ++i) > - ttm->pages[i]->mapping = bdev->dev_mapping; > -} > - > int ttm_tt_populate(struct ttm_bo_device *bdev, > struct ttm_tt *ttm, struct ttm_operation_ctx *ctx) > { > @@ -313,7 +302,6 @@ int ttm_tt_populate(struct ttm_bo_device *bdev, > if (ret) > return ret; > > - ttm_tt_add_mapping(bdev, ttm); > ttm->page_flags |= TTM_PAGE_FLAG_PRIV_POPULATED; > if (unlikely(ttm->page_flags & TTM_PAGE_FLAG_SWAPPED)) { > ret = ttm_tt_swapin(ttm); > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch