From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] io-mapping.h: s/PAGE_KERNEL_IO/PAGE_KERNEL/
Date: Tue, 23 Aug 2016 15:43:15 +0200 [thread overview]
Message-ID: <CAKMK7uFjtbsareLBGjCWvypybNRVROpkrD-oCDxvnj8B+EkDgQ@mail.gmail.com> (raw)
In-Reply-To: <20160823122119.GK20834@nuc-i3427.alporthouse.com>
On Tue, Aug 23, 2016 at 2:21 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Aug 23, 2016 at 02:05:18PM +0200, Daniel Vetter wrote:
>> On Tue, Aug 23, 2016 at 11:04:03AM +0300, Joonas Lahtinen wrote:
>> > On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote:
>> > > PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t
>> > > used for the iomapped region, it itself is just PAGE_KERNEL. On all
>> > > other arches, PAGE_KERNEL_IO is undefined so in a general header we must
>> > > refrain from using it.
>> > >
>> >
>> > There is;
>> >
>> > #define __PAGE_KERNEL_IO (__PAGE_KERNEL)
>> >
>> > So no functional change, but will compile on all archs.
>> >
>> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>
>> Still not happy:
>>
>> CC drivers/gpio/gpiolib-of.o
>> In file included from drivers/gpio/gpiolib-of.c:19:0:
>> ./include/linux/io-mapping.h: In function ‘io_mapping_init_wc’:
>> ./include/linux/io-mapping.h:125:16: error: implicit declaration of function ‘pgprot_writecombine’ [-Werror=implicit-function-declaration]
>> iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>> ^~~~~~~~~~~~~~~~~~~
>> ./include/linux/io-mapping.h:125:36: error: ‘PAGE_KERNEL’ undeclared (first use in this function)
>> iomap->prot = pgprot_writecombine(PAGE_KERNEL);
>> ^~~~~~~~~~~
>
> That was pulled in by the x86 headers,
>
> #include <asm/pgtable.h>
Can you pls respin?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-08-23 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 7:22 Chris Wilson
2016-08-23 8:04 ` Joonas Lahtinen
2016-08-23 12:05 ` Daniel Vetter
2016-08-23 12:21 ` Chris Wilson
2016-08-23 13:43 ` Daniel Vetter [this message]
2016-08-23 13:54 ` Chris Wilson
2016-08-23 15:50 ` [PATCH v2] " Chris Wilson
2016-08-23 16:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uFjtbsareLBGjCWvypybNRVROpkrD-oCDxvnj8B+EkDgQ@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox