From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A178FC52D11 for ; Thu, 26 Jan 2023 17:24:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 443126B0073; Thu, 26 Jan 2023 12:24:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F3678E0002; Thu, 26 Jan 2023 12:24:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BBFF8E0001; Thu, 26 Jan 2023 12:24:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1F5C76B0073 for ; Thu, 26 Jan 2023 12:24:50 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E3D36140DC3 for ; Thu, 26 Jan 2023 17:24:49 +0000 (UTC) X-FDA: 80397625098.12.E3D955C Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf26.hostedemail.com (Postfix) with ESMTP id 41D91140010 for ; Thu, 26 Jan 2023 17:24:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FcVVUD0R; spf=pass (imf26.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674753887; a=rsa-sha256; cv=none; b=vdCwacALrurnL3Wc4QcazhYxRH4Qdv6glDr73xvWNUuWmiB8u1xEvqdHLflicm7ePRF5Vg zFyKupr9saGJGYwd+vs3RVzkaqcZV1ykOxz7OIVKFnJJSao3mBJachE5gGipQwDqBh5dle 65gmmFxAj+pRUO+PvReQE2q1tM23sY0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FcVVUD0R; spf=pass (imf26.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674753887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qHlmTunQ49C1Dpyk77Z4C3k4Cau4j+Xb//Hx9WL7A8k=; b=zyYomM1neORvJLDHpetRXVUa4UYd/XLAXJayFIQT3Jem4Hw+etde9b2bbswsp1X2Vdp3xR xzcO03g9bkP4kATltwBQx7bNVuBHt0TOXFxvrZ8gD2WzD7Tbjsv2eBCaB36ktPJt7xCA7o G1oiLfbBzNy8B9YgJoOMNtT1AZhs/kg= Received: by mail-vs1-f41.google.com with SMTP id j7so2600720vsl.11 for ; Thu, 26 Jan 2023 09:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qHlmTunQ49C1Dpyk77Z4C3k4Cau4j+Xb//Hx9WL7A8k=; b=FcVVUD0R+CepEE82KTwR5p856vdMWJsT8H3faHwVqVudmDdIF4Lcfrg/SHWvuzVpWF KA1kLRC9qaFiYMLpexmhNHDdgVJLefzkTqzrfB096e/Nh7scJpPIASgZfXzCCsgbBObo BTqxf3peJlRY1R6MhO6OJbfFx0Fc5aAcwVL0v0vA9EkBPvf6OfaJbVZgOVqaqXDtAmd+ bLwYoW1Us2QDe+hiDLMCAN7ceajba131vdEy/eZtQwB7bSeqLgQdh+6Q6+S2vwIvhii5 yyOMBLagGZW37aZdWToQMqAEtPdoBK0EhksXhUNvoEWT6160ijCRlx0xf8Wmnr7UcnYZ WzAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qHlmTunQ49C1Dpyk77Z4C3k4Cau4j+Xb//Hx9WL7A8k=; b=LC1GJZysJ8WJitnLRJrGmE4MRemt+rzvzk0srrTMBvA4N9b8FfVq8OI7d8329UJ2NK 7h1NWlrOE+BDecLOnShfNxnoWUDgGEty0T5Qi1T0NASI7ci92IH8d/gTb++Y2blwQGjd 8wSa8nhIiIowGzKUDGd4JdN4PpwcyxtGF9zqRS/CsXucXHOXMWdFs+VCNs4b4lR9mUl9 Qk60DQeS7vpKgnauajD0cp11O4ju5M2WMybmE1SHj1CWEJh9XyYQ+RZ9+KRQjjzgK09b Wt6BmQR13khuVnmCWCVtmrz5lQxOWsXgoUtj2F1VpJhXq5Amxj/gZpuZaIs1Dkh1Njru /noA== X-Gm-Message-State: AFqh2kq86tkn0xkWTWAuG/eeMNGzszVyheAavZkxoIALcVpFvvJw3eTX XpyWtUDJ8/AiQ4iZXqKgZLmzeAF4V6tn7i/ZUK4= X-Google-Smtp-Source: AMrXdXstMx4Lc6leAXpj1VV45UXIVItPQZcy2o9t6/kD/JJrrhSQhYl4SzeJqctMxVoXgA7/dxFlIFpz/owb7AnAd4Y= X-Received: by 2002:a05:6102:6c2:b0:3ce:bced:178 with SMTP id m2-20020a05610206c200b003cebced0178mr4927618vsg.84.1674753885888; Thu, 26 Jan 2023 09:24:45 -0800 (PST) MIME-Version: 1.0 References: <20230121065755.1140136-1-hch@lst.de> <20230121065755.1140136-8-hch@lst.de> In-Reply-To: <20230121065755.1140136-8-hch@lst.de> From: Ryusuke Konishi Date: Fri, 27 Jan 2023 02:24:29 +0900 Message-ID: Subject: Re: [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio To: Christoph Hellwig Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 41D91140010 X-Rspamd-Server: rspam01 X-Stat-Signature: mnjogd7d73cu3e479spfnj5becxafox1 X-HE-Tag: 1674753887-534158 X-HE-Meta: U2FsdGVkX187KcuDg9hiKOg7DcMIPLUOlZgjWIGrJBLZR5vWOnVjEs6CCxQLRxqSiL2DiNGgFsWKhQlmutuYD5jSadBKsFymrkRUPSsPNhzAd2XNWz2jita4P7/WeUT5rjy+yXJaxQp8ToVxLI6i0WkL1AMjugitRJ6nXNkhJwgdqCNW3xaSWd4+ZjLOUmcXiJbQIiv7OiuieSE3hWHgw7vStmhh2FzCrsz8xaZfrf3eJg4p97wTyJSQOjewpdtnnCt8e0EE2+kEyG75Cwng/V6x7LJhYKxcg1c6dRFPNRXQ7dL8kW58vkcfkeyZmIPelOndOlM6Zk81rMdXTA2ouHX8MbgF3JYHr7HoE/Bfgbsyjk02hIAfQxW7mvjPsVFTL0CBV/ufSgcTR8f6a4U2L52/ms84aPaK9k+dRt5GpMQLRJAt9/QVY1l6Zyv6QF+22wl9aIWIn43QinT8xVAxlg2qL2sZDkGJVVw1X/Gp8YdtrOjgy3UiDvEwWQW/2zh7YA2H4z4HmttBeC5u9cJgyhFdHcAPYAj4p0PR1ZsJgaWlL4GcaRgTG45u/teFAmSjq3Eb3JIF6X0bUQOdVnvNjDW9AD7+BmofoIsDdtgO91CPZwqBUNXaK4qL6hOMFn3UKPzNvaY2wewqyubwyxP4yLP2Dt1Hu6FGfr9eYkO3m+YQCycins/+EKOn0ahLHeXFI0lkrylX94d3J1yZpvmickI02viBuUJFezx1VWRsaRsibpnzU5qGYCNxC7qkzznXzZKnvISgCYNiYp1aAu/hVckVWpxmp6IJznUQJPDiAtynIIrAKQn0SwKd6+9qmwAtWGb2s/P9ExTXY0f8EZv875QCRptjx7xxqzjgVrMpkVZYbsCshRTMHJcAaXrogFdGhLk53kBwHRyzH4UjPZia4cBZ0bzz1KTAsquztIykIDSaQpqI0m+j9wrQ5DLKXPbCLCut6JAIxX9oAFHXzOK JNHUnSHs CuDdz78qDGlOTlVpwIpsrjOIJHitzhZFz1/IEY3vZcVeHC9GpS2SBJD33GGgOeGb/Yp3/fnq6nY2/PJq48xwnNvtjalBIYcab3an1/Ja2qKQRa4iFHUgI2tbWeT+Y7Z3eBfbd1wRFp3DnbmI7xFcRld7OhMPY1wqqyfOVEkCoEa+1GApEZo5vYmANZdv6Z7ZiV9RAbpddmIbPM21xrYxApJBAcSn3fbfJ+s4uEJHc4YCy7A2JdYbA6Gbudv+YvRo/2BabkPCzOq3I4PNiMsBZAwrlGXsyC/cYebcBf4Z63jQO92SOIGs5suLCqWFq3Z1Sjq2PoXjj45NCQSTvhsFlVWJbdMD5QDHgHcxcnNe6pdZ5BaFI3hhZiFwWVJimVw1aGq+MOJcBhDmG0RnEvnrhtAuv7l8J4/A2+wWgKMU1HT3M762cHVCZNvRYCybXvgjiTa/4vbtYq2ooEnD/3/ta/VB4bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 21, 2023 at 3:59 PM Christoph Hellwig wrote: > > Instead of returning NULL for all errors, distinguish between: > > - no entry found and not asked to allocated (-ENOENT) > - failed to allocate memory (-ENOMEM) > - would block (-EAGAIN) > > so that callers don't have to guess the error based on the passed > in flags. > > Also pass through the error through the direct callers: > filemap_get_folio, filemap_lock_folio filemap_grab_folio > and filemap_get_incore_folio. > > Signed-off-by: Christoph Hellwig > --- For > fs/nilfs2/page.c | 6 +++--- Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi