From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F089ACF31B8 for ; Wed, 2 Oct 2024 13:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 811D96B0348; Wed, 2 Oct 2024 09:12:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59BB06B0349; Wed, 2 Oct 2024 09:12:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9706B034A; Wed, 2 Oct 2024 09:12:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 056446B0348 for ; Wed, 2 Oct 2024 09:12:12 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8ED2AA012F for ; Wed, 2 Oct 2024 13:12:12 +0000 (UTC) X-FDA: 82628700504.01.F896731 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf14.hostedemail.com (Postfix) with ESMTP id 34BF010000F for ; Wed, 2 Oct 2024 13:12:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CIqA0p+V; spf=pass (imf14.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727874559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4y8jBTmqmaQ765rlbFTfYn8ZR3POR7YKLh+55wd/zQ=; b=tw9dJOwVqJa1J3vwpa7KvpBYmSZAdFNM5PolShRkzhO8YggO2L2mx779cU2u4CuegEGYd5 JH4RIrDyKsE47bkDcUOpp3Z557MKmwkIPbTcsRHkSnZrLjeyVk1jLb3MgK9jJT/clqOdkW /LlaBZzv/fkBA7791Azkfl+MbETdm/E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CIqA0p+V; spf=pass (imf14.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727874559; a=rsa-sha256; cv=none; b=cDbvw/B93Hz6dbXMiHCdqIQgTkk8KXXZZKj/jPHyySn5yzB2g8jlgOs8F9wNgtcZt/rmYd B/5TRAICkeWDDsL1ZjntKVKrGjZepZtwzCgjQdu40pX+E0hnM6HBJ6SkvezRLEdkGhp9lm kHAsrAvFgm/Bg71NV8YE57RTjUtcD+o= Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5398d171fa2so4463943e87.0 for ; Wed, 02 Oct 2024 06:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727874727; x=1728479527; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P4y8jBTmqmaQ765rlbFTfYn8ZR3POR7YKLh+55wd/zQ=; b=CIqA0p+V4C8BjRoH9I/jnkFpDz8f20/OHEjwwamKGVgcRrASlmAkXKLA8x4h0aNsQz ndDog6FXmnaTsNI1TWTz3QqCBW+J68u6rkh5QzM9tK3vunBavM//xGyv+SJn+UE4wWo2 hJvJen1p2+hGbadmzoyER2JWjJLu3AkgBW2sBKRQVj+aNIk4mLkElykQ+7RjOIxI3qx8 YLPN/kz/lTcxUFf0FBYaABwALbfPnFscTdpwykuHwiUoou711a1xfbB39qT4fgBO70pc /CZYclVCyy7gWkp6ChlrxB4So6mBEF18uFoTAmCK+PQ/mWmd47yFVPAAtDFZZ3DuVNfY 9UcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727874727; x=1728479527; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P4y8jBTmqmaQ765rlbFTfYn8ZR3POR7YKLh+55wd/zQ=; b=LnZaBjTk+Rx/Ze/r4SJfJugRWpr+u5JQd9AhX4fYT6/3cMk6vRzBWMbfgKkkXbtcOE UjBKWx5LgoZE8wee0vLm90U7oBE2nQkswfXz0loQ7Tk/PHlWTZ576vG1mzlmOMBFiGJU iw0H4eiTk+o0aQZIzhaKj0k16wSsiq/e3oQg54g6kTy0R9l53p0WSSkW/QiAtab0vkQs nHGjQiu0HMv3GKbs6Jz4l6RETYI9FK2D9JltlSsVEjscLm/fqsW6xw33gbbghai5UHAS gxQePCTcgTn2WuoPqKDve6vNrvpCX0ZnpGRXX7oh2x/SF64gW3Wnvg8ob0DqFHAR5Pal 7IaQ== X-Forwarded-Encrypted: i=1; AJvYcCUi/91x45VYcS5pIu5O5uBWvmOQEqFQdYR68joe11bb7uHz1rt68w4hUEvonfFyLwoC4ZuXdeK8kQ==@kvack.org X-Gm-Message-State: AOJu0YwHp3MA3gn5Sanmh/7X2fc5f/uLfU65nb96N/LWLzHwBNnOkmyW fUHYCiccKmodC8yojUngXNH1Eg+S2WUFtbKjvPXWynZIZoQtus5pucaqvoCMHd9HeuC/qhIQ5kx H9eC4eU2NzZAmhxOPuryCHdfaeXs= X-Google-Smtp-Source: AGHT+IEOPzA+vTRDEoKgqlR/0QvjfCjz/hNyhuloe/dk3pCc6OsTIHbciHg7uHGZcLFyaYtf4p7q54Ugf5w8aF5NOvg= X-Received: by 2002:a05:6512:e96:b0:533:711:35be with SMTP id 2adb3069b0e04-539a06834aamr1720320e87.26.1727874726884; Wed, 02 Oct 2024 06:12:06 -0700 (PDT) MIME-Version: 1.0 References: <20241002040111.1023018-1-willy@infradead.org> <20241002040111.1023018-3-willy@infradead.org> In-Reply-To: <20241002040111.1023018-3-willy@infradead.org> From: Ryusuke Konishi Date: Wed, 2 Oct 2024 22:11:50 +0900 Message-ID: Subject: Re: [PATCH 2/6] nilfs2: Convert nilfs_copy_buffer() to use folios To: "Matthew Wilcox (Oracle)" Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 34BF010000F X-Stat-Signature: nikgxeqe7ws6yckcz9oqeghbqxhx8rh3 X-Rspam-User: X-HE-Tag: 1727874728-831884 X-HE-Meta: U2FsdGVkX19Rc1pJ2/gUwkIjC1ZyvF/X2KlMJhBrY/MVi7qNsBOfolYwOZyQPC88pYyaRjYbZGON9vI5zwMWUP7OA4l8HRtTz/wDMyAXwp8OEPLMSx13bZSn3Gf+H/OfRSlli62pQ5nOaq5G/qajtwCwzvyhifSpmqlV5Tq2J3cq+4lvOiigex1ctuRaIOrJi/BdXuXU54A+G88BtDKBar4gagmWoY2VAO2ZsxXc4qDsZQOyH8hcX9y2krIFxpl4V08jxifWw7Cxvkhktk7RQZcpZeOs2O1KaLxYZalehfvy+MpU61aZ/kBy+mSVIvQLaoU+eXXIeRdeEOnOsWwZQ5WdNBuZfgKN4hK6KIpPgK95j6mITLgPuidpbJekdoJ80cginxC6UNjhhCDla//ilPOqlsYCsYjdIZLlYdkSKZskO03GpJkHR2VQROYxmPO1cpO3KYQI05/Ggnofa3+26tWLY3JTZDgZl/ZwI8Sgw2iJ8Uh/1q33wSbj1yEpVyTR2OyijgDrsCeN1ILLXvEYybkB/vVNVbMDEtA0yMSAAjmmuwUuf7hVWVDgaNBzu3X3x7l1Vd80TfJ8Zcvr7f+lZlsLM7JppAlz4Bj/hztU860DIg+mRuO2Sz3sxnAFBPZOKNYXSus3bsAFPTw/BbOXRLkRfIvNHuD3qgs703Ev0nLLEo1xQFMqCm5piRFM4IpVEvOT+xtkhE0M7Xy7GKNBXxlYrK+n2NgETPkHZnpkWHuz+T9Ga/+VvaH6qhCleczMXfOn/YuVN3GuFUsCAKh7y4CbVXz5OuzQqozgMcya9/cuFkCZGajbWxQUask93jNZNguDoXkrnWl98VjAqJprF+FsZ2Z9/rtikbaE64w9lMH/zryaI9QG02liDWGPt+Cp/FXSuGc/eKXKdNhhxuhPpRHgE033c1KzOmhtfN255+l6QyT3phQ8SLDmB3G0jsO2KL1vMnGndMYfxfo/Zj4 7H2Ww5dz wc9TBcc0OXQ/aSNHdgs0AmfIb6r6gDnuQCmG/07DH1I1f53g0Zj0N+G3LoDI4aBGrOfUfzWLn1xg0zftnFRT20S5OsWOPAM9g+3zBJQCwuXPeff/6RQ+/eefSO+lG/nWvS0rFiuVgQgnswB+0TSEkp7HpQy7wIm0y1rb3ReNAbVfYkLmKXjEqSkeNH7mAPGw7Y3YUFoVLvPpKAP+4TjtBSJhtMqmqPOnkROm9Dxi6RbBF046c7ijtcu+PA+5D/YHF/sR8bAWDXZzlGGq9sq+CyCJ8fEfeENzVgl7Nfza6UTAgTvlAj444sAvJz9zNivOw13c/ePkFpTlS8stzJy5Ew8XC5w3Ex4e0omnTz3qg/pTchixhP3vJSfjQ7LgliodaqP3nYexDJQP3YF0TAy6W4xiuMQkhEjLH10i3h1x4s6VTnvuQieShn9espiejUasxkiGqV6BtCVXY6R1m7QYjI//LXeblD9FcYMcY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 1:02=E2=80=AFPM Matthew Wilcox (Oracle) wrote: > > Use folio APIs instead of page APIs. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/nilfs2/page.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c > index 9c0b7cddeaae..16bb82cdbc07 100644 > --- a/fs/nilfs2/page.c > +++ b/fs/nilfs2/page.c > @@ -98,16 +98,16 @@ void nilfs_forget_buffer(struct buffer_head *bh) > */ > void nilfs_copy_buffer(struct buffer_head *dbh, struct buffer_head *sbh) > { > - void *kaddr0, *kaddr1; > + void *saddr, *daddr; > unsigned long bits; > - struct page *spage =3D sbh->b_page, *dpage =3D dbh->b_page; > + struct folio *sfolio =3D sbh->b_folio, *dfolio =3D dbh->b_folio; > struct buffer_head *bh; > > - kaddr0 =3D kmap_local_page(spage); > - kaddr1 =3D kmap_local_page(dpage); > - memcpy(kaddr1 + bh_offset(dbh), kaddr0 + bh_offset(sbh), sbh->b_s= ize); > - kunmap_local(kaddr1); > - kunmap_local(kaddr0); > + saddr =3D kmap_local_folio(sfolio, bh_offset(sbh)); > + daddr =3D kmap_local_folio(dfolio, bh_offset(dbh)); > + memcpy(daddr, saddr, sbh->b_size); > + kunmap_local(daddr); > + kunmap_local(saddr); > > dbh->b_state =3D sbh->b_state & NILFS_BUFFER_INHERENT_BITS; > dbh->b_blocknr =3D sbh->b_blocknr; > @@ -121,13 +121,13 @@ void nilfs_copy_buffer(struct buffer_head *dbh, str= uct buffer_head *sbh) > unlock_buffer(bh); > } > if (bits & BIT(BH_Uptodate)) > - SetPageUptodate(dpage); > + folio_mark_uptodate(dfolio); > else > - ClearPageUptodate(dpage); > + folio_clear_uptodate(dfolio); > if (bits & BIT(BH_Mapped)) > - SetPageMappedToDisk(dpage); > + folio_set_mappedtodisk(dfolio); > else > - ClearPageMappedToDisk(dpage); > + folio_clear_mappedtodisk(dfolio); > } > > /** > -- > 2.43.0 I understand the change. Also, thank you for converting this function to be folio-based. Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi