From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE58EC4345F for ; Thu, 2 May 2024 11:09:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CED7B6B007B; Thu, 2 May 2024 07:09:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9D966B0082; Thu, 2 May 2024 07:09:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B64DC6B0083; Thu, 2 May 2024 07:09:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 985DC6B007B for ; Thu, 2 May 2024 07:09:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44914120DF9 for ; Thu, 2 May 2024 11:09:13 +0000 (UTC) X-FDA: 82073184186.29.94C97E3 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf13.hostedemail.com (Postfix) with ESMTP id 675542001F for ; Thu, 2 May 2024 11:09:11 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N8tEbdHR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714648151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fhA8VLambKpb9wjap82p3kDvxUZ8xK7ATrERgvWkdSA=; b=4B6Vt/KXikO3lo9Qhkla0/ewk+ysLiDLSW3R3ZxRZyy6QQXdKyAlLcUDLLivmVcRXCHjoM wEjKRDm+ZsEM8MLsDKpTkh91Fz1ttrZ6O2ANWFHEPr8b0JzXNpWQdLCZGadcIF1LAjoPgR YbQNW5QzCJ0AF59DeEiofoUOG9mHVqE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=N8tEbdHR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714648151; a=rsa-sha256; cv=none; b=wRsnUa5g4p37mY5195movKQOnRLPn4EwlV+kQgwt/WTe1t5+M59GTzNr/UX8nh5m5uS1xk T16+lXabIA11j4AdyJxWvFarpPPxrt+dyRwct5AjdIh3Y/ccMX7vv2FjJMv9XZ6LX4JwAw jK3odP0myYx6GWFHDClRlpdwzQri1FA= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2e1d6166521so4879921fa.1 for ; Thu, 02 May 2024 04:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714648149; x=1715252949; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fhA8VLambKpb9wjap82p3kDvxUZ8xK7ATrERgvWkdSA=; b=N8tEbdHRM1Ac/hsqD8bWdkmrT7gc61ilduTGiLiI2yadz1EVDKvtAqVN4CPUcpJUDs selm0hVe5EtrV6zv5W/5ZcrpYrr7Hsqc6qO+NBq3+iqbcV3B9fpAEqs+ux00N58Yj02H 3iRknRIecWKEJyr98tOHGYf9gV+w3Qr6mjIeow5SPSYqqbM0fHWO7J5d2XI/GvQUOvOM bALVH6uVsXFzkIDHMN/7+VMD1h3HjfNozF+gmPCLr/sKr9DRQgC75db/g2f1ab4eH1Vz 3Wuc7G7AqPji8HN3zMje6vaa24qxaRhLQv+RiVifZ63TCvNPrLAEpDCcMEadSPBpPpI6 zLNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714648149; x=1715252949; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fhA8VLambKpb9wjap82p3kDvxUZ8xK7ATrERgvWkdSA=; b=fOnd13lutP0qSu368rf1qpucsV4l9FdSzsaezZgellbtvBzvOf/2/oC0aTenMuWCFp mYiieoR86gD3QlrFHd3nFLN7qgmF+Fcg1bvJDri1fjAtYWBoezSBhKDa8eSDymBx0Az3 avhcG9pKZrPndiDf9cqkMBnawC29A6aYnXAb5rL3C2zL5Q6RHNQkNNqXE7YMQrWK+YJ/ 1ujeAEaY+CbsVt8re7nTOpAsCq/91VRHcMRS6IaRrglMeZQbiaLemO7yPfs+c1wwmfwl 5u4r/rSDWES/W1qVJN2b4hwkVxILQE7h1OSE9IEHfbtIQFPUq5SSgFRE72bDKkarlMtZ ezwg== X-Forwarded-Encrypted: i=1; AJvYcCV7ptCuO+1x6bKVTFgpn4256ejnQdYZ2IcV7dIJ76nWprGVXtBW1YXqBttiFl2fgBurCBMvBjvrmVdkO6OaawSxNjQ= X-Gm-Message-State: AOJu0YxGI+AXsuhISbwDgZ8qMyBOAZroleZFGYSlS5MPOTEh6RhR9mDT FdD5BjpExIP10/CYK8UboOol8RAORanfSmEC+z/jTtQ/00P66xSsXdbEw65POyxYoyEsmVTPZwz 9Gd8/VrQiVzNAYPR+Kqnflb0Hdiw= X-Google-Smtp-Source: AGHT+IEMqK/WlDTzQp+B69oJEqZmK62x8gnRdcu9h34/zfAEjG64PWrWjN5DkS+XDB04HBNlIAxP40Qo4poXOKyiDtA= X-Received: by 2002:a2e:9cd3:0:b0:2e0:298d:6605 with SMTP id g19-20020a2e9cd3000000b002e0298d6605mr606951ljj.4.1714648149273; Thu, 02 May 2024 04:09:09 -0700 (PDT) MIME-Version: 1.0 References: <20240502084609.28376-1-ryncsn@gmail.com> <20240502084609.28376-3-ryncsn@gmail.com> In-Reply-To: <20240502084609.28376-3-ryncsn@gmail.com> From: Ryusuke Konishi Date: Thu, 2 May 2024 20:08:52 +0900 Message-ID: Subject: Re: [PATCH v4 02/12] nilfs2: drop usage of page_index To: Kairui Song Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , David Hildenbrand , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nilfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 675542001F X-Stat-Signature: wj44g6p8xjd3wy5df8m7koozan58nxtm X-Rspam-User: X-HE-Tag: 1714648151-874071 X-HE-Meta: U2FsdGVkX18STvRGKdLPSTczk9APfsajrzDqIJnhxgkUR2NNYD1m+dFSE5G/VUAc+iozErM3SycB2chY37B6toS4DeTv5h4/uhLlrYpW80veCyE7+Q5Bi7yPa5+wXG/YslhcfZSyczy/t9+rJocabSTI0b56eu7CoUmNAhac1GsvcDXPTM0fPd1J1fjt+7HKPeE+6sRAdjHmWweNxx4syMDGif8tA1XeyxEIMQGDa2KIkMS7lc8bM0s2yOKMbGODu/tPdhOTjyi9H/th+PvnNdeZOu/VFSsq7ktVWm4xxt+3wS5VEHDk8HOdeBQ79DK1MazrL1S6U06sZii5QNG2PBK7BeVRJpKAkzJzo7dDvks/nElfOB3u9jFBW/fSY2K6Q8QVfdXX78vb4OC0gdTvUY7KEKjbrD3Aod97ciTWS0zZC+bEDc3ef3FARP3CymYNfbHYHUtzUtuuayFFKAa5bEWC1c8ytrRicZMkhvoi7B00Lnnraa0YNWxANMFC5KQqYreC+Lt4KXoHCnTHlSdRgcvEhRTzPpVL/TvMthwXoT6Z+qoK9qPSjalM/5B2pLxiYF+0CqSF8h+JHe5zh/mM3XeaCKSSwWJwtpHIzUI1OmfVjBTfKhN2SQLXTIk7nwSj2m72K+v4U7p+5jetmxdFe2RFTBF/L/5ekSr9/qJhGXUm0hy+tevjH5/YsLGJ+B6v3EP7zq48G96CQoFeDScIofTlVIIxwuOP3DNmLRY414VL8fKDkq8nM1CwJRyR2Jk+5VAw1HmHnWLxJf8yEPg85DGCccmptAv9r+HSTxCv1OG1aksGCwFcxQdyi49FYV+pG1LE6C9y53+BV2ocdNli1PN6zhPqnTi/jrCilEv8VTXkYYNzEszkfxEO7YbD0AenVMKtpp0+283PWkmb9JwtUQs1dUtOT5IkCyGwgDbW7RoJ2X5F/m+1VYdAAouiAJvIc75kkMl5MnFrgT+XILl M+NQLj9M SEb9Rj1bXGeYHl09p65eTLDstoCAHHeSlI9qGkJN4/8hGYvSPu5wTpbUik4rj7HftJ+7KbQUSGucDf6RrPz9Elv+19CfUKYSCx1E8b6va4rz0OE3igyzGMjGxUFcG9e4DEzK7amRyOfDA+jjvrIH9JjkKWMkKjqI3vLe7qn4zO7oy6CEMq5jfjtl9yp9uNDsZvD76EJnCwOS0O0IvxRfw+vUJ+OS0Zch10nmZcJgeuJpzALyo4jDHfQmRnInI7ZhbQXRvW9uWNiWde6CMzHA83bvBhQqGdru95snnWR3rJ1gGyPcKNvn2bjg30RZP0cPoVb5m8HCNPVm2Agqec94Tf+iVBKSXQXPl2JZw8FzmxftA3nNlvWqtq6pukM8yM4U3P+AESHTHlAChVmtm9g4QCtRGfIjvANpGfwd4Cbjtyy+7JD3iIr11bKbFqwEa+mYDEjf6g1y+n0TCqFGji54qLynkpP+Z5PXUD1M71+LEo/J/MC10n/KaBEvoGwbnJz/QEd34Ct7B2d0PLqvEzo7/3SyF8V0PcvYUujFPkSIdmFKujhFQTgDgoL6FCNOHXNIq60C1xednViaGNHAVA8oTYY6oP0pYKpHm2Rr0Vwy32i5zpxqv0S/ks04Z2qDGuzOFWs0D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 2, 2024 at 5:47=E2=80=AFPM Kairui Song wrote: > > From: Kairui Song > > page_index is only for mixed usage of page cache and swap cache, for > pure page cache usage, the caller can just use page->index instead. > > It can't be a swap cache page here (being part of buffer head), > so just drop it. And while we are at it, optimize the code by retrieving > the offset of the buffer head within the folio directly using bh_offset, > and get rid of the loop and usage of page helpers. > > Suggested-by: Matthew Wilcox > Signed-off-by: Kairui Song > Cc: Ryusuke Konishi > Cc: linux-nilfs@vger.kernel.org > --- > fs/nilfs2/bmap.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/nilfs2/bmap.c b/fs/nilfs2/bmap.c > index 383f0afa2cea..cd14ea25968c 100644 > --- a/fs/nilfs2/bmap.c > +++ b/fs/nilfs2/bmap.c > @@ -450,15 +450,9 @@ int nilfs_bmap_test_and_clear_dirty(struct nilfs_bma= p *bmap) > __u64 nilfs_bmap_data_get_key(const struct nilfs_bmap *bmap, > const struct buffer_head *bh) > { > - struct buffer_head *pbh; > - __u64 key; > + loff_t pos =3D folio_pos(bh->b_folio) + bh_offset(bh); > > - key =3D page_index(bh->b_page) << (PAGE_SHIFT - > - bmap->b_inode->i_blkbits); > - for (pbh =3D page_buffers(bh->b_page); pbh !=3D bh; pbh =3D pbh->= b_this_page) > - key++; > - > - return key; > + return pos >> bmap->b_inode->i_blkbits; > } > > __u64 nilfs_bmap_find_target_seq(const struct nilfs_bmap *bmap, __u64 ke= y) > -- > 2.44.0 Looks good. Feel free to add: Acked-by: Ryusuke Konishi Just to be sure, I also tested this change in different environments, including 4k (page size) and smaller block sizes. And of course it's working as expected and so far hasn't broken anything. Thanks, Ryusuke Konishi