From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F76C7115B for ; Thu, 19 Jun 2025 17:48:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1087A6B0092; Thu, 19 Jun 2025 13:48:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E0206B0093; Thu, 19 Jun 2025 13:48:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F386E6B0095; Thu, 19 Jun 2025 13:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD6336B008A for ; Thu, 19 Jun 2025 13:48:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6B6A91D69DD for ; Thu, 19 Jun 2025 17:48:19 +0000 (UTC) X-FDA: 83572884318.04.1D4808D Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf02.hostedemail.com (Postfix) with ESMTP id 9627A8000B; Thu, 19 Jun 2025 17:48:16 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=leV7bkAE; spf=pass (imf02.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750355297; a=rsa-sha256; cv=none; b=4iDyOCZfUP9V41OMvaV7Lresoq0OYtLBJIrBLc2TOBSrRUE4WlsimdKt9RwOx4A/UcKVo4 x/A9gl0YjibY8lPjGAISM3Mty+wCBjADK6p+mJLW4YZXbCLRP8vCfFPq7w2Xx5+5vQVVVT GTC2VwFM+XvVyxnIlAwfGfMPEhNfGeA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=leV7bkAE; spf=pass (imf02.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750355297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YvO5fzYLvhWnXwDLeu0osljtoe46Ll4TNlde5gM445I=; b=YGBPWCNKEYE6viL+x8N9ReI7Qf30pbDKtP3BkP7sOPt9zqoC7sUuvNLKhRBf/6KtH4qaB2 bYi0DUWA7hxXfQwY1Z6tcrEXYwP6JiE9D4a93I0gHSJWhO3jmeyTDbDYCjkC5Rp0k2FO9M vOtRe7E6+Ot69MKUqqKBO+FEDz7Vhv4= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-32b910593edso5461551fa.1; Thu, 19 Jun 2025 10:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750355295; x=1750960095; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YvO5fzYLvhWnXwDLeu0osljtoe46Ll4TNlde5gM445I=; b=leV7bkAEb56hiqbfjDVVel42BR3M2E9gf1u2aiXqJhGAVfF3VWoaQIXOo+1hAvZtpg 4fif4R/yS4KHDBeNyrHF5a7gddUtm1kL0raMS7sg9U7XI8gtSu2FOhgUrfS1w4Ad7CuK fsq6Nx7CHNZKd/Y4YzHvbXnNHBwAriTEPG3sMPN9qwMcDaU2Pgm72n5cerRU9y5MARly g+IIpfPLtwxAV3Ly06CUE8k3wpBs0c8kGAT7a5FDZvCol8HNy5sq7FSCcugHdNhAzaKE sArdp+VRflt2v9GL1lzYURfGhf0amEfDEMEEmOcePIoeNdufwb5JieoSIiH0vk1E47KJ zXFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750355295; x=1750960095; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YvO5fzYLvhWnXwDLeu0osljtoe46Ll4TNlde5gM445I=; b=cpoxXdzvFSxC46eb0j9+vHbyfiurDsXhVtZu/m4gTVvwWsWABrVdVaV4iaFeQzfZ2k rGUlHGb32ebth5gasVLGeobQDNMYyF5nzBxscmHryhNRTtOgzOKJkBguT4FhkecKFbXf 6qORSCxCzekx/dL/xG9U44DBB+sRDT6ASSxD0mZJR3tDkG/FAW0j3znbB/xn5r318Qu1 8XmPUvdzC9k93ppsj27Mz/EvPXSdrqcmWf1/bOAEJSYIuIHJJ1QrzRaaXurCu5lPQLf7 HBf81DO/jL0AOLmecQoS03vybiLVdjAt4k4U0tG39tE1kSjTGj9gj2MZAZ07c8OXGYDv SAjA== X-Forwarded-Encrypted: i=1; AJvYcCUNrDezUi9A3H6sYbpfOHzlgIR7DXfYWoKSBe4lyCTE4mGq0sjjN7loXENsYYgFyAolThtT@kvack.org, AJvYcCWkWa95391nXc8bFTvCSLGKqF/8UBIH3pRGM3REZ/JA6G8pd76SOCbRXmfJGjvHY3U6BMjyby2nOTg=@kvack.org, AJvYcCXckRpOA8mqZxeVTLknUOyums0ymvihg72x7xuWPtNZG3iyiZ7kDuFPzcftCSpVhBx/3fcDIsXyu41f@kvack.org X-Gm-Message-State: AOJu0YyFtwEYh5zG36aDwxAUgXlzk1JiIup6vc+7NyQK54LlIhnvPns/ u0pQRZ2p98gCRRgFvmIKmypzSKLAceKPBxZwikh2tws6OcUPlGEJyKu+cIxPXBCTPt8IF/V+ORJ 12MvHzrXLgiz+EDDBmsmCiUqSO5khZVA= X-Gm-Gg: ASbGncsYyFbggifJ6T28RhsgP4xPm7JjSsHI9x//HmF8lFimaMajZV+vrrYGK3lqFmH AucyVuA5JGYGmDyG+8r/Tm3fX+g6xPENXTTYwSsogfK54jrlwH4mIh4KhNM52gjI5e3N/ck91B/ nu+whj+qai7VhOm3ZR9fzMDktH2QTzjGEKcW50OgUfCgXT7BiTKUxqjUPw4zMlFjRixfLsgcyjo m1opw== X-Google-Smtp-Source: AGHT+IGL41V3DbmFvBsWr3jGwFHfcX0duW69mbczpCAOINsa85ECUigYdfUlpWqgF++enxibRnhFFvr8Kxdp2WtP+R0= X-Received: by 2002:a05:651c:2203:b0:32a:8297:54c9 with SMTP id 38308e7fff4ca-32b4a3088bbmr63065741fa.8.1750355294494; Thu, 19 Jun 2025 10:48:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ryusuke Konishi Date: Fri, 20 Jun 2025 02:47:58 +0900 X-Gm-Features: AX0GCFsRgomy43xV-Lv7Stfld1a1yqIyJ3-ysZ2OVO90S8cEE5UAjZMSvGqxZQ8 Message-ID: Subject: Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9627A8000B X-Stat-Signature: 99fzrdroro1kfd5wcc1za9o7cyu16sqt X-Rspam-User: X-HE-Tag: 1750355296-238217 X-HE-Meta: U2FsdGVkX1+n8tdd+ZkbnO1bDxbSFQ4do9ua6CQlZEWRFpOmYJLbGAVv5RfOeuBsfB4I3l/YsvNSt6O/kqsIllffKX7m1ngCkJO2TfeLHlz2Mrhv1dnX25hvOIttBI1GEynOjN4oO7Jexn2jhOtSEH8rGSVU3cfZ+n9k/IDX0UAzIhBZdU6eRXjg0v3WDQ9rHqvBs5ZP4z2SU4A8Ob8U8Xr6yoHXLfLm2fgbM5OCT9yNHjA8qXcSM+VCGUj4PTiNdYwjeGis4cbJKftzRIkUt6xKP+LHdyZnZCu/UJtpCW6QW/7Dr88ANeTKymZdUpBtXcLA8Vn21HApApxQCNmwvvdpTaZ9ybK5hdQ1JXv2JC6cGN5iFuJYjmQWlSk1bhC8JzAgkgGo/J/uBoxlw5yQznK//W4JhnxfQ+t3UtbIxWEyTvjqCOJdp0XTt7eTs2uCsc3HAk6pLbS64Welnj2UrlKxXTJbP+WKKY2dtJmC/9rcoMjte+zj22rpOnnSeLFfI6w0MsnxEBhm8+ajo6kv7WEj1AzORKXC6hOKoTsQh+wvUN9dUVWPCC8S4+VXItUFS94wFVtOubehKMkNct2+19ZrhvgP96mTotcY9nClzZY29PVleJhsxbVlKfOX5R4apEBO479PrD/wBNcw5JGupfAxNvXJbTalCCBKQsoQTjrVse+zPXXQUjeG3lxftZ60rCjYfrtZjXulh4pYELJ6OIYRFJm7RLd+kxWm3pK8mqQNmWdeMKVyYS7zC9TNEfvxo9cktBqIy61Iu+Ij11J7EW3C/8jCaq3uCuRFSS+r94LDjD6jkRrUdNfR/LYapAfYlsX7ovYkLhnB/bur7VplNfzQSGG+WF2VqnbrFhqG62IZh+LSBgdWHhoL8lH/uBufwGCK4at1HxrcLxfbcpnHsg03LwuvV+SKhpWpESVj/46Nhy1NYBu0poJxUShUd24gqPuw/pNLL2A/nEEd1kn 5cQag/0e A4qlADbUySBvK+aUSf4K5+g3zElb0OQJKsh97YuxvbMgtxEYIXfM76RAWFG1NvX263vjXnrCFuhx36OWSkX9VCCcsc2E3pOOn+G81cAUgE/AhhEvpGgGOG5/lrJvBK6jmHjrJA3s4HpKFb0lW1ykot1bfYnMb5ORn/kFlFGG600XnMp7qiqt59aUyzXaGUTkmpU4Hmueuo+JjJ8yAl5kuxyiBKIaNYr8JPqfqZ2e/LIciPIasAmZnHZZAeFQeT7TB7Nk7PyCaCncELhDsX7odYECH6FemMIfKIOjkCBvtwGhniJMjJwRtXlGnSFORQ6oI5eR3LX4cosQNIf05E2P7PKRMzBTdx2snUEuBVPa9NpHjvK7UhfccKxOE7J0CQHJbGsCpw9B9JvFzEs6Jv6xZ1WkqHFJ80+xJhbWsZvUPM0qan4IuFzNqTdFv2nZ2/oToT/dmTTYPjNfv/E4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 4:48=E2=80=AFAM Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handli= ng > can be performed more safely without complicated and bug-prone state > unwinding required should an error arise. > > This hook also avoids passing a pointer to a not-yet-correctly-establishe= d > VMA avoiding any issues with referencing this data structure. > > It rather provides a pointer to the new struct vm_area_desc descriptor ty= pe > which contains all required state and allows easy setting of required > parameters without any consideration needing to be paid to locking or > reference counts. > > Note that nested filesystems like overlayfs are compatible with an > .mmap_prepare() callback since commit bb666b7c2707 ("mm: add mmap_prepare= () > compatibility layer for nested file systems"). > > In this patch we apply this change to file systems with relatively simple > mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2, > orangefs, nilfs2, romfs, ramfs and aio. > > Signed-off-by: Lorenzo Stoakes For nilfs2, Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi