From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA72CDB482 for ; Thu, 19 Oct 2023 18:31:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD0C98008A; Thu, 19 Oct 2023 14:31:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C59C58D0087; Thu, 19 Oct 2023 14:31:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFC178008A; Thu, 19 Oct 2023 14:31:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9A30A8D0087 for ; Thu, 19 Oct 2023 14:31:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 449EA140F9D for ; Thu, 19 Oct 2023 18:31:31 +0000 (UTC) X-FDA: 81363053982.29.4CF6126 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf20.hostedemail.com (Postfix) with ESMTP id 826941C0005 for ; Thu, 19 Oct 2023 18:31:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ErReSiZW; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697740289; a=rsa-sha256; cv=none; b=uGJjLRMjUT6NtZpfR3m21PpaTsMHS5bFFfNH6Kir44eZEqHGxAK0yqg6X7FWkeoY0q3tth 2PUT1mxKj/xhEzLZq9isAb3NelxQ7S8k87rd5odBle+4RrdTXLaIGVQbtLWohKTgCpk2Y9 EkRaQlF8+K2MZsAm7WzSLcZawWnP0Xg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ErReSiZW; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697740289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FATldl0l8mttX55l07QCYkeMIDaJdk8BK4gw4WswyLw=; b=tYQUnL24VZsZ0ilFB4uo2qzXF00A8LYZ25wLsSoQZhKxTaN+1Aowjya2loC0m9BMB+L6mm PFP15wfg6TdzYIbqmwcsl/EUMSEGb+KbTTqhvQWY1y0H0TMXZlgzuTcYkw1SQBqQX40ZoX 93ynvOK9DlNet+QPa2lH0em2FrBvDV0= Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-7a6774da682so349139f.3 for ; Thu, 19 Oct 2023 11:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697740288; x=1698345088; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FATldl0l8mttX55l07QCYkeMIDaJdk8BK4gw4WswyLw=; b=ErReSiZW4HFiI1FVGZXdMhn1cpGUHN7xXALq7e/vgJEqEZvNurNHvy9xZTgnKqqEFn pTs6TdWZTIg9Yf3lBr/W0zcv6mUaPYtS81n8MzcCNjJS3k+o4xmWMyehb+YJRql9Mxj3 t5CDA7D1ab69zm47u7pH6aC21fmGtN7U6P0IceX8ARG4cdUuw3RFBncta33OmsUTqp6R rJilgHjiY7B5dK2VzQ0zDDE+TjrVhMxrx09WR/W725XHUko9cWR1hnADD51lJSXfH5WT +y/VYJCij7s/exARGUkXKRGFzaMAvdspOkw58C+BuK+ntgFqkNAzuyoxvftKSOubx/LS Jf9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697740288; x=1698345088; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FATldl0l8mttX55l07QCYkeMIDaJdk8BK4gw4WswyLw=; b=cxSEyRCOoIfVjqmzVsdZPUQl2N+YY+SdYpCLmqfhxOXXtshr8WkukqiE/jUNArqknC 9nOb3dFFZBZcZrTg2S7ElTU0FUF3b5LrwCcbMdpC+4PsBrwCSNgLGsEqFKlW7gTDQz4S j8j+Skg0PVy8hHbttAPUMlctRMaCCBvxOp05sW3fngKBYsG3aCBN/aEJYjur5Q5Y3Xyp wOA2PjYG7GX5hqP61Bx32+97cBbFNk7eEjSvNR2J67F+jarECWDYnYE6sLiIpt4GnmCi i0UMrh3e0m/Dyo1xg0z8aLRmtrk0LiKwF4GATnhX4k/b4cEGLXn9iQKq7pAvd20iPi12 1OVQ== X-Gm-Message-State: AOJu0YwCwXIueDCds0d0pkF5Dv7pyLZ2TIdTbW0gMWNQcn12RxVRhL8h Ah9/ccZ9ygjXbTzqsfzleNlshyx0ke5WrfB0tAk= X-Google-Smtp-Source: AGHT+IGo+8NPtVX5fb+D7jnXSCuJVS3j4eo9EyDPP79ozV2p34OA4XsPalOD6Wj2OQxipW14FJDZNZE6XoUZ7d58zBs= X-Received: by 2002:a05:6602:3f94:b0:79a:b53c:d758 with SMTP id fb20-20020a0566023f9400b0079ab53cd758mr3507073iob.1.1697740288418; Thu, 19 Oct 2023 11:31:28 -0700 (PDT) MIME-Version: 1.0 References: <20231017232152.2605440-1-nphamcs@gmail.com> <20231019101204.179a9a1d2c7a05b604dad182@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Thu, 19 Oct 2023 11:31:17 -0700 Message-ID: Subject: Re: [PATCH v3 0/5] workload-specific and memory pressure-driven zswap writeback To: Yosry Ahmed Cc: Andrew Morton , hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 826941C0005 X-Stat-Signature: p9wxuskbfmp5it1w7ae7osiaeje3mz8p X-Rspam-User: X-HE-Tag: 1697740289-593735 X-HE-Meta: U2FsdGVkX181gcphHlPlVlulNpd5xYyGHzMOy6SUdfQV2qO+FAVQknvlERW07R3eYvpvH1UknB3hWRpOa0WLFnmUkRk+/D5IH6veIxdaiYteZTKMKX3bmTHO3Sku1ZtyNXh2nvJvLCTO6E5cQ0GCz7uk5XbtibHe91LTwN957YawzY6Al8FJMKkpJ0LEiqB3mH1IsdMKE7ODHDG0XUWil2dCDO7drEmrsk4hGtGacYbURa0UbiH5nwcVvnqhxiv94AsYgUsKH8+d8JI1ki2DG7Yf5AlC6rFZgXluGfEEauOSXAo5VmGgxAZaESRzkJSWfcpLrIIWB5w2FXuBysRUG1Gi/pip4bmS/9vMUlsmckPwWblZYSUF4UbpHpvjnOsPOAxAK1Ccr2A+PhhDirgRzA62suTBPff+GIUAmqFyGDzm3f9r8ukagJo8Xclv8PeMcTcMprfSY9NOAcBcIRLE6RnyhQl5I7KlKLwZtePKePwGB5lpyp2MMSRFxqB6j7eI0gz9cRN20yDx2fcpSvbilQdE5ka0MgoCoEYzkMGEeqIrhxQdADbyjNBGxzKU/JwZiODFRnhFpNPCH9vq+1aXYnOLjFoXKB1aRRBJFtpRDLobq4ATchbPG19FIm++PWwW0fZoE+5oMcBKiaDGoxyOYWiVexBGdKjuInzjCKwZ51Vai2iom6hyDndhtfLj1+B1uAp+r44xoPQQftg9wxEWZatgDrinZYsm8pITQtFoJdv7YXQjrd0dtJ9qE7OmVp2A/6No20+/mSmh4bjvb41B2XJGXw+pOmE2BBfy72XwpSyhfNJW537Qk1kUfEyQbIWzAcgxGZwWuOSpYipNgcFX4GuSR1zumdPUGvZ9je776EKGSU02/sqtEBBqweqRt1G3IP9xj+27MBl3oCurdjdhqIUuz0N6pE5ntBezteACxS/FGjaOY8sXc17fjxDZRf0VX3WpK4F+tm6lZRr4pjw CF99SF4K Q62tfUWmKXIjPapu7xTzMdwqZ1iG4u3KAHxNLgrZcQHVZM8XhuUrS1VOotcOuJfmHxtPiBQ6xeJ0cQZXRC0+EtmgvrOXqbPWI3ZMjaAFSOIt19XpHf0RFH5jS4u/Yzhy2HRkUWS7n/gvOXblDwku3BZoVhvzlkoW+l0eaE5t6QF0MXoIAMmPdlaWkj+tdld6mY7RKd99nlkz3vwusX1R+k8A5WtM6UCZhFxdjkdYJnz4Mem5BNJSPSuYt1ISg/177m8JHOiHVjwC32fJa8+UwwilyGQWdOZKHK6cUJUvHncvv83ki87g4L4JiXlTGjiL4WQEn07YhzEIZJHUjtPoqXBgUf56lLVT/B61qzCMkGuEPy8epgy9ueQY8FYIVIGwSPktAfjhgU7Ct8TKomutq0t6nkCqtG1/npOOlWxRi5K/1o8xZE8MO9uG7w5w2U7xhgA0UedfgxX75ORc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 19, 2023 at 10:34=E2=80=AFAM Yosry Ahmed wrote: > > On Thu, Oct 19, 2023 at 10:12=E2=80=AFAM Andrew Morton > wrote: > > > > On Tue, 17 Oct 2023 16:21:47 -0700 Nhat Pham wrote: > > > > > Subject: [PATCH v3 0/5] workload-specific and memory pressure-driven = zswap writeback > > > > We're at -rc6 and I'd prefer to drop this series from mm.git, have > > another go during the next cycle. > > > > However Hugh's v2 series "mempolicy: cleanups leading to NUMA mpol > > without vma" has syntactic dependencies on this series and will need > > rework, so I'd like to make that decision soon. > > > > Do we feel that this series can be made into a mergeable state within > > the next few days? > > There are parts of the code that I would feel more comfortable if > someone took a look at (which I mentioned in individual patches). So > unless this happens in the next few days I wouldn't say so. > I'm not super familiar with the other series. How big is the dependency? Looks like it's just a small part in the swapcache code right? If this is the case, I feel like the best course of action is to rebase the mempolicy patch series on top of mm-unstable, and resolve this merge conflict. I will then send out v4 of the zswap shrinker, rebased on top of the mempolicy patch series. If this is not the case, one thing we can do is: a) Fix bugs (there's one kernel test robot it seems) b) Fix user-visible details (writeback counter for e.g) and just merge the series for now. FWIW, this is an optional feature and disabled by default. So performance optimization and aesthetics change (list_lru_add() renaming etc.) can wait. We can push out v4 by the end of today and early tomorrow if all goes well. Then everyone can review and comment on it. How does everyone feel about this strategy? > > > > Thanks.