From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82728C001E0 for ; Tue, 15 Aug 2023 18:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E30F940026; Tue, 15 Aug 2023 14:09:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 193C58D0001; Tue, 15 Aug 2023 14:09:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00D54940026; Tue, 15 Aug 2023 14:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E5A178D0001 for ; Tue, 15 Aug 2023 14:09:24 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A278E40DF6 for ; Tue, 15 Aug 2023 18:09:24 +0000 (UTC) X-FDA: 81127126248.10.5723AD3 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf23.hostedemail.com (Postfix) with ESMTP id 9786E140018 for ; Tue, 15 Aug 2023 18:09:22 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="Zb+6EOo/"; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692122962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BUTkeUiSYRZcU5Me9frBPWYrk1Agc7yrnJKvjQH2y5Q=; b=f+dSDgDfysWxgO7oWVDqK4xniiXsIDJ48eKUyrynJQBk5Ty5OlH7qju1LdTw6UG/ql4Ocd /vlr7L55433LyCbm75BJ7/BI2x1OzYQqTX4XvXCwLzfsckAUfYQYPwqcBa4T2L0ba2GRUc D9p2bgs2L7eN3pWszx5XDQG85gSlWmg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692122962; a=rsa-sha256; cv=none; b=kS+Xn8TU1Mftktc1TBpY4s/+TZJXwMlSsYznzLUp5F0NMbNug0gz3t9OxvwG6C5EuoLG77 ThfqZu/crzo2AQqjG3Y9fXrcS8hsMnF2lI09omeGtkS/RCO2oj9ZH6NwKfVKEErZhyZveo 1jVcJWVt599Pu+2nMFuYsXdJx1YsFT0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="Zb+6EOo/"; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-790a590237aso257661339f.3 for ; Tue, 15 Aug 2023 11:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692122961; x=1692727761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BUTkeUiSYRZcU5Me9frBPWYrk1Agc7yrnJKvjQH2y5Q=; b=Zb+6EOo/4l+LM3Rgdm5UnqxiYtIKLc4eLXK0xtkAfRymYk+ayEIMX2a4iFza6uZ6bO vJN08JYjKNO/3sObQjkcgaqrfYLJy1Q0ql3b5aUoZpOm79Yox3mKopZ4FAQVQbyGwwMv /ZqiylRBt7Ei09ppRWQFP5jeirjV7pbwjK4n9aHc8tMR6keCKVWFg2xVDWPXu8aOByr1 aPPmjTZyiIBKgIWyP/KnjJpNkLOmtKIuOwFNAU2keqoc/xGemIJ7qpxifExdEtE6omE8 wn5NTBnsYgglIudV7tazHlfaJnshUCITxp0VxlZLx4kHcd1ta6ecv9z7Qz0avqcQQ2fG DIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692122961; x=1692727761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BUTkeUiSYRZcU5Me9frBPWYrk1Agc7yrnJKvjQH2y5Q=; b=YGkBWJBH78VJW9AwSXE40qRvRoKkTPVjh0dSwpCo36Ig4Grf2L5WzpVwGvb2JhTap8 VvEDJZKU4/U3aLZ3sEl3OgVXJpg4H9avm9NAQhhx9HPTpS8ZHzO2B40LOW1vHqxaxLYD Z8Xc5/dRbVLm8GeoGMNK34mFNvFl0m4MDMIdSIW3nehYTNMpLcR3QdiAqrh5v/S+nI4V QM1/xnbHfPdu0SCQ8eK/tOdlzvxlUCBR1MwCmAN7Z8UAwKdsP+EocNkAU4bHzCtvnlhY bx6BuLGnR2wrXiOFTYkpmFFZV6GhJi1q9KrLMMAi4vDeQCl4YYMVgEQdTxNRUFCUG1uH QQQw== X-Gm-Message-State: AOJu0YwYpQliSNd7F/u2L01gplOKN3O//6rEQQ44oSYYZo4//s4WJQ/f ai2kH82PCTjRy1CzwCkSwjuALyENDMIOZKO66YM= X-Google-Smtp-Source: AGHT+IGRTQYv7CsT8Fs4KvCqDa1g2VSZFmEY69btb4LNTnIZwsRQ6OArrN7wFiNo3ssygDBmv/toau7cbyVLZ5QITEs= X-Received: by 2002:a05:6e02:ecc:b0:34a:9120:d7a with SMTP id i12-20020a056e020ecc00b0034a91200d7amr11414230ilk.26.1692122961590; Tue, 15 Aug 2023 11:09:21 -0700 (PDT) MIME-Version: 1.0 References: <20230815155612.2535947-1-andre.przywara@arm.com> <20230815155612.2535947-3-andre.przywara@arm.com> In-Reply-To: <20230815155612.2535947-3-andre.przywara@arm.com> From: Nhat Pham Date: Tue, 15 Aug 2023 11:09:10 -0700 Message-ID: Subject: Re: [PATCH 2/3] selftests: cachestat: use proper syscall number macro To: Andre Przywara Cc: Shuah Khan , Johannes Weiner , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9786E140018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rcoernmxanaos5n1nwiog8bmgkde4esf X-HE-Tag: 1692122962-672574 X-HE-Meta: U2FsdGVkX1/+lNKWNOXZDNMJTl9v9MV8GviotnLHB1cg3G73n6rRMQWZQ2shm+dnA/Nm+5cFmyO2j1Lu/d8frT35f5YL/kJ2r4Vw7ftpfKIy/r2DS9qK631nMafYAU/MZ/XmKWEp9EzeEJJ0SGxzIVUZC8HxX8R3VasUXYUWyqxKXRxFWnIRU8X9Ai5W+uaO6dVSU9a94viMgX2xOtT/THtxs5ZXfLJ3MXcXxD1tGexIRSTa/HmaqNq4Rb8FjoP1UQqoUgSPmOKUliaENt4BEJaBN57VEYYBpoF/avQtke9t3G0JuZ1uVqCJTBjaGPnED4PtKgWf7nxOuAQy1VAgxsxl+pgzdEG4sBD+jBP/UUhPx82E7lQrr7loCpogP0F7+XySH8A/oMfrLm2vusY70XHvfw3D9wrVveM/p2woOFjfmgfEEVtlOpaemezsGu5XRMdx6D1PSHHzZqCTl0Pm/nfjn5tJSsOUypKu2plkCqt4V9PtGhJiWq2kRduX2YgWbW9iTzb+1jcVoOVDSn2roE2A0HkmUZdRZitUqLJZXJjs2kn1DFbHHnr6Evb4CYl1ai5mkJFyRTq6WlfPAgFAMIBjwsPPb0GLHoeycPC1SzSRzS6IYMFdDERDUhS0dSjEToVjbU3elpyL74lUP+H7fIZ49kWuiitnrmx1rSyBOxIlI5SbzjTI44piseyzDq7GQIAFf6dCj3zSuWT9I8Xl4fFcEm/PsWUF0fIRfSaYQ82qzFlt/a5bWYKCK/ed7qZ0JxC8Jdss3Ly10X8Bpi6E7TyO20WpBEe46NKMH1FN7zHb2vNqX3WdyPH32ZRv4RJENuVZfXijHcPQefIj2L4j8LjM28NkvqdoE90iRXf8zzyTccaPgNLiWBskYGoGuG3ZwiXMJVpccPvKYmXPx5m+hMU7oqJekmr9B37rmLV2nNNQ5FIjpacw2oYZHAnUyPC8IwwBhGxsqh8CgRnmqd5 9iKRpcI/ wvsKNz9lBiGJZP1Un+BcjyNkyiASdYGQT8LNfk7V6ZArN+wr+pshK5gB30VEiNsz/SM3f30FhW3yXPpLqMkvJIyktqW30UX7C1V7F6ZmNgfuvZwkuA0Vp0zJLkGL98RYywLql7LyILPGHgiBBVAiPyFiCaNvCghtxI4hr9rrDalIuna60dmQGeW4HC8ce5h0dzpQ6vKS3+X2WmqlXorE82O7B8224G6NsRazWPtEb5zj9NeKjkvtyOHtJT6vMzRF5TYYN3deGT8W+9CP7/d6VCqCqxoY9wbRqBuBvzIESsgrIL95m1eA+eSTnyH982hQQu9iKM4jOIPOUU7MpgheAhbbgem+tu+Ngyro4IKMqwyxLtthUPZ3lcLmfkKYGXY8rz/zjQRcphAZjWPkIKU8fv5v4VXvZTQ3uJFcyOoWBaI56JW3P28avYTk1SA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 8:56=E2=80=AFAM Andre Przywara wrote: > > At the moment the cachestat syscall number is hard coded into the test > source code. > Remove that and replace it with the proper __NR_cachestat macro. > That ensures compatibility should other architectures pick a different > number. > > Signed-off-by: Andre Przywara > --- > tools/testing/selftests/cachestat/test_cachestat.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/t= esting/selftests/cachestat/test_cachestat.c > index 54d09b820ed4b..a5a4ac8dcb76c 100644 > --- a/tools/testing/selftests/cachestat/test_cachestat.c > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > @@ -19,7 +19,6 @@ static const char * const dev_files[] =3D { > "/dev/zero", "/dev/null", "/dev/urandom", > "/proc/version", "/proc" > }; > -static const int cachestat_nr =3D 451; > > void print_cachestat(struct cachestat *cs) > { > @@ -126,7 +125,7 @@ bool test_cachestat(const char *filename, bool write_= random, bool create, > } > } > > - syscall_ret =3D syscall(cachestat_nr, fd, &cs_range, &cs, 0); > + syscall_ret =3D syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > > ksft_print_msg("Cachestat call returned %ld\n", syscall_ret); > > @@ -152,7 +151,7 @@ bool test_cachestat(const char *filename, bool write_= random, bool create, > ksft_print_msg("fsync fails.\n"); > ret =3D false; > } else { > - syscall_ret =3D syscall(cachestat_nr, fd, &cs_ran= ge, &cs, 0); > + syscall_ret =3D syscall(__NR_cachestat, fd, &cs_r= ange, &cs, 0); > > ksft_print_msg("Cachestat call (after fsync) retu= rned %ld\n", > syscall_ret); > @@ -213,7 +212,7 @@ bool test_cachestat_shmem(void) > goto close_fd; > } > > - syscall_ret =3D syscall(cachestat_nr, fd, &cs_range, &cs, 0); > + syscall_ret =3D syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > > if (syscall_ret) { > ksft_print_msg("Cachestat returned non-zero.\n"); > -- > 2.25.1 > Oops something I forgot to fix. Thanks, Andre! Reviewed-by: Nhat Pham