From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C241C7113C for ; Wed, 28 Aug 2024 21:35:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 930676B007B; Wed, 28 Aug 2024 17:35:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B9526B0083; Wed, 28 Aug 2024 17:35:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 732556B0085; Wed, 28 Aug 2024 17:35:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 54CD16B007B for ; Wed, 28 Aug 2024 17:35:34 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E8DEC407A6 for ; Wed, 28 Aug 2024 21:35:33 +0000 (UTC) X-FDA: 82502960946.07.27C6590 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 250EC12001C for ; Wed, 28 Aug 2024 21:35:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bA237EEK; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724880862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7q/65fw6u/ET/AVvM+frdRKGbRF91OUqQsqzQ+d1cFw=; b=Yn+wuhfxscMwWGLNEpLwBkzz893iYNVcJJIIs4UK8L0rMyNqlaEH4iGWPVO0zBx2aew9C1 EZPJIvfjnmKnqKZ/VueoD1Ujzsqjc7Vz9amLd116cE5CjYXC4MJpzOUoSUgiuc0bvSlufZ eBfBQMVkuEoKuqbZt96qRz5/sMDp6FQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bA237EEK; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724880862; a=rsa-sha256; cv=none; b=mMTRjDGS/N6wWnnOMb5SqR0N6PChdTzC83eTwjAcfvlaCeV1eKA5Z4LDqjc1DriopT2j7p i4E/gT4fo1Y523MC4czpw7b17YV0ZBiFpAI+XMODhFEo14Tv9UyrXnpdq4pKW3uImZWWrE SBfJD8wuJMUypQNV1wisE/uPkz/XViM= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6bf825d779eso48516d6.0 for ; Wed, 28 Aug 2024 14:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724880931; x=1725485731; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7q/65fw6u/ET/AVvM+frdRKGbRF91OUqQsqzQ+d1cFw=; b=bA237EEKb1+PLBwyyHrRxJJESPL8FNe43G4GS6xgaQgBePHd6iORIcV7lYMdrpfub1 3gAUN+jWDR4gmUZkrjSdcyaly8cVJP1DmUMSyAuUG1ymV5cYV2OrYfIT9+mQWWQIRltD 0zdtvFNDaNet8U0uJJZXRmj4iwtRO/+4Aa1e6BP7QiD718it+uRHQmzQ/ivCy/8bAEFZ o3xZo4RhfHOKbfvNWf11yaIKRLy62tD9p4PkaibMJ8ODYrrhG9hLAJ1c3GB9KX2s/1gz sUbdjto7Knh2cofsueZNSJYEyl17NSW99T9SbxE/1Age6v/Sl/ut3o+n/ReoJNTE3pRc RVAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724880931; x=1725485731; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7q/65fw6u/ET/AVvM+frdRKGbRF91OUqQsqzQ+d1cFw=; b=iQrF8LcnIHb9DOeW24waqYwVQhDUtj50HZfDQk9Uoa8ohqj0UdfrpPIoW2fU4TEoPE d+Yp1CoQyelVOcxAy6VcWxWn5CdsKmsvacRbMSXbJkBgPUjx0bA2l64sGfA67RPWAyVA K63sLoHejg87mN3uWPQZhy9otokTztVwLzYxabcxTiAWpLG64TPDIBrtIncnceKRn0V8 NV/ss8LjuYglmIbhXJ8Fwk316MQnGe6gGUOfbeUmxVcmkGXQEb33SahCjR8WdUMUB9ye HOzno8NPEWUpEK34fNGXchkdQW6cCvle7UAyW2kEYxQt7mBhjio/h+TYhIadyE/BAfqY Sh3g== X-Forwarded-Encrypted: i=1; AJvYcCUG/+AD66I83FQfTL3acnztRtDnMpKsHwVApV3tD+dWugNz4d/csNEFVKwYZyIQH6/w7I/9B+cotA==@kvack.org X-Gm-Message-State: AOJu0YzcgC7ar38Lyirq9mBAafzDemZC1f7njk6+2rl0MGLS/amnkaxu J72bbG14XQ9bel8Z5CCC/kVwqUvriwg+LoAzzG9F83uT/9dZTVIRXpWsXkNYArUjhdNsFQOjqw6 rfTNcBIhmPNUOOftKQxx01c+FGSk= X-Google-Smtp-Source: AGHT+IHa83Ue9OEMW6d95OAnEdp3di1gNe+feVg7h7WyOfG9xgMTtD/ropKRSryPH/4PbQ4dI4kjipeaz0lKPUQu6+0= X-Received: by 2002:a05:6214:5d0f:b0:6bf:85bb:9c2d with SMTP id 6a1803df08f44-6c33e62304fmr8697076d6.26.1724880931087; Wed, 28 Aug 2024 14:35:31 -0700 (PDT) MIME-Version: 1.0 References: <20240828093516.30228-1-kanchana.p.sridhar@intel.com> In-Reply-To: <20240828093516.30228-1-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Wed, 28 Aug 2024 14:35:20 -0700 Message-ID: Subject: Re: [PATCH v5 0/3] mm: ZSWAP swap-out of mTHP folios To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d43i9mxr8ndkfsgya3ufctc9zy85gwe3 X-Rspam-User: X-Rspamd-Queue-Id: 250EC12001C X-Rspamd-Server: rspam02 X-HE-Tag: 1724880931-82660 X-HE-Meta: U2FsdGVkX18OxXZ8W7ZrpNhzRE0i18rZgK44+jxbJEOd+3WwxyqccKNZtbfLIppsMS7tNTLqsVqEKKL3nWhOagYeiiqnnUEm4ghMrQWY+ssJ1q2qfBnvcnv6hmVTwvUrLisUNHcmVwKiOQZBauEshEO1hOpDB3xXwcl22HFhE4QItXkAIB/Ln13ONiS1hf/P088moTmrHa6pZ0mpmt04eR4ecuIgcXpw0F+BCwJMO06GZGyXN6ZIAg0Z6peJFo5c3DqMibCuw3/GnMQDa8CH7BJkkgo1RNGryV9UWiWbV62vTaitHVEFI/iABRpmD5uKW25wUs1odwqBFy1Qacm+1r+NVtrfN092grHpckRrCI9fKRa+ioiuW1hgEroijhTQGTfRXy4IkaxB5uotTsnzqE1XKWrZARaMcdCygjCxa9inIcWj1KBzjO/JbhPNyeECSMBr+fw5Jx5IZ8W2v4jyJtRwam2e0uU/OGY0vr6O7Bl+XB5foWyQC7olUYt65gEoDiOI08nLmTpmam4lW6uyC/ZQgZ0nTnBKaZr6rYW53YJ+T8FAWYV5Nvjfu/mMKauUMBvX7GhtHkgPpJXF90X5wGm43d4xyv5GyMJ4XgMom63yBXZMyzpzyEw49RDw10MUhHJVrVh/MP4qLih2I8q5wFYl6Wng1xoHH+wJPxD3dkAEAepCOTkDXIZzbqAA86E8If6Q5Ht7C3YtwJ7WL4HKGDzC7wO/mMgNIIn4bL5CY4eQQim+p8ZKjE3aCY/BTXBtnYCPMD6s8qc5wNY6o6mriO8vqsUOFqBBUYvymnIHUNDDfZ38JaQ3LqhR8ESk7Xvx9wY6VkmsXPmsP1oGYVa6eZPEs44MbaL7hIn0+4NtW4B0PQiQ4ljFydvzdeOf8VgrALJH67m7ilOj53GS27dbIJINQ4pAK5zxveaV0UD4ExcV/UGiKbxhN1SRRgTEk/IAmm24ShwLn1ij/pWJgfN u03VTsVi oBVw0C0aQ9ycTIPS0Y19WwJ4Uv7tzYX44L1fKWkkjMqw6100ibECqhcSPgbc2w57IWUUCPDZM/9JKG9zvCEMKy++eBmyMTCcpMTjCY/MJTHP/VFJ1vtGV6lNjng1CIhkNwBQ0NVAWDwlPXkqNnmNKhc6Q7Ndi9yGJArlKLH0we/PRgLHN7LAZqd325n/HEJvYHQ8qmuA7eri4ACdGuESaukoYcHVDPQJ75psdDgwv2r/TcGqJy3hBUurlLd+PtYTzt13RtPO7AOzp9V0mjEp/JK3Kl8skRqXbcNhs3zONNdOkxQ+ZfjeNYfthv3dqMLEh9uw+jp95R2KryjzK40QtDsnPAjw4RTqpub5dVYNTSVbylCJNdIp9QbcdPkW0fXCXIZ7Vzc8zabx2oMVRwkep6qbOPz72o47wf+Xn1Vv+UoQ4AHIwtv+ufizu0kRv94fWL/EHXlB2WoiZiK0RR1wMjIxtPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.292618, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 28, 2024 at 2:35=E2=80=AFAM Kanchana P Sridhar wrote: > > Hi All, > > This patch-series enables zswap_store() to accept and store mTHP > folios. The most significant contribution in this series is from the > earlier RFC submitted by Ryan Roberts [1]. Ryan's original RFC has been > migrated to v6.11-rc3 in patch 2/4 of this series. > > [1]: [RFC PATCH v1] mm: zswap: Store large folios without splitting > https://lore.kernel.org/linux-mm/20231019110543.3284654-1-ryan.rober= ts@arm.com/T/#u > > Additionally, there is an attempt to modularize some of the functionality > in zswap_store(), to make it more amenable to supporting any-order > mTHPs. For instance, the function zswap_store_entry() stores a zswap_entr= y > in the xarray. Likewise, zswap_delete_stored_offsets() can be used to > delete all offsets corresponding to a higher order folio stored in zswap. > Will this have any conflict with mTHP swap work? Especially with mTHP swap-in and zswap writeback. My understanding is from zswap's perspective, the large folio is broken apart into independent subpages, correct? What happens when we have partially written back mTHP (i.e some subpages are in zswap still, whereas others are written back to swap). Would this automatically prevent mTHP swapin?