linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	hannes@cmpxchg.org,  yosryahmed@google.com, ryan.roberts@arm.com,
	ying.huang@intel.com,  21cnbao@gmail.com,
	akpm@linux-foundation.org, nanhai.zou@intel.com,
	 wajdi.k.feghali@intel.com, vinodh.gopal@intel.com
Subject: Re: [PATCH v5 0/3] mm: ZSWAP swap-out of mTHP folios
Date: Wed, 28 Aug 2024 14:35:20 -0700	[thread overview]
Message-ID: <CAKEwX=Pqm3pjOO-ErOTGnNYKwMas4fdiN0bdUcrPHzfKf-Qryw@mail.gmail.com> (raw)
In-Reply-To: <20240828093516.30228-1-kanchana.p.sridhar@intel.com>

On Wed, Aug 28, 2024 at 2:35 AM Kanchana P Sridhar
<kanchana.p.sridhar@intel.com> wrote:
>
> Hi All,
>
> This patch-series enables zswap_store() to accept and store mTHP
> folios. The most significant contribution in this series is from the
> earlier RFC submitted by Ryan Roberts [1]. Ryan's original RFC has been
> migrated to v6.11-rc3 in patch 2/4 of this series.
>
> [1]: [RFC PATCH v1] mm: zswap: Store large folios without splitting
>      https://lore.kernel.org/linux-mm/20231019110543.3284654-1-ryan.roberts@arm.com/T/#u
>
> Additionally, there is an attempt to modularize some of the functionality
> in zswap_store(), to make it more amenable to supporting any-order
> mTHPs. For instance, the function zswap_store_entry() stores a zswap_entry
> in the xarray. Likewise, zswap_delete_stored_offsets() can be used to
> delete all offsets corresponding to a higher order folio stored in zswap.
>

Will this have any conflict with mTHP swap work? Especially with mTHP
swap-in and zswap writeback.

My understanding is from zswap's perspective, the large folio is
broken apart into independent subpages, correct? What happens when we
have partially written back mTHP (i.e some subpages are in zswap
still, whereas others are written back to swap). Would this
automatically prevent mTHP swapin?


  parent reply	other threads:[~2024-08-28 21:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  9:35 Kanchana P Sridhar
2024-08-28  9:35 ` [PATCH v5 1/3] mm: Define obj_cgroup_get() if CONFIG_MEMCG is not defined Kanchana P Sridhar
2024-08-28  9:35 ` [PATCH v5 2/3] mm: zswap: zswap_store() extended to handle mTHP folios Kanchana P Sridhar
2024-08-28  9:35 ` [PATCH v5 3/3] mm: swap: Count successful mTHP ZSWAP stores in sysfs mTHP zswpout stats Kanchana P Sridhar
2024-08-28 15:55 ` [PATCH v5 0/3] mm: ZSWAP swap-out of mTHP folios Nhat Pham
2024-08-28 17:23   ` Nhat Pham
2024-08-28 19:30     ` Sridhar, Kanchana P
2024-08-28 19:24   ` Sridhar, Kanchana P
2024-08-28 21:35 ` Nhat Pham [this message]
2024-08-29  0:06   ` Sridhar, Kanchana P
2024-08-29 17:10     ` Nhat Pham
2024-08-29 19:38       ` Sridhar, Kanchana P
2024-08-30  4:52         ` Chengming Zhou
2024-09-20  2:34           ` Sridhar, Kanchana P
2024-08-29  3:59   ` Sridhar, Kanchana P
2024-08-28 22:37 ` Yosry Ahmed
2024-08-29  0:20   ` Sridhar, Kanchana P
2024-08-29  1:01     ` Yosry Ahmed
2024-08-29  3:10       ` Sridhar, Kanchana P
2024-08-29 23:33   ` Nhat Pham
2024-08-29 23:38     ` Yosry Ahmed
2024-08-29 23:47       ` Nhat Pham
2024-08-29 23:55         ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=Pqm3pjOO-ErOTGnNYKwMas4fdiN0bdUcrPHzfKf-Qryw@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kanchana.p.sridhar@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nanhai.zou@intel.com \
    --cc=ryan.roberts@arm.com \
    --cc=vinodh.gopal@intel.com \
    --cc=wajdi.k.feghali@intel.com \
    --cc=ying.huang@intel.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox