From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D05AE69E88 for ; Mon, 2 Dec 2024 19:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA3206B0085; Mon, 2 Dec 2024 14:27:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C536F6B0088; Mon, 2 Dec 2024 14:27:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1C076B0089; Mon, 2 Dec 2024 14:27:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 94C5D6B0085 for ; Mon, 2 Dec 2024 14:27:08 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 572C91A0287 for ; Mon, 2 Dec 2024 19:27:08 +0000 (UTC) X-FDA: 82851001758.23.E681872 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 2B6E740004 for ; Mon, 2 Dec 2024 19:26:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GKemsxJF; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733167617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y82eOTEhwmMyYbOhVYXDIlIEQdK/qSD3OtDPE8tkSD0=; b=SzfotwaSpzhcthhmhiIJjRI/A+dwMkkYBW6pDdVw+Aag3P9U6C5ykxVKjqp6TsFy0ZkXW1 HQ3K8aKv7S/uY//bbFuz2gDay4iR/DJiJTDNmtqid83oC7DZmsoyHrMfAPafLlb85jqICG 5h/h8BlEBSxtyPWGzMDrLlwkY7LI8Kw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GKemsxJF; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733167617; a=rsa-sha256; cv=none; b=6Lqjm74QMGlwh5vqP+Xqx48SAC9mU7Sjta5kNj+pzgxDmdN7cXtS5KUsZh8CS8ZtYA1XHP FClBR2exGqSLnkmrpgmdrpDjFL4b231/XLqcOflI/98yzqjuOVp3Wp9btB+0ilEEJwtksM 8Xxjl08efHWj4Wu54q4dEdwWAk5lK4g= Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3ea3bf79a03so2152522b6e.2 for ; Mon, 02 Dec 2024 11:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733167625; x=1733772425; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y82eOTEhwmMyYbOhVYXDIlIEQdK/qSD3OtDPE8tkSD0=; b=GKemsxJFTERpIOS1AxQ5Xj8SF2hBDUGjOQeZ/jq085BTDLGjXR6TZ+WmK2MmLhEgBy aGIwJoOZ3dwM0Ee4VsO45PK0hAi/dRX9jGe5H17p6zgQC8BG6iyOHOj7zKCIm1F9cVmg BY8i1fLOktWyoCiisLXP4ed4DsEl8LN7yiBt68HeEmr4vGz2jW1UMkXGhx2TJ8mwGG1q Tecg7WwWJNE3M7QArUveBG50RewHPfIRgu39ga6uDbmDf8ws4Q0uFCt6SLYyAgQpaqgb 8USfALlfCAXABAvNvR3+vhKg8Kzig0IDsGwK6bYFR1/kdIlEQL1AHwrMyv72P2eRdGBJ BSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733167625; x=1733772425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y82eOTEhwmMyYbOhVYXDIlIEQdK/qSD3OtDPE8tkSD0=; b=J5Ejgptb0Sv/buv9ZGruqClOR1a8vS+SGYI0qKJm322Vs4Mozj+KkdQIZ05cHEM7V4 MuvOcuOMAJCeVk39j+Dgebsb+7qfQs+dipCxlcGAJmFwKzOa55L2qalButwpWWvRiOei VuJatMcz1HncNHG25S+KfazlmcslsjjyVMn8jbUoEQ9LfbKRlm69AcTAz/K2CrZ3D3/d 5aaaMrtZdybWlXZ0rfrmJ8C16FLaPr/BbIHYLkX7RgGPEkJDoCsTysiDPk1dPBM52UH6 ANda1i62UirpBkhgyy0yV8jmbsuJkEWx694VI/7eBUAMrNDZ1N9sUa9wDfWKxPQyjyxb nIUg== X-Forwarded-Encrypted: i=1; AJvYcCUM+NfQeJCz9DhkoWpLpeo886n+bJLrLMxa14TqSAwHKEowXiPStLte7Nl7Y7wR6CkPLlqeC4DMkw==@kvack.org X-Gm-Message-State: AOJu0Yy/21KMy4/BdqtE7xK2i3k4/GDjJzcIX5arlmUZG6c/Pxb+5zNH bQFMgi6fJZcsRk4ZWD9jZj1be9H616T+6wWAxLd9BIJGcsSB65m3K/wdilN38v2aQkIDszJqpgw EQvi2V1VGmV35W8HwjBO687/6O2c= X-Gm-Gg: ASbGncuiUpDYULpb5lk/M3QcYuhmqt05FdkiCMPgq9QZtGR3n5lp0kWQxywkv6l4cTT JKhWZ9LqV5Te3ZmYMr/LgQ1DUXeYWKM1KWrfk08+eAd6OxRY= X-Google-Smtp-Source: AGHT+IEb0q1YzKrjqBN/l+hzvKaqv8aySTKWK83ko71V+ahoVrlVcAzoq3EPKEzVSgFNb+PZs+zg/F0X2N6fm47Wu4o= X-Received: by 2002:a05:6808:14c7:b0:3e6:5792:2fb1 with SMTP id 5614622812f47-3ea6dbb4b11mr19902682b6e.10.1733167625419; Mon, 02 Dec 2024 11:27:05 -0800 (PST) MIME-Version: 1.0 References: <20241123070127.332773-1-kanchana.p.sridhar@intel.com> <20241123070127.332773-11-kanchana.p.sridhar@intel.com> In-Reply-To: From: Nhat Pham Date: Mon, 2 Dec 2024 11:26:54 -0800 Message-ID: Subject: Re: [PATCH v4 10/10] mm: zswap: Compress batching with Intel IAA in zswap_batch_store() of large folios. To: "Sridhar, Kanchana P" Cc: Yosry Ahmed , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2B6E740004 X-Rspamd-Server: rspam12 X-Stat-Signature: m3f4sxh6ytzwebpysai5aymes1nn1sci X-Rspam-User: X-HE-Tag: 1733167616-310654 X-HE-Meta: U2FsdGVkX19rncDbAJjRJBA+PYgU7MwLwCz3XcI7CXezqtenmFtQmuyQt71Z0sOo6oD4TbKtnbfwS3C5TbwQPLIQM22+dOw/W1IjnNTZJbiKi/VVdXg7xHp07JD0DWjHTYUSrA2mnUkxnxtJXtNllXfAIt6YuTQLGZbFNT+fJdq0e+aMpRziZWO96q6gX5gpYcOix2POtSWVrpHV6E9SXaefb/rfXO17H8hqNKNTGvkYq/08CQkibo4B0avXbVsa1tOqYyNnUOQ5YDgSc+69ntm+R/NmyUSuNtHW5DxiHuEgklYr7fj8i4CV++wDO8G2tITl0MxCxxCnRaBgbuL484tDqvV++CCqGP2INurVS6Z9msFbqN0n5Wg3/vY9QyvU+Z12dmWKQgtWP1/msRQkMtDKjoWUQcl1wUukPF6lhi+hgV9tq3s5zGinyZFnZEPE7YfMcEK3PsnyMaKfMbRb9uhOWd2gQYD7uOSVGxDN/GlFZmlEUpQ39SGRbwJsBs92gTx3ga8gPbE0eZ0kzcqjupAnCu0rzfRQRPipUhEoUejZ6s/+YykaDvq+vF1VZwZDAzdeCeyHqqww5oiTyxu2kgi9zQ6bLAR8NnPg+fH0l+1uVFPqwYx8lQ/xDgq/oRb2Ok5TrqORq0PVvlkWL+GGLoluJAhkPbcJOW2VYFxEnN6kbZicfvK87MpeoWGRh8EcS55cmT81zybt4ZW/ZtBGNqfU5PYwJBcElkTAmSGPSFdPuNucYoI9gLiazC7TL7L3FpjRVD1ou0sqNjXhnJJpcS81c+KeLn3RW9Zxg9TFbJ03qEpx078Ho691xjiHsUj3GroqTZqlgTITbiWbmMqkfF4QfKktgJxnjQcmwJDDHo24U2T7lJVXm/kmMHS01UUGvVqAyXXkmLCuDXOnlIwinQGL6T8FDwiD6zzsf7bFHC04E1TIyU8YhoXQGJMzlOmRSYS7OSHnRLemseiUiYF byjbxx/n LrXygVK0Qmplv+fWcnThfWgtVqGhuARL49pGdTDs+C/DFS8Csy2YKXucY7sforV4JoQsMgrfiIdurP+NRcDu2fo8BtxT6Ga82Cn1koP+dXuwHn2n3H6iu0ykLdNZOteT/zIS3ifzgTiOI2Yv0jh5hTao69xUXd7zF26mo/RNm2HWu33z/DpQ4l4JY4dfmCSdtplpr6K9arXGmsYK559hJcESbfG+Q0eQvoJX4VqxNYXV4zwR0GVIe6SdfdldjuenrKk1oZdK7HOaGTJsXJY8WZAF+fRHzfwRq5YaEjUI+aBE/4PmlldVmykIGGupXuqGYC5jzaaJRWhU9jjhXm9aBs4xBZz+eFu07uvdMLzK4/JxzPsLX8TOzq7zAGBN5lllthJNVXkj0iG0u1AlS3grg2thMOGP0+ccE6cow1iv50fQOPDDvlZoR9TDpng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.102696, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 25, 2024 at 1:54=E2=80=AFPM Sridhar, Kanchana P wrote: > > There are some minimal "future-proofing" details such as: I don't think they're minimal :) > > 1) The folio_batch: This is the most contentious, I believe, because it > is aimed toward evolving the zswap_batch_store() interface for > reclaim batching, while allowing the folio-error association for the > partial benefits provided by (2). As mentioned earlier, I can delete= this > in the next rev if the maintainers feel strongly about this. Let's delete it, and focus on the low hanging fruit (large folio zswap stor= ing). > 2) int* error signature: benefit can be realized today due to the latency > optimization it enables from detecting errors early, localized cleanu= p, > preventing unwinding state. That said, the same benefits can be reali= zed > without making it a part of the interface. This can be done in a separate patch/follow up. It's not related to this wo= rk :)