From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FD9CEB2E2 for ; Wed, 2 Oct 2024 18:15:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 306F84401C6; Wed, 2 Oct 2024 14:15:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28ED84401B5; Wed, 2 Oct 2024 14:15:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130064401C6; Wed, 2 Oct 2024 14:15:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D910E4401B5 for ; Wed, 2 Oct 2024 14:15:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6E6CA120ECF for ; Wed, 2 Oct 2024 18:15:29 +0000 (UTC) X-FDA: 82629464778.22.1BD6066 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf17.hostedemail.com (Postfix) with ESMTP id A4C414001A for ; Wed, 2 Oct 2024 18:15:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lWvfsnnJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727892823; a=rsa-sha256; cv=none; b=3IGdKEdK5iO7QTLlticwhf1jmTAiMNmpwTyJKFtXslTeU2Wdm+CB0AAsO2C7eD0BYc8xag SWk4NVkpi5ybY9+1+OFm7UTNDuHCd8Iron3zofcsweLPOdx0JpuiDEjwGJ4+vhcQo73Fx2 pDYVJursfz2i4QfgrarM0ajo90bC424= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lWvfsnnJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727892823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e0fyARs/4Kq4tRLYk98LzCB/bx2clpzerKhb/tultS4=; b=IxA8DntN+VixikBsT9K0SvCaE9Ih9fDRkOvW2TMKJTYtAtuMvH3qCp731DeWw7o50mVjHF Bbsgwt7oQ+k8VMvNCHRF6ScFSivLA1yOuMPMNnlJis7X8M3a1wU4ctThKXW+YRq/kUTOR4 B17kg9YFc4aqw94zDt7ny6qqhjRq0Eg= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6cb22e9c6dbso953226d6.1 for ; Wed, 02 Oct 2024 11:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727892926; x=1728497726; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e0fyARs/4Kq4tRLYk98LzCB/bx2clpzerKhb/tultS4=; b=lWvfsnnJ594Lz8iOSbAXR5otpKk8jbZLBYdITUvSdks8/+oMXS/77aMtNLtQoyK8iI tPNbUe2ld06EozKZsY0nbh6DfmPEGX1XRoyO6aEZSCXSwEXX5CC6LK8drcX+11QwmXrU pZ5i8epnhvy3JrtWmmancacoaKrhqBnymAV9GsfY4b8fiQkWfUkvg8MCsn/rblBX6Lat WfFRvRvwVshUTe8rpI+AIaL4oI2uEVKGjmUzB4UPjVvXEHADe/rTzuh1R6Pbe4HKVLp6 L1O29TbCripbye79ndfsk7PlfihTiFg53XdrRZ0tVcUcaGakn71x2xGn1RxptgRrd4Bn ZVUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727892927; x=1728497727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0fyARs/4Kq4tRLYk98LzCB/bx2clpzerKhb/tultS4=; b=ZkzddPoM+BlzFuJsTr7oBlWsPgM/wqd1WjuYcbqV7tx1AI2kVoi6x1SY2uyrcgFt2q OzjOGXiJwnfuhnC3OYy9F6yl40/kD7hZGr5WbOOrQC2t0enskfqTQAFoOpifOxUMqogm Dh6wGIUgzPEoNCtmf3sPwT03Dt4LYxwMwLpwpgReyjIb7+iT0C67hbOPRxnCYBUYclkR wcnj2mJS68hjgVyk+tbmbgPwRRI2f1ODwSAmuaiCNZ7ZCvqiu+R4VW1fv38Q44Vm54LC zU2juBlXxT1BrEiYzkkeELD4KM8HXvRH8zaxmdfRtaEf4aiaXncPCKY/3r3okjhOKqt1 RA+A== X-Forwarded-Encrypted: i=1; AJvYcCWul2eCi268LhNkW1qmLesefSFDaUXZyRDXlCH+QuTAx+vWK6bpu8cmS25EINGcqu0nSZVX5Q6ssw==@kvack.org X-Gm-Message-State: AOJu0Yw58V/nZ8qbU49ATWAaTHhHgX1JOP9BD+NIYvoWZabwXfFEF1bA xC92lpR/PmLWt4xSS9Mwi9qvxPS+d+pqTIPFyvnc3dDa1zRH45LD/mHBYHp/PCJqVIavATlHgxS 5QoNElMC/yn4jIGwJu7AGkLlR1ww= X-Google-Smtp-Source: AGHT+IFSX+G1CPSRU6CfM5KimHuX/c/E8fWB7jVm7GcCkakHWyYzWlcCWDBrGbsmuwMtIh8Oj3bfxMXIvLPmO62wJqw= X-Received: by 2002:a05:6214:2f13:b0:6c7:c283:7ce with SMTP id 6a1803df08f44-6cb819b2cf5mr60800656d6.3.1727892926522; Wed, 02 Oct 2024 11:15:26 -0700 (PDT) MIME-Version: 1.0 References: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> In-Reply-To: <20241002173208.213631-1-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Wed, 2 Oct 2024 11:15:15 -0700 Message-ID: Subject: Re: [PATCH v1] mm: zswap: Delete comments for "value" member of 'struct zswap_entry'. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A4C414001A X-Stat-Signature: ophidco5yseddgmoeamzmb54gsx1m1ya X-Rspam-User: X-HE-Tag: 1727892927-645862 X-HE-Meta: U2FsdGVkX18/qOMAEaYJ+Z1FA7myC5ls8ScepyvtsOQuy6YJbmb9xyl8XH795EhSwAHu00lbtPKMFRjR7UrDovBcThUC497BC7dKxKoBVQLhFOMi7+9d4c/Fe0qNWKTI4uJ96X5iqQuPPMgsSObIWFa9Dcd6+0UL/WUTGcplbemiYD16S+HHSgkYXQ5cNPjMm1wvEzkJSBrNdQRAj2vM+cq90R/1obXU3t0XC6vZsTymBWa+YmH83htkmhkXd+a3q7EBt1zO3vZ4Oll4yijuwnb1G3UOw2Xxq6DgcCWcT+ENRVsaRdl0jtBsKJ2qhZqhjMprS5GY4dUYLxbHyC3KqPNWhX+bcE6TGI4tMbLjS+0BdRyWWtArVKt2ne9NhcCtEoyG+UGTQ7Gz21k7wzbBuh5wMDC1fMIx87B52qSlir9zv58nCCLesq/ikvUvU5akFAadGlTbMVYlGK4KRUVOW0W3i29P1wSABoaNeLs9TsEBCxeqs6xFw8udEuoaFX533LiU67Ifgwtmrfu+PKfdvIz9SYjIsag9Whr1ujLGxIdbYnZVgH4ud+zxTzsd9xFAqAZIfixXmrrBmaO0O5VdCd8RUMgg5n29wE/mFbWsInDwQzDJC57jD1ahUj8nUug7nvHqy2+gU59CK9mMN6AcLfl9umQqFsZq20lWMDRbLzYwIxbaeW9fFL97dq4vPowSyMSQe3A1PsxnNGzl1CBtajjAfFNk5PnPJQ9qO8DYR8+gbBZvLUZhyh6A+g2mbm0u8LobLXL/2t5lqCLvMGpjs7182luKnOs8o9tHKDhgcWHPnB+igAmwPYssRarzf7CfPpUvPgyCVPC6C/8n9XQLG0g178gL9jfrLbK9+jLoQExM2ZjwocDuKrj6al/7rV1OwbMsQFtYfjCQBfOju3/YZFsWZkLNxZ+JCXV6pjTULagQDT6Jn8HTztN2OyQhUgs3esdTEaCzOvgKV1eW/Hj VP4oGhgy QNIQqQA/ZJC8LyAnUgusJ03gaY+0cH2KJaQ18WgB5lvXMs6kvN5dGYsrQTYkxu/fJpDnGF8hnN4ZqdxVtIg/db+7Hff2e7knoVZPbx660RKXfq+hlxmXZ11oOn+yKytHsxD8FYSh27C51Q1NmZnbENg/JvuM0aqimV8vgw24MHesp+oeuZkxRWAKGA+u24u8JIVRGHFa8soKrJbW2ipk3MupndTNyAAPxfuDYdGgu4Wb8Zu63q5p+yZUWUGY47Vb9DJpE9ryNDnlDHcCqQra7TY12rZgwTw5qNkdmSUWuUvD9adRCp9gye2qm8UU66z2mq9dbjY2PGt8130L+DIKmRaMTnbi0obZ7K/vA5DAfBwKMCe/ArzbObN4+dzLX22onuFS5jgryTKfuJLtfP8jUUCNw14N5PSp9sWGV X-Bogosity: Ham, tests=bogofilter, spamicity=0.041950, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 2, 2024 at 10:32=E2=80=AFAM Kanchana P Sridhar wrote: > > Made a minor edit in the comments for 'struct zswap_entry' to delete > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). Is it worth adding a Fixes tag for this? FWIW, it's really just a documentation correction, not an actual bug fix. But it's a "fix" nevertheless... > > Signed-off-by: Kanchana P Sridhar > --- > mm/zswap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 09aaf70f95c6..c3e257904b36 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -190,7 +190,6 @@ static struct shrinker *zswap_shrinker; > * section for context. > * pool - the zswap_pool the entry's data is in > * handle - zpool allocation handle that stores the compressed page data > - * value - value of the same-value filled pages which have same content > * objcg - the obj_cgroup that the compressed memory is charged to > * lru - handle to the pool's lru used to evict pages. > */ Thanks Kanchana! Reviewed-by: Nhat Pham