From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DF7C4167B for ; Mon, 27 Nov 2023 23:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB5F96B01FF; Mon, 27 Nov 2023 18:41:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A65C66B0203; Mon, 27 Nov 2023 18:41:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92E4A6B0207; Mon, 27 Nov 2023 18:41:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83BE06B01FF for ; Mon, 27 Nov 2023 18:41:11 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 53E5016011C for ; Mon, 27 Nov 2023 23:41:11 +0000 (UTC) X-FDA: 81505357542.06.EF3F552 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 81E9F100444 for ; Mon, 27 Nov 2023 23:41:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=atOhscoi; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701128469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xt4Rz3NPL3GmvcZqUaAKQKsdcESneE9uQ1F4mASw2qo=; b=YbgQkPA1Jk8HVyi/twc0PVuIZ/xiRsUmKe9dmZucBZV0mDjD9x0TuQAS4xWErDpqXKiBwy HMcFHkcUDp8oS10Z/eJF222+ex5itSI4BOATZn6h9tEuDMjUINQkNJdfm+QJjGrv+LN9ez xzLu78BgXpFmRIHtyrLooItj9XL6PaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701128469; a=rsa-sha256; cv=none; b=u4edrTMUA/oT/kafZZBXbwYBUuuUsOl/NgC5IECcyxz56g3DKTsCC16wusIky17CzO3/bZ QiBydfVM9XU7wkxdhgJ2q477hKfpiOn9kfZE71AJ5ZR3J3vBoc2IMtsNPitKG+fg9VM6c9 XTbzHzyOYjDUwWRvnlgtUCdpVas3Asg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=atOhscoi; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7ad501cb1f9so167102539f.0 for ; Mon, 27 Nov 2023 15:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701128468; x=1701733268; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xt4Rz3NPL3GmvcZqUaAKQKsdcESneE9uQ1F4mASw2qo=; b=atOhscoiITNc7nbTG80CzaGXOe3IBN1zaRbvAhDHHBrMzZqGvqmCj73azZdXQcN2zO m4LP708GHrmozmZbtxnuqiv+0APhI7ZyGI49XZ5CCQIcU8Nx53jYmoGR0D4fGvKux8h1 7Q/4wC8cRboJ2bJ8/+nOvgBUWLG0KFc0EYc1/AV7URZYxaOG+o/sGvhN+OXKI6PTSQre PRR58eX2ly9UAKe526lolsbz4wlmgfw3hOlRal/s0K77QU5DwPsn41OH1jX6Bj0d4AYy EbxySZL7DPJya2eQYpu5RHyBYcHHZC0esh7rbXbhi3he7O5u44UuoDtKQdIW3nVtDF1g Rlbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701128468; x=1701733268; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xt4Rz3NPL3GmvcZqUaAKQKsdcESneE9uQ1F4mASw2qo=; b=MZJBOW9qe6ZXBR69SSHnI1lFAAVzewMuyDzPvtyHHcok5LMvo8C54IbAfzK5QRAG9u ah7CFOpP51eFvrrygvWwyX6mzsNFp9mNz8TS4vngHf9TI5vgNWsAh98ZqxW3zgQHkbQs whb5grVlxv83Ny8Yz4kCDj0LK8/yBtV43KkZKNB5fngjkc/Gu179UeGcfG2ZfRiV0mjr NZqJ8FM5FvPnYwag2tQGadEv5XqmvaK4lV3xQPsMikPq1r4lEa02l1NTmj1RMlwSaNLZ 08GIeqUt29RJFl0kEzbv+sx4Q7d4Pu3AEDFO+iOE6fkS2bGroKpYJbfK6+vZ0OVyMwi6 Vd/w== X-Gm-Message-State: AOJu0Yy70xNdlUg8zu9/SuQL77dECxa4kaBsauPHUEKyVzjrCRhEd6cX E/sTAkoMTvtyU2/ROWi7dn7qZLu7Sdt4+Yer72o= X-Google-Smtp-Source: AGHT+IEg/3ClM23o+b0ka8s38xu6Doj3ui9yCzCVjzWnNRlLwByq1TDlrBx4oyoXY6Ye97ho8aQwWUSgOOUdbQNkbqc= X-Received: by 2002:a05:6602:4904:b0:795:183b:1e3 with SMTP id ef4-20020a056602490400b00795183b01e3mr14365005iob.6.1701128468627; Mon, 27 Nov 2023 15:41:08 -0800 (PST) MIME-Version: 1.0 References: <20231127193703.1980089-2-nphamcs@gmail.com> <20231127224650.2636224-1-nphamcs@gmail.com> In-Reply-To: <20231127224650.2636224-1-nphamcs@gmail.com> From: Nhat Pham Date: Mon, 27 Nov 2023 15:40:57 -0800 Message-ID: Subject: Re: [PATCH v6 1/6] list_lru: allows explicit memcg and NUMA node selection (fix) To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 81E9F100444 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1yr65yr131rkteewsg6kf3mmshhc1f1m X-HE-Tag: 1701128469-909965 X-HE-Meta: U2FsdGVkX198mmjBk9poP+E+lDOIhrel43FdkJKYNTQqKOmlq5ZN8X7S2AYFFKJGvk1m44RwO6Ap1hOW47UAMuhboBRVmrRy7NO75pTI/Wlgynsw6KukXPRCMdOo4MVKCEVkptkUVwP+dcdMHeo8PAo+5LTxU9PtEivTEnnU4v+Kb/2q7wSKwLjrX5H8h6nC75gqfzz0ob/3FVaFDsVe/TotbRallJnsdZ/5tGJnR1jPJkA+u+NrndhiJ265kg9dFVVKytgM8VWLxheI9vEpXzCXBXlf0k1ZKOOVN4beNl9IQmsZ/F9I31WZEdlOg07IwRwx9h0YUND/H9Xx3Smg77Dzakt98N0O69SXJesdhfpyBQzABvkaDsFGfBeIM0Tadk9UE7qE3ebECkSNqlkOc+Cv95dJXnsgOjL2Ve3xJhfHVkZO/5vrAjQQ7Wvqnya3Sbr08K5la0rZ3zLIk88Sj/wr8k3MEkHfatJFsD74Q+RlpjrJ5h1bfmuqge2MbFfegylGtKan3Xd39FnZq3Naj+bbEa6tkFy7pjqEBIkjdx9xgV8nC+Zxsn7+zY6GTWpuZ9u9ywzVG+Vnz0CxKm9MlRn/06BTjzJomiJv1ichpNqX/jk+C42+9XEpbNYEbGFx2pmCUgj1HztchTZLyY0CTM3KVbUEHObB1TVhaPUWaObdQ2PV6FjUPgHIwjqJZN5QEaPWdR6Xa0rY+zBufNPuNBAxzq/1KIT8KY9a9hp9fWbzmcxMK4D0cpWmCV17S+6K5FUWuM6h92GW6RZ7iSy0KvqTPYuuawBDxDQ5qAnmJElEgT8pIihd3A7LhZsYTE62qZN+hHeho0qPchtb5f4ro2OKg9WKiC7QHXjCD8f1bEUah9vutki0FjSTtu3lNkB1T5xnP53U0WMMqihIoraChpeyHoBXvDeNj+icW4XkKis3z8x5q4Fl+2eaU7mLL3D873fKadr3310y4p2h3O/ C0loIN/D RIDWRauESC+bFAnLShdiIk2rpWg5X7FPyQNHj0skPGrLzj34i1E5w3Q9xnx0XDI5NmMOAcMTIOIe6q5oOHsllKZDHfmODTeidgki1fyHpPs054MPyVXTuXW7JE+VOw0qJYI6jsY+70I9s/Yz1l+rCEeyzhzWFPxTHEkJKiykLPBhFU7dRihUCuD46qUgHA2WrE8izE/+vo8vkeAlxSpqKalgh/t8qb+PgvTcZoPFU/I7bKDcPlZAMAMr0KrwUQ26StfaOKjL3A1foXSllqBF3P4EAXaoLi9U/shAXRK8vEvciHOQxuH74J8PBoql36JvTL9vibnIJxE2woGOiSmdBmK8FRpFcvR5uJTQZqaq1R1q7C3oaNkzgnJ7/rJSdV7/f6XAAsGm5BEixXknNh8m49PXhKul6a6cJD7ph45pjY4rIFK265fwBBQKei1Kr3/58fkT2RDnXcPwwnTYXbCX0n9xWUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.054315, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Actually, please ignore this fixlet. I will send a v7 instead to prevent further confusion. On Mon, Nov 27, 2023 at 2:46=E2=80=AFPM Nhat Pham wrote= : > > The original patch missed a list_lru_del() -> list_lru_del_obj() > conversion. This patch fixed that. > > Signed-off-by: Nhat Pham > --- > drivers/android/binder_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_allo= c.c > index e80669d4e037..f69d30c9f50f 100644 > --- a/drivers/android/binder_alloc.c > +++ b/drivers/android/binder_alloc.c > @@ -234,7 +234,7 @@ static int binder_update_page_range(struct binder_all= oc *alloc, int allocate, > if (page->page_ptr) { > trace_binder_alloc_lru_start(alloc, index); > > - on_lru =3D list_lru_del(&binder_alloc_lru, &page-= >lru); > + on_lru =3D list_lru_del_obj(&binder_alloc_lru, &p= age->lru); > WARN_ON(!on_lru); > > trace_binder_alloc_lru_end(alloc, index); > -- > 2.34.1