From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com,
yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeelb@google.com,
muchun.song@linux.dev, chrisl@kernel.org, linux-mm@kvack.org,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v6 1/6] list_lru: allows explicit memcg and NUMA node selection (fix)
Date: Mon, 27 Nov 2023 15:40:57 -0800 [thread overview]
Message-ID: <CAKEwX=Pi4xMmZB2S-vrYDWdPvofGKF_Y+U80Vs__p9Hd57-A6Q@mail.gmail.com> (raw)
In-Reply-To: <20231127224650.2636224-1-nphamcs@gmail.com>
Actually, please ignore this fixlet. I will send a v7 instead to
prevent further confusion.
On Mon, Nov 27, 2023 at 2:46 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> The original patch missed a list_lru_del() -> list_lru_del_obj()
> conversion. This patch fixed that.
>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> drivers/android/binder_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index e80669d4e037..f69d30c9f50f 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -234,7 +234,7 @@ static int binder_update_page_range(struct binder_alloc *alloc, int allocate,
> if (page->page_ptr) {
> trace_binder_alloc_lru_start(alloc, index);
>
> - on_lru = list_lru_del(&binder_alloc_lru, &page->lru);
> + on_lru = list_lru_del_obj(&binder_alloc_lru, &page->lru);
> WARN_ON(!on_lru);
>
> trace_binder_alloc_lru_end(alloc, index);
> --
> 2.34.1
next prev parent reply other threads:[~2023-11-27 23:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 19:36 [PATCH v6 0/6] workload-specific and memory pressure-driven zswap writeback Nhat Pham
2023-11-27 19:36 ` [PATCH v6 1/6] list_lru: allows explicit memcg and NUMA node selection Nhat Pham
2023-11-27 22:46 ` [PATCH v6 1/6] list_lru: allows explicit memcg and NUMA node selection (fix) Nhat Pham
2023-11-27 23:40 ` Nhat Pham [this message]
2023-11-27 19:36 ` [PATCH v6 2/6] memcontrol: allows mem_cgroup_iter() to check for onlineness Nhat Pham
2023-11-27 21:42 ` Andrew Morton
2023-11-27 22:34 ` Nhat Pham
2023-11-28 9:38 ` Michal Hocko
2023-11-28 16:53 ` Nhat Pham
2023-11-28 16:58 ` Nhat Pham
2023-11-29 9:18 ` Michal Hocko
2023-11-30 0:47 ` Nhat Pham
2023-11-27 19:37 ` [PATCH v6 3/6] zswap: make shrinking memcg-aware Nhat Pham
2023-11-27 19:37 ` [PATCH v6 4/6] mm: memcg: add per-memcg zswap writeback stat Nhat Pham
2023-11-27 19:37 ` [PATCH v6 5/6] selftests: cgroup: update per-memcg zswap writeback selftest Nhat Pham
2023-11-27 19:37 ` [PATCH v6 6/6] zswap: shrinks zswap pool based on memory pressure Nhat Pham
2023-11-27 21:00 ` Andrew Morton
2023-11-28 23:04 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=Pi4xMmZB2S-vrYDWdPvofGKF_Y+U80Vs__p9Hd57-A6Q@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox