From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4A5C4167B for ; Thu, 30 Nov 2023 19:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 327088D004E; Thu, 30 Nov 2023 14:46:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D68D8D0001; Thu, 30 Nov 2023 14:46:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 177D88D004E; Thu, 30 Nov 2023 14:46:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 07C788D0001 for ; Thu, 30 Nov 2023 14:46:42 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DE17A1C025D for ; Thu, 30 Nov 2023 19:46:41 +0000 (UTC) X-FDA: 81515653002.01.8B83499 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf12.hostedemail.com (Postfix) with ESMTP id 1CDCE40003 for ; Thu, 30 Nov 2023 19:46:39 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LhpkrXft; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701373600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9rufcR4lX+RrlOWOmJM9CdkzmFM5TZdyS+jKScEzDUI=; b=pFiv0Xd9RpCoNCBpEXqKC9xuM+BJbU3lnx8hPbfOOETxmTVNB34a8PhN1uSc0D+JKoe1Cw 6kVKRJXvYnm7YHg8TGfUi6I0YAZy57luD4Y8GHPCsdnEFxmwGCon5/kJdVV8xDKkWeEB9C NvciKYyRt93rFyWgp5qSmMwwoVvnUfM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LhpkrXft; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701373600; a=rsa-sha256; cv=none; b=3g1WERaHrwQhL/oQ2cxBUnD/6JE6hnHePoBQjJCvsAidb28Pd721UpVlTRGQ917S2jhVU6 MZBCBvdhuIKh0h2j6cF3+lXxaR4BzCltpGuL11XqZKXmVn5/LPG4vX4eEcR8d8T97xaMfO u3NXnSgONEqL8yRYxRrQBZ9oocB6D/4= Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7b373d61694so38510939f.2 for ; Thu, 30 Nov 2023 11:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701373599; x=1701978399; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9rufcR4lX+RrlOWOmJM9CdkzmFM5TZdyS+jKScEzDUI=; b=LhpkrXft+a5a0SOXVTzLBAeOgNL8Vluutee5gKtPE7jCcH8TDXnZQknjCw6NGGxIaL vT2pSPKLGKmq3dZmgBw4ZjNlFqTHBRN8vB6dj/vZxA848vHQZMygefoPrkpEMGb3u6P5 hFWNb6cD7ozjyRDDyzQX2N/s9Op5qLC/T+EnXOGSvVYkg6r1O8v1/uyot9xFvMM8zQo0 YXVsV9JIej73qsIJ/6+6owGZfxIIZqB4LWlgnCDsU3kZ8XF7SdGqIvPNwETXxOIhJCue chP89lM5P+rBJQu5tqpKHc0AKQntz2WE22oLt4m2J6oyF4rR1RRY7qTJ+2BFzZSGY3d6 gZow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701373599; x=1701978399; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9rufcR4lX+RrlOWOmJM9CdkzmFM5TZdyS+jKScEzDUI=; b=nXeSC5ngFzk0GFzP45vdRVnoU8GMb1i79TAF4efZiEXTW3fQbbIqqPE1kLcZP01caA fKNeiV6PNq+9KdYjvc4gXI/G/FQCM1H7iFujFoMsKer7XOxi5XQBV/akVW6Un0k84fgN qIYWjHTg8XL1uZZ1dgl7uNEzqxQhdlrwOmjSeNUnAbAjAlhRvKOtuBa8Zv+4f47e7XNF s8jg+TVjFuPFsd4kL5Yim7EDezJvKoRomjQRrcBmjzuWOlTEpezGbywVCLMUXcn7My8R JyWQKSrYdjR6ppC2i3I/+oFVE8bn72AXoH19YZKu+Tg2TwPPM5MbACFMCtfkn3vK33YO Br6g== X-Gm-Message-State: AOJu0YzCiRSF8+qfVOKN+/6p0aM+7iKIr6uw35vVMtmuBCRuwn+YqLiN 8wrrLu7EQu9R64A+jZ+tRQWhJiZLfdXwT03tHes= X-Google-Smtp-Source: AGHT+IHIBObiFw8rrVdvdA4iKUTr2wPZcnBTXQGRu58bspBp+ehLKMRKF274kg8dWwRwtDY8B7MH14X/iJ3nN3Di2bU= X-Received: by 2002:a05:6602:3705:b0:7b3:9597:fab1 with SMTP id bh5-20020a056602370500b007b39597fab1mr20488639iob.20.1701373599166; Thu, 30 Nov 2023 11:46:39 -0800 (PST) MIME-Version: 1.0 References: <202311292250.RUfWGNgx-lkp@intel.com> <20231129134313.656e76c2e3fec1361007633b@linux-foundation.org> <20231129135342.5697165df1adfff04c749082@linux-foundation.org> <20231129142935.d9c76a2fe35efd9a4c7b4087@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Thu, 30 Nov 2023 11:46:28 -0800 Message-ID: Subject: Re: [akpm-mm:mm-unstable 179/192] mm/zswap.c:825:17: error: dereferencing pointer to incomplete type 'struct mem_cgroup' To: Yosry Ahmed Cc: Andrew Morton , kernel test robot , Domenico Cerasuolo , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1CDCE40003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6zhcc5yhzd1pshryet77dyfu7ndhtjju X-HE-Tag: 1701373599-254825 X-HE-Meta: U2FsdGVkX18uKrM+Yl/bho6D58IalcpNYScEsNjIZdQAcCQYUyNkS21Y6EOF45wHiqvso/z5SYvITMsoyWD7RMDJ9GU+hwYvzepbol0TuATS1sEQVFD3NdR4gU7tdACK+zHFm50QQWTg9vWocVcPEKIdfn1IzUcG8Y9zKqhQTs71jdK4ZQk4i2+gIdw8RMXUFcjM3PIzOlWHtI2iSqNoHd/YkHKDah3VWDmf6Hp3QjuIo52b4N4f16kRQTLbVWlUJr1TtP2d3IFtCFzAYiasRQJSDjSH8cW84Jp1WR9+34V/mg/CUfzageAmVfIl4AVzSP9ApUAwlwMFId+Dt4fPTzyTii4Qewt8OJ1c7yFAZyqJbFlYXxmAOh8LLpFhs4znO1glVhUaDDEiXvqHnc0Mm7OW0JrrNjZ1d6lTaVGiPKSrbhRJNxVfjptcUONiKn1RJtOe3OYNQUF0kyHAE8ccceYvycrYBfEX3V8+xupRKY6s8wcElYNcZHJHxxbKQI9R4twfvb09+ku3xXIGnmCLmSQBRDfRFapnh4Y5EgqusM3xtm/ZyEmUKXmJwi/7O+L9EDTQV+YVa8IaWnTtSz8Vji+QA2lgxfvnA8KeUJajKLC/FJ08X0TUDLlCAHwzev/7yJCJxCVlBgnM6sDjM7M0fSf9UzVT6JrXFmpfOYkuXgcHZ5CwpRf8jvVNFoHmJ1FYwuKxVtzrPilQxOReCD5e97pW0jz8avEA3434e2CN5UMqxJWNkPGYj6mHi1RuJ4j/QRj5VeD4dKX13fme7XY5yocCylIHb1E3p6LWLMb8OblhA3FEX6ZQRNInCntXhC2iLyaaUasShDJBNtZczQt3lmcizhVXZ3CzIdxQFruvWcDCFkbCt0lGCbTIfKUUCowaCH7PN1uYQChZkYvLz7R3iQyC7wO04q/7w8jCf2c9Z4ZXayZ1myvwTr87j9GlToqXwSJzNzHP2NqnkCOuVlT 8spRUTQy +cJQaIyCtObcOulJRn4uvS21ifZDSxEYRNBjyySk5E6LWtedeq9ZYFMPjTm+olrURbGTvirq1mkxgxcgasRamyVyTYphMYmnTfOWCST0eH70JBUZmpQXFzJnO8dw1azZcBEwcU+Vbk/FcNeQ7m9jn8nGzMytN4DbllPvMQOTWuVgM/jCRmvPbRkmWe/6EEC3gANNSL876zXXEDghIaPvJ+BRg4hVGNxoj9h2tAO6+xHibkm0Z68SbMib0HbHnqlGB2K0cAsAcBSPoDT+qcbFumYsyTMOa6BzZJi2jh/UkdrS4S5at4j3ai2i2/lBd2aU2G6THvyajzCyMvAbJDP+AkrpigEi90E4vCaiK4WZ9mCItLNrGjnkfqNvSjPk/a/ekAHS9kyFL0z+bFjkiIyfkYn5nDBryKLeLr1GGQQC7bl3bfGdEr+/YK+5JGgqtLUp/+D8Th/XoClCMZQoLEUJS0EfbiguD286G2jrnKAw/g2lzUbM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000349, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ok I just sent out v8. I've tried to build the kernel with 4 combinations of CONFIG_ZSWAP and CONFIG_MEMCG - hopefully there is no further build error. On Wed, Nov 29, 2023 at 4:18=E2=80=AFPM Nhat Pham wrote= : > > On Wed, Nov 29, 2023 at 4:13=E2=80=AFPM Yosry Ahmed wrote: > > > > On Wed, Nov 29, 2023 at 4:02=E2=80=AFPM Nhat Pham w= rote: > > > > > > On Wed, Nov 29, 2023 at 2:31=E2=80=AFPM Yosry Ahmed wrote: > > > > > > > > On Wed, Nov 29, 2023 at 2:29=E2=80=AFPM Andrew Morton wrote: > > > > > > > > > > On Wed, 29 Nov 2023 14:18:15 -0800 Yosry Ahmed wrote: > > > > > > > > > > > On Wed, Nov 29, 2023 at 1:53=E2=80=AFPM Andrew Morton wrote: > > > > > > > > > > > > > > On Wed, 29 Nov 2023 13:43:13 -0800 Andrew Morton wrote: > > > > > > > > > > > > > > > On Wed, 29 Nov 2023 23:42:11 +0800 kernel test robot wrote: > > > > > > > > > > > > > > > > > >> mm/zswap.c:825:17: error: dereferencing pointer to inc= omplete type 'struct mem_cgroup' > > > > > > > > > css_get(&memcg->css); > > > > > > > > > ^~ > > > > > > > > > > > > > > > > OK, thanks, patchset needs work for CONFIG_MEMCG=3Dn. I'll= drop this version. > > > > > > > > > > > > > > Well that's annoying - the "mm: memcg: subtree stats flushing= and > > > > > > > thresholds" series had lots of dependencies on this series. > > > > > > > > > > > > FWIW, the "mm: memcg: subtree stats flushing and thresholds" se= ries > > > > > > has no actual dependency on the zswap series. The conflicts com= e from > > > > > > patch 2, which moves some code in mm/memcontrol.c, which happen= s to be > > > > > > touched by the zswap series. The first 2 patches of the stats s= eries > > > > > > are just refactoring with no functional changes, so if those tw= o can > > > > > > remain in mm-unstable, independent of the remaining of the seri= es or > > > > > > the zswap series, then either Nhat or I could easily rebased ou= r > > > > > > patches on top of them, and you can easily move the series in &= out of > > > > > > mm-unstable without conflicts. > > > > > > > > > > > > Another thing is, the only difference between v3 & v4 of the "m= m: > > > > > > memcg: subtree stats flushing and thresholds" series is the reb= ase on > > > > > > top of the zswap series. So if you want, you can take both seri= es out, > > > > > > and add in v3 of the stats series instead of v4. If you need to= remove > > > > > > the stast series again in the future, you can leave the first t= wo > > > > > > patches to avoid conflicts with the zswap series. > > > > > > > > > > > > > > > > Ok, thanks. I prefer not to make what is in mm.git too different= from > > > > > what was sent. > > > > > > > > > > I've left everything in place: > > > > > > > > > > list_lru-allows-explicit-memcg-and-numa-node-selection.patch > > > > > memcontrol-add-a-new-function-to-traverse-online-only-memcg-hiera= rchy.patch > > > > > zswap-make-shrinking-memcg-aware.patch > > > > > zswap-make-shrinking-memcg-aware-fix.patch > > > > > mm-memcg-add-per-memcg-zswap-writeback-stat.patch > > > > > selftests-cgroup-update-per-memcg-zswap-writeback-selftest.patch > > > > > zswap-shrinks-zswap-pool-based-on-memory-pressure.patch > > > > > # > > > > > ... > > > > > # > > > > > mm-memcg-change-flush_next_time-to-flush_last_time.patch > > > > > mm-memcg-move-vmstats-structs-definition-above-flushing-code.patc= h > > > > > mm-memcg-make-stats-flushing-threshold-per-memcg.patch > > > > > mm-workingset-move-the-stats-flush-into-workingset_test_recent.pa= tch > > > > > mm-memcg-restore-subtree-stats-flushing.patch > > > > > > > > > > in the hope that a new version of the first series ("workload-spe= cific > > > > > and memory pressure-driven zswap writeback") can be dropped in pl= ace of > > > > > the old version. > > > > > > > > > > > > > I see. So Nhat needs to *not* rebase his patches on top of the curr= ent > > > > mm-unstable, right? > > > > > > FWIW, I'll have to re-send a v8 to fix the kernel test robots/build > > > issues that I've missed and incorporate the comments/suggestions from > > > Michal and Johannes. IIUC, your series is ready right? Then we can > > > have your v3 in mm-unstable first, then I can rebase my patch's v8 on > > > top of that (fixing any merge conflicts along the way), then send out > > > the whole thing again. > > > > > > Does this sound good? > > > > Andrew said he expects a new version to be dropped in place of the old > > version, and my v4 is already in mm-unstable on top of your series. So > > I guess you should send v8 against Linus's tree (or mm-unstable at the > > same base as your v7), and Andrew will replace v7 with v8 in place. > > Ohhh I totally misunderstood this email chain then. Woopsies. Ok cool wil= l do.