From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3054C27C79 for ; Mon, 17 Jun 2024 17:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AE3D6B0249; Mon, 17 Jun 2024 13:02:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45C616B024A; Mon, 17 Jun 2024 13:02:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 324816B024B; Mon, 17 Jun 2024 13:02:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 121016B0249 for ; Mon, 17 Jun 2024 13:02:04 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3B97B1C301D for ; Mon, 17 Jun 2024 17:02:03 +0000 (UTC) X-FDA: 82240998126.19.D3FB25B Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 5B79114002C for ; Mon, 17 Jun 2024 17:02:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZfFnXEWX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718643716; a=rsa-sha256; cv=none; b=KUGhaFcOpmcDPn54gjk+Yvco4F7RtzHSFobEfOW0myHMEr8fT8v+KjGP+z04v/BLA4ozMl vG06CvydLlo+f4/NQvACjWeiyHcmow7WZ9LrdgVhtcxNGmomwN6xVjOU57NK2jHdXAtO5d 6j1Ir+hTU6jiITB07VrVxkGPEc2sWnk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZfFnXEWX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718643716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HM60rjRW/Yf93T5zvJfM1oEyl7EPf4eXUJV+KTU9l7o=; b=sHD+ekhxFsES00NYlzAlIwTaOe+ejKAl+z1x3aYhF4NicnSvDEP9lXRHdArqu3gQ+2O8/v isCZCSbZXHF+XP68ZO6Vqa2mxl1JG6ONdjHC/X2bg6d6WFdihbgkCqoefxAgA/YXZfcKq/ DkTg/EvKtzH7kzprRWAGCEUcBGGSYFc= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6b07937b84fso23968626d6.1 for ; Mon, 17 Jun 2024 10:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718643720; x=1719248520; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HM60rjRW/Yf93T5zvJfM1oEyl7EPf4eXUJV+KTU9l7o=; b=ZfFnXEWXqU8yUE8H2vfXtTt7+oTaNcxK5HghBGrA45dwRP57RByJZF/oXmUOGq0akv /O4ZQVWRIh7uUx6gR4D9OdNEgViN+NkmDbtferle1x2OOWa26DQbhrlpPz8d7oiLE+wd Gsgf7zrs4r+iajeuEthr9iBCm+sh+hWwERAEDGWn/IDJbBYlMRKXcPW/FnR/0f3HAPf+ zQuqA5jQZLWL16ptlzWrR/cK5GEJwwM8rqEKokPr77BHGXt6tADYEl6bC6wTb2JbaDKl GYVVm/0NkyA638XmVh63vBpRBiPl34whW04CxhHXqjHov8zaIxMnd4+D0YxRM6Pd1xZl 0n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718643720; x=1719248520; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HM60rjRW/Yf93T5zvJfM1oEyl7EPf4eXUJV+KTU9l7o=; b=EDlWz1UjWW2eLI1oXDr/jbIoJ2MwpwlLVdxojvcMeVHBlXz40LWwDklfTNaqAGrvSl gfzvn4hK0T9H4sGpoATPMcL6dsUD8dAsYo2AUpBx77oH0mut3H3cDLF8TGHuxbZ4WPv8 0f6nF8b7bg127FY4B6dxJcIaowW8wq+DkTb6EZ1qcc6H2sLPgtjWzTTiy/8iXv7W8lAL Ov2LWmEqypc4tqZhLezMnHoxhu9RBWFTggaJ3MM7KCN3rZYNKJugn28fN/EK5fzY+D7E QPAKSGYDyTtgCRta91GZoPdGq/54HazPeTl3VEIdagCYBBqCVjBpsbZxPMnEGrXnNUqj eOyA== X-Forwarded-Encrypted: i=1; AJvYcCUR58xRI4RC2rrYRdmL3p0hdOvZxRlvMrEAZoQPszlFs2fLKWFfAHHsXshAVA88c/3Wt9Wa5pcTqvHOynBXe51HTvY= X-Gm-Message-State: AOJu0YwI8RNojHq/aDQ7H1bPONKXnqFaHqQHivnayAPbQiokHKyCp57+ ccjGVxNKGZGax9TZZCm14u6lMUEnmSmdOWiob3u5/Dy0XCoG2Kaqptvte/1IGTmHsJjDrgOcGLI PTZjhLyg3YPvhaY44Re2at3T2Qnw= X-Google-Smtp-Source: AGHT+IELEhhMcW+yBw90ppNpYuK8Vh/xr0rN1N/aU8BN1qcmAAFZWf/5fYOzODQNzFeZQk2YLU5HIaKqZY1vJn4o9S0= X-Received: by 2002:a05:6214:4e:b0:6b2:cab4:4ccf with SMTP id 6a1803df08f44-6b2cab45019mr59183126d6.26.1718643719979; Mon, 17 Jun 2024 10:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20240617-zsmalloc-lock-mm-everything-v1-0-5e5081ea11b3@linux.dev> <20240617-zsmalloc-lock-mm-everything-v1-2-5e5081ea11b3@linux.dev> In-Reply-To: <20240617-zsmalloc-lock-mm-everything-v1-2-5e5081ea11b3@linux.dev> From: Nhat Pham Date: Mon, 17 Jun 2024 10:01:48 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm/zswap: use only one pool in zswap To: Chengming Zhou Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Yosry Ahmed , Takero Funaki , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5B79114002C X-Stat-Signature: q4hdktkkz3n8uumoidbb3m5gjhab6jkn X-Rspam-User: X-HE-Tag: 1718643720-973594 X-HE-Meta: U2FsdGVkX1/RcZuhzUnHQwLc3pAPfn4npl+uXWwbC1zfrYXT1xSoHdeY35YosEZuQo81kqxRqNDrlFr74h3ms7QEvIOa0HLzCsaErNo7VHmEgX8xUWiyOTSsHJvwkUIG+MXtVGfS67FDnVXF/Yjl6+LqYLpVSAst3XWiSe+w8GDtM0wIMF9BAvvtX3/i5BZfkDEAW1jvyUZSY/ydl9H2ri+dY2i+yKFwp+9yk9BbgO0pQPz1xtg5HJx7DS1lVs6WozaNu5zK3waXFvJ46GYY9nLYKO9bR+7JuImA4kX2qTAWZpye+gRihz1n7icAthWZhbFQKscKlLNG2Q3G9HmGX9QaATInBO+03UbS9Bb8apOQQBjQWvQIaL9PL5OBAcuEwZ9idOB+ZcRZJ7Xo5oWfG++qEZ13DT73LecaIc/nZii0UQoBlqTUbiFeRFVJV5aY82MOTZhFn8HoF3Xv+ChlbcZon44fB8YlZxra6YWA1849mVEDpIe2wq/NeFJEPG8AgiM00YRPqT3/OOOp+xZz1Eobro22eX9QQ9sYvxtvVPyr07NRwnxncaGgLFFbqdZfwyGNWrn947r7jAcQqX4WkS2QK0wVfsFLiXzk1Lg0jCzyvXplE0wjMXienHS+GNDyVBnawb8Oue/Fg69XDZpR3FUB4EaVNv/86b5jrV+gvGzZIlhww4Ad62ntE7T/+MBXCBzcBcQzXEe894GzNQMJMoXDrPIH2CT+euZMvBrWzM13tq25R8qaGKDCxQpILU9cwQrVY4B6944Idsd7ibKDc7kSDZL0C/xVup55nn3WHj8VPDILhn3atDM/+nm0vlARshwkC7A9Vdhdq1tGsL/7PTwGR2/1eJ6SfzyCtwYz/8aGXzUCc9YgLgci/FKGmEcTC+1iDy/ZDtwnxUuNS4vBY/F/wzCKpgFd+ZFM8gcP9+g+uFS6OUo1PI1s4kq3P3xZ0kN6x4WJvi9Bzgmtk0Y AYzZJE7u BdFgYShsk60wvPj9X66/WoKVhKbdIlHbtewT0dkTimC9DswK7UIhj1WdzmtV4BPfVhZ4pFmr4WJHiKw0c5hMjfN41lUi+q1KmobAHuK8aJh++VT6uY+Foyc0fKt3xVNdWe/q1Qmg8J00ELd5kipTRmvo+AhGfSzF0cL/etjvoG6hwIUt37Jws9S9NueFkdNoePEkeNV8H4ct9iG+MdaAJqHng2czaqMY8EDAe5U9gXDI5412nTce1U6XMd93v4td3thi4usP26nJN6qiekDsQnC9iQadh4gg+ge6pRVZ4NZloc81FoK7WVT/FH7W9jWxYTBQ6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.006443, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 5:58=E2=80=AFAM Chengming Zhou wrote: > > Zswap uses 32 pools to workaround the locking scalability problem in > zsmalloc, which brings its own problems like memory waste and more > memory fragmentation. > > Testing results show that we can have near performance with only one > pool in zswap after changing zsmalloc to use per-size_class lock instead > of pool spinlock. > > Testing kernel build (make bzImage -j32) on tmpfs with memory.max=3D1GB, > and zswap shrinker enabled with 10GB swapfile on ext4. > > real user sys > 6.10.0-rc3 138.18 1241.38 1452.73 > 6.10.0-rc3-onepool 149.45 1240.45 1844.69 > 6.10.0-rc3-onepool-perclass 138.23 1242.37 1469.71 > > Signed-off-by: Chengming Zhou Nice! I see minimal difference between one-pool-with-per-class lock and current version, and the memory fragmentation should be reduced. Anyway, I'll let the zsmalloc maintainers have the final say over their side, but if this patch is picked up (and with the assumption that the per-class lock is re-introduced), please feel free to include: Reviewed-by: Nhat Pham