From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3FDC4332F for ; Tue, 12 Dec 2023 23:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4FA26B03A7; Tue, 12 Dec 2023 18:34:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFF6C6B03A8; Tue, 12 Dec 2023 18:34:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C794C6B03A9; Tue, 12 Dec 2023 18:34:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC5AE6B03A7 for ; Tue, 12 Dec 2023 18:34:04 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79602160130 for ; Tue, 12 Dec 2023 23:34:04 +0000 (UTC) X-FDA: 81559771608.10.03750E4 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf09.hostedemail.com (Postfix) with ESMTP id AFFBD14000A for ; Tue, 12 Dec 2023 23:34:02 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HtcBAimt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702424042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TtJTpyn6WHnHGJdQw4Qk327F16W+w6nqd2j0/8/aQGg=; b=8RwpLvQO5jM1l/TSRXmjOmGhi8/Z0gv5Cu3iOstO/KJUyaVyMHbqZxkxTNLiSOQtA/f7rp jkce/ZGaZXprwa6ZUjA6yMtD1aJQzPhX1tAHFvb1XQFxUiKAHKhnjbnHD88tjeUgaIMc2+ GryE5megFOyTpGeElJ96iYcOSoi+rWA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HtcBAimt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702424042; a=rsa-sha256; cv=none; b=Usad6Ka0gZJt7Gb6niZ4InYdMKsQKwjkL2p/kailfa42Tfkhs0/EbyN33FEDCQ8v52O/60 8ZFJA0CasjSKfumuzjkx5GgtoUkgMsFrMbF5i4AaDwrto+3sj+4ljH3lT7imM2XPSX0tiB ywVHthn0A6EtBhy991nJuc4fFTzHC58= Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7b771176f80so41292639f.2 for ; Tue, 12 Dec 2023 15:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702424042; x=1703028842; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TtJTpyn6WHnHGJdQw4Qk327F16W+w6nqd2j0/8/aQGg=; b=HtcBAimt29T8pIK7wK/qybW1NIxej8se9k6w7Yu0EPDa37+rQdYWJi2uzdMWlRhoWs U8t2GX997QZmHqkHmZ9hgyvQ/yCmfPuLjgpPBl5jJy+KzqxwRd+ClisJ74owtL3PI9n7 IT3LUXCVVWejzt9063zzmJo9eMgt2E/V9schNov1z6DGwpEKaaAjaG8SgRdzOpcL+K/h IZOenX4vo0sICzMMkL5r90ihFV4fV8EJF1J+qQpNYTynKbcmTd+H/klvSX5nP0nDB49e 7r30shd8S6TnOcr7sdRVYUEd8AmQiy4/LyuwOl+t8w1mcSBbzcSUhTog+rUuZL/sdP1p w67A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702424042; x=1703028842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TtJTpyn6WHnHGJdQw4Qk327F16W+w6nqd2j0/8/aQGg=; b=mhl0OnPLe/uvoQbgyHdM25l44b+CBwwmD8BMcojxSaHlF5HaYJKrZgskOJ8nzueBUS 6dJ/Go6TKChedIH138cuI0Idngxj9iPypTkbL7tCmwh5qq4Rw/jCrO3fAQi0KebZPOgj KitBqQw7Ue5PrkLelmyscDKhELujHBbRK0slpQkdjixbLmmFg7Y2XjHdjmxYLkotKhgR iZE1+7yVrIgnd6vgBxgQB8879mwU1D5511Xhtis6yUFy1H6rS6c/lB00dQbvGtNbul1z iajh63czO8HJJT/pcnQ8Wq9NbrOxHFAPf3Jkn7NngcgSAI9n6f2Mo0A+PaL4g8MhbVol 2/hQ== X-Gm-Message-State: AOJu0YzLAbQuimsR/ogjrl+9lOn8/koSn1XTdmRF7x/1otmb8YJ3gcNh 0pN+UPIghvjuqiow6dAYMPkQ7DiXVkLNOFphliw= X-Google-Smtp-Source: AGHT+IHCY5+Y1tkrzrKpX+SOVRIfVFFKwbCOM1fg2+bB2QO5CZhoT5QRozIYql6CKJDECrDXP1XSG+88KNrIHJj/L7o= X-Received: by 2002:a05:6602:2bd4:b0:7b6:fb93:89a8 with SMTP id s20-20020a0566022bd400b007b6fb9389a8mr6566058iov.31.1702424041698; Tue, 12 Dec 2023 15:34:01 -0800 (PST) MIME-Version: 1.0 References: <20231206-zswap-lock-optimize-v1-0-e25b059f9c3a@bytedance.com> <77d628dc-ab8c-4d8c-bc63-7e4518ea92d7@bytedance.com> In-Reply-To: From: Nhat Pham Date: Tue, 12 Dec 2023 15:33:47 -0800 Message-ID: Subject: Re: [PATCH 0/7] mm/zswap: optimize the scalability of zswap rb-tree To: Yosry Ahmed Cc: Chengming Zhou , Chris Li , Vitaly Wool , Johannes Weiner , Michal Hocko , Seth Jennings , Dan Streetman , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AFFBD14000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9tupzxfhjy61how6urh46jnasa95e419 X-HE-Tag: 1702424042-659795 X-HE-Meta: U2FsdGVkX1+SATEFGbhSyxbhtHNDjYgoRkKy1HAxWHLuC5wlN8LY76TcsoFRJxG66Rcj1ncwCI2xi323Rpq1RSe3Qjw3dohf6hPgD4FCvLPV7IivAHR8vW11lyXBZkxNWDJkPrsnTZIoH6fr8SMcmk011i/kN1Nc8eW0kHSoOlerSt3qgy3W13HwdaO6vtIQhpaqbGbo7gjH/C3FvJ/9GPB8IcsYgjWuDx+MRfe3He4uUoIKdg/0yDSFXKAsg/HRadp+M0/Q8FmHscyYD5skmL7HGN1zs4jQzKiCVb5h+e1Z4JC3KcUzjBaKLjCCKFfBvbV3WE0wr2/6y/A+yc/8MIwDPyVqzh0TzuBlBz62o4UXYs7pviCt71+kajDm3CIDwTnmJU9pPYzqhWumCkm4wC4PpVVvPc9AkmVXjKnuQfE+OmuBl8AuFLjwtnDhFXyfSBa3XnQ8QsS2RXTqSUXlOutWbLtOSh8jXFGkY6Og4dGKZ2dm8y6SVCBjgLrw5kEg4OUjBtLh4wlC7bLGOuhsRLhK6LWcJ/ZYuzxciCMFp8J7jrvQoqwtZy9KVOi+iNWsJAs9pZPCM8ts0ih0hajR3/2zREVB4d0X8wBKzo5gkcx/lE6r/B51Co9/grwhs0me6RuEq+Ot7VCmCx7GzCDj2w9slLEYfyLisXkaE7MBtIrCyMT9TZweoAbZxRRRISaGQH5NdwlltI3pyy1Jwesyq82rVk3sVCnuM6IrUPW7SoTuFsDYmm319lCXXs+v3Pc9ZGxo4F6/FyBbLNTObE01wLAY7Qd6GAHHP1rmUYoH0Yn5MNfVbtJ/aC7D/E2LeEdiu2DY8kxmyGImooY/NNNUkn9kA2BfIGYMcTX1fw40v61uWq2tCxXznnSSyigLar5rDEYDAcASpzAAgvFXigtgkyNMPmExxJTZOqgc7JxcpHA7FOiONyUX+k4eCw1SIXBPT3Kaym4EZyQKSO3al4c 2E8ks70E flgP0LWQ6RH1Akb2JFPSzh3bqmTRiHd2N3cIDK4V5XbaZ4vEE83/JGG4KIHsL7DdnNMIos27J67Igf6bCEajXL0V2x8b5CnIs2bOViijiZsD9w+7bv8V9gaIX2S165a9xmB7j+uTVJQHVQI2F0cJa1NH3D9pzGWgsSxZzWeaaJAO++T/UbuxgXBoaK7QEs7o9M0KMy9jGUCG+QnV4v1TGf2tdfHOIP1paR7Y/D3HPtbl2CQzl8bHio6bri4gwwyD5eN2QHFA9x+xD8TxaEjkB/9Fdi/qBgZ8lj6Wiwnkz0SFa3JtH87HGX2sJIxjk1oIXwiUEogos9JjnNERfoPq9jXE+epN6rkuqjw6+J2E1GJcl5TcmKnzFT6ouyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001520, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 3:27=E2=80=AFPM Yosry Ahmed = wrote: > > Let's split the rbtree breakdown into a separate series. This series > has irrelevant (and very nice) cleanups and optimizations, let's get > them separately and defer the rbtree breakdown part until we get data > about the xarray implementation. Perhaps the tree breakdown is not > needed as much with an xarray, or at the very least the implementation > would look different on top of an xarray. Actually, kinda agree - I quite like the cleanup/optimization done w.r.t dstmem reuse :)