From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14198E7C4EF for ; Wed, 4 Oct 2023 19:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883076B0288; Wed, 4 Oct 2023 15:53:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8335F6B0289; Wed, 4 Oct 2023 15:53:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3EB6B028A; Wed, 4 Oct 2023 15:53:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5A55A6B0288 for ; Wed, 4 Oct 2023 15:53:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C47B1CA4B9 for ; Wed, 4 Oct 2023 19:53:16 +0000 (UTC) X-FDA: 81308827992.07.9E992B8 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf05.hostedemail.com (Postfix) with ESMTP id 60396100013 for ; Wed, 4 Oct 2023 19:53:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XEJ4dZAI; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696449194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=miM9Rii6r7WYSuGpAV4z/io68HUwHuAXAnsLamrRpmw=; b=b/gtFjTHO9wwCNigSdSndG6w1EsSabpK3GZCViw+0vFG7zTiwkBgE0aRzTByEsYTfDwlwq IMh++2hHLjAR8xoaexhksH+GDcrTJ/RrbovpYvPGJMb7FKx+y+WOUce9bDd+AciVMsFXIp RrU/GAKlMsP3vsiTYQ0q7OXlOOzsBs8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696449194; a=rsa-sha256; cv=none; b=nsPhIhU6BZVu55/+6kPESaZpxjpvtMluRgewrKM+Joon52KguwdIH85gXrX3kf1oe75Fot szt+TY9DgVk7isB60+mTvl36uXKGvBuTXf1CJ5ibwsox+8HhPhJXdTs9unxNv/r6IdxGv5 eQFc0ssbu5ok69+r+EcYqc02dFtF0Hs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XEJ4dZAI; spf=pass (imf05.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-79faba5fe12so9543439f.3 for ; Wed, 04 Oct 2023 12:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696449193; x=1697053993; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=miM9Rii6r7WYSuGpAV4z/io68HUwHuAXAnsLamrRpmw=; b=XEJ4dZAImNk8TWKTfHnHm3FqUGVhVTlaBUjwT4LpF/zCL3Oaj+5p0Yd5/TpF8LrgoF QwJoSMct4HPO8K+2brYWsiHJZPVTrIZphMV7PkHo5SAU7QtkRFC2dNZYWALaGPBBLwNr 1sS+4oGHp/N53QtjCCh8/M4iEAI5kqOeP8kdUebyqOT8Oie1i8e74JaY16r+e72zPUtY 5zuw/M9enYBoNIN1I7eBRyCUlgHDr9ezrr0czYt/yGn5bygFdqDbQ1Ox5xxDyPKWVfni BKdA6iKPjyYLipyL0cDlq4gdpVzyHqKjd5ibQ38SSsUjWKNJ7ae8bdixBvlMYia6+UsG e5CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696449193; x=1697053993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miM9Rii6r7WYSuGpAV4z/io68HUwHuAXAnsLamrRpmw=; b=XcGe8tpdb9hsx7ZAxcB9DiVpppiWn4eesBajB5gwg5hqd+xxZklf5zwF3f5ppRoAO3 TU6oG+/FjscKSdjz36o5F5youGzEV4tRErSfUzcP4JpVt17KobZKlaZnI98VIHfPhQrR pzJJqhool2eAsKPlZO+RC4aP5LDRHWZ66xQBCHg+QF5mNlcfMQRLQD/h02Jym2kVVvpe nPqDM2PUQfdiLaxUXDlMGFjMVp9v1VEewqDkCriFMhrqBGvTPIpkPGnnybymT3N8snnT AqsHB6UZBWewkjLLtSYQgd3aYMy1xUpxZYvaCVGQBJEtJTQgx4N/QdJx/ZRaXdXEYAQZ 52Rw== X-Gm-Message-State: AOJu0YwCyHlk5wl6Jcc0YSiJDNUlesmNDViQQhqZuycB+AGWfpOE8t0y bzFDqbfvG5wc3JOaKr0IT086CKongIx4ACpVE8g= X-Google-Smtp-Source: AGHT+IFKg00R5moLNg6dEnKgS3rIAz2WiRfEfg5bKT/ca2Wy/+DA5vO4GbgFWE3mxG0yLDaSHARh6d8ackVGNstxcck= X-Received: by 2002:a5d:9943:0:b0:79f:d194:d6e2 with SMTP id v3-20020a5d9943000000b0079fd194d6e2mr3780651ios.10.1696449193517; Wed, 04 Oct 2023 12:53:13 -0700 (PDT) MIME-Version: 1.0 References: <20231004193622.900383-1-nphamcs@gmail.com> <20231004194630.GC39112@cmpxchg.org> In-Reply-To: <20231004194630.GC39112@cmpxchg.org> From: Nhat Pham Date: Wed, 4 Oct 2023 12:53:02 -0700 Message-ID: Subject: Re: [PATCH v2] memcontrol: only transfer the memcg data for migration To: Johannes Weiner Cc: akpm@linux-foundation.org, riel@surriel.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, mike.kravetz@oracle.com, yosryahmed@google.com, fvdl@google.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 60396100013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xwonz7afhdum7zr57xan4inoj8ho816x X-HE-Tag: 1696449194-67071 X-HE-Meta: U2FsdGVkX1/5PzBATqMvW+XRMPqshYGxGs4rrs9fdUUfhTKtLruDyC6TbMrLcmA+j4WYcw9BokBgGj0pscYWEr37LolpLS7wbtslwELARa8DSpxtolm2RxHNfRSIdyZ9EUojWCqkWvG2iXsvFm8uMCvsobCyjL/LeOU5c8UTVZPd4mI1MpY/ZpsMuFz1UbZjUs7i+0RbJ+2JSSRkVrzKvc2pdjM/3mEL6C4ThPlYf7Y34PXA4qnEFOD+ro+7mpuU+Eu8iREhnEckOVUCum4PHACQ2g24muNj0rS+4fYOKCJikmjVvlQ+hWWivocD73KUJje4z4+zB+ySfnjlr2vR4B92qb7mLFJWmUb6kbzDaTKQeditx3yhPw4NwJWvbiEUTE344HbTgRflUnyhpzpYy1KUzTSJ2jcDWX7IxgCQnYGqlEC1DYYNSnr3hogtdivQymf/49se1RwqsubUthMt6oydDgPS+J0/hj+Kfu87ZNBa5Tp+JG1SCsyRVqnAISw6vr5M5eb1UeYjPDoxNbxcrnJT5VH+GuVSJjqJSNpEpfzE1NGw4KYt9ZeR9UPOkbXoHwbbLUe5b6epVYyo4yXvQkX4AZCIfOSpd01wpHeWljPvzo6YVAJAVEp6KCxx8GBTMg/K9NVye94PJwtFKnmymtrLM/sO1OL+oNlLDXLs6gmrfGZrTf4wM9msgHusy1qwahMd7VceyfGC8AZt5jc9u1RFV9FOrse7aWbfKZalAUfeK1En+KuWLgMfqAuVMW8AuGqgzJcgw/JASwFIvlIfuVbkK/Ff2WwYQTvlULr5kELyXI3UNSApvesxoE9EYtLwiixFJtJ59V9HNmaDIy0dak3V7HDyS2fzzJu+JHhXf4EFXTjcMiSZ6/4NvuIPmBWhAGPovifY1BfCZl0p/r3pmjj+b558AyFl6naeTQcSp24YExv8E1VjAzBj+V67x6RMY2adyZ3UiTnioXfCtXA +RbhlauH ru09Vs7FcwPA+aGn84ffHevNsj2vdVuafbcCJAX6EPJZX8ly8PPhrTu2XZ8o9mQheR3W9HjFwlDtlMZKkXH3f9vsjQeU/+UODGcH/g7ykEyVU7K5BQ7SG8vOVaTjHZ101Y7+14ElVhHulwK/an9ay/sAOqQiUzfd+iXnSQzg5Gwx/QEQnRR8OuCXpPwhG2QsuT7saW2EVOzjn1Xmq7Zv9hGLSyhSEWj3Jf1mDt8RztQUQPJYozaX4nd5M6tGT0u6uT8M0LOjpd9Ep6P54gOZo8YQDu44j5OP3cfpaYNRxCLdXSnUXDEfYGB+rZNGi9swt5mk2VVSYLewuT3JD90IKBZVC+WKsLWer803E33gXFiXWPZI58vzc9j/Fxx+6aOzyxau4q9KvJW26sqS92N8tuysg4oAkfDYswSjNCzOuGRJ1uaSf0O7cAQuBsJ1CQyZR2TA3b2kp0smNlEgTtgV5vLjm+xj0fJFX6/Hu X-Bogosity: Ham, tests=bogofilter, spamicity=0.001108, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 4, 2023 at 12:46=E2=80=AFPM Johannes Weiner wrote: > > On Wed, Oct 04, 2023 at 12:36:22PM -0700, Nhat Pham wrote: > > For most migration use cases, only transfer the memcg data from the old > > folio to the new folio, and clear the old folio's memcg data. No > > charging and uncharging will be done. > > > > This shaves off some work on the migration path, and avoids the > > temporary double charging of a folio during its migration. > > > > The only exception is replace_page_cache_folio(), which will use the ol= d > > mem_cgroup_migrate() (now renamed to mem_cgroup_replace_folio). In that > > context, the isolation of the old page isn't quite as thorough as with > > migration, so we cannot use our new implementation directly. > > > > This patch is the result of the following discussion on the new hugetlb > > memcg accounting behavior: > > > > https://lore.kernel.org/lkml/20231003171329.GB314430@monkey/ > > > > This should be added as the second prep patch in the following series: > > https://lore.kernel.org/all/20231003001828.2554080-1-nphamcs@gmail.com/ > > (hugetlb memcg accounting) > > > > and should go right before the following patch: > > hugetlb: memcg: account hugetlb-backed memory in memory controller > > > > Reported-by: Mike Kravetz > > Closes: https://lore.kernel.org/lkml/20231003171329.GB314430@monkey/ > > These two tags shouldn't be here, but in the fixlet instead. This is > the dependency patch. Otherwise looks good to me: > > > Suggested-by: Johannes Weiner > > Signed-off-by: Nhat Pham > > Acked-by: Johannes Weiner Thanks for the review, Johannes!