From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42995C4706C for ; Fri, 12 Jan 2024 19:42:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5666B008C; Fri, 12 Jan 2024 14:42:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A955F6B0092; Fri, 12 Jan 2024 14:42:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 936026B0099; Fri, 12 Jan 2024 14:42:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8144D6B008C for ; Fri, 12 Jan 2024 14:42:56 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4F664C0D14 for ; Fri, 12 Jan 2024 19:42:56 +0000 (UTC) X-FDA: 81671681952.02.4B461C8 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf28.hostedemail.com (Postfix) with ESMTP id 82261C0014 for ; Fri, 12 Jan 2024 19:42:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BWC88gM1; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705088574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7jBwE7Jt9seeB7l4z11oYjZwnUcDEcCEvTkM2Ir2NMI=; b=Y4NMO+E2luSzK1TLsUt54e2IiEDWWbBNpS8nA40FatWaPUnCtTfPsxOawCF5KPwJai43BZ lLvUV0nuPb7cuMzvylMzKOfy7KyyaA1kMvlCsf7hX3swPtg8mX+7XH0IN7O1usxnuuqvFq AwEd+EPQEQZ8LSEu9ToxEoH3X8yOrj8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705088574; a=rsa-sha256; cv=none; b=GWWUkZQgWJo96MLgQheF1J6mPY1ipJEIjO0RMIDeWnYjMVz4z6S1lRy0d+uGdViQ4Z1cy5 OWbFI64YaaNtmnbwxKTwGP7ee+9wRPsLjUfPVAOVCAL/HiTeu95ic0hT4x8qaZc5U0ICoU GBubcuD7edEe1vfWMnRiBR14wATDcLQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BWC88gM1; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7bee328027bso131580439f.1 for ; Fri, 12 Jan 2024 11:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705088573; x=1705693373; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7jBwE7Jt9seeB7l4z11oYjZwnUcDEcCEvTkM2Ir2NMI=; b=BWC88gM18lCUnt7ySLzwgR4knxGyEGtGNcmczEMax8bLyrIIcwSYGH0SMVTbtFlDhv isD6UtOHVm0N5X8Gp1jKEq+gMpaUrTZmKq7pYxM9kBXJIJRct093Qm5jEBSHPrDC/Jrl 34nJ9Zz3RSkHDG6F9tfvzhYU2MELMGnzm1vJIdUpxBhVaX1cU2bGCWG3A0j+Mk/rcaDY HliA7KtrhBpXuBp6zySUtcYPKLhY8R4hel8gk8bUKa2cTgS6qKIL59Xpa0sVNlvpjzW6 /xm+wBZw2yv/bCMRaLAJPiXNNQlj9gwg8MULrnzEPe52PdN2PRlHVkJ/umbzpFJmuJzA lR5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705088573; x=1705693373; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jBwE7Jt9seeB7l4z11oYjZwnUcDEcCEvTkM2Ir2NMI=; b=S+VmiTggpFhmtxEfh2/Sh/Xix7zI1CUshQjc139EgOCEwswPyC7Wns9f8y+68zYYKv 9FexCBD8giMQqmez2Qv3O6J+uxsHZU1aJnxdJ0vvDGY+IExzDgx3Kkcy71+XyQI8Di7a NG8R6xWv9CvD/4luGUUhZ5dpc+CmXXHg/sKhhjnksxpC2uj2Fe5HknGjffMeNcnO6Vf1 FfvhoO29VGX7hJzhqagCNIhp4vFEowgGGzy0hXH8T5OE/59ep1AJ/6sCUkTUdDu1y9Cp 4OZdG3ap9sHZYOoyXEW+4ken4TvtKue9B36nZ7n5J/dS5OWvZi/cj+GmQtjXoA/ImgrW wfsQ== X-Gm-Message-State: AOJu0Ywn2+khffHBcPufNTRQch5qgwEHvEMBnUcY7U74cO0jqCncqLw5 hegZbKFlSoReW2/eIuCxHUcmeoydWMsfex3r03A= X-Google-Smtp-Source: AGHT+IHfCfBeIKefE1pIXMRHJc5enwSKf3AqqH1Q2r68AUAgrpkc5+s5bMgmxMzoF9BtYalbpQtcdFcbOtmlcSPYcNU= X-Received: by 2002:a5e:dd09:0:b0:7be:f53e:4dbc with SMTP id t9-20020a5edd09000000b007bef53e4dbcmr2169399iop.28.1705088573558; Fri, 12 Jan 2024 11:42:53 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: <20240112193103.3798287-1-yosryahmed@google.com> From: Nhat Pham Date: Fri, 12 Jan 2024 11:42:42 -0800 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Yosry Ahmed Cc: Andrew Morton , Vitaly Wool , Miaohe Lin , Johannes Weiner , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 82261C0014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: o4gqrazcnu1c1ousnudmcxnzi86nyn3q X-HE-Tag: 1705088574-360362 X-HE-Meta: U2FsdGVkX18E+R5Vq4/F+PrfrdwKZPXnq+ekQ3mqwZRGukvfzbU/GKMvlNKvk9Nb8kbCfmqgX0bF3v2r2zSaaVp6+l5IoBhxwGP++cFavn3etIEyYzrVdj7wE11eLP16k0JXB1wf51CjnJnNkD3EnE62oFKYfqcuYi88NNHOTZGK3yQ7nAN4eRk9j7A0wZvhusPgJJiqvWhLNY93xI2uLHB5sxPNJmMCz/cxHXkeM554X3fT8LlDEwmnKgObFMtfTAFvIrtz0JiOHoOkUZNL9C9dp7Ttc3IGOtkBq86VwxmmCxZ4c7oNg/bbsdVlbt6WzW1aKqExm3bwr2l08qONhpAKeSAILDHlGPEE/9vYM0xCvhTDzEx3ka9V0QAWpeE5NmukqSlsXsrGCi+SMkQLyTL7bI2MewLJxlyJj+dYBG0PfY/Q0u/UPtBrxjTNaSloyf3W4bEbBg0D0P210/+90JgfSvQg47dKwqc5rbjzTDWwMao3l6MZqdAMsQbxnOUIExfAo7RH5mVNGkhUto3fcIvwpy4vsymakQ9Uc7NCTc0RYPZ7Ky2hAE+aqCvCDj87zzPevp+E7DqDwoV8rySuIaOhZTIZ2OymZ3Yx4T1KJg367bvULquxVjKa1Wt+uP08tnKfT+mF2Ffi4Xa7phSBgoO4gEKEfPdRxpb+DKR5/v6UH3tMJYqZ3PIqe98yCUZXziBTtX0U3IuZnIoDBhPstju+KzmD433PuXGzmtBbiPLXUXCA7a9b3MxGD/XeqN2BynWyQqEUY8MvDVwRyLajwvNKx46Wx9COuppJvh5PrVGN4mEGEP0VEE/QpmeZGvVAQvMop2vAJ9XVnNFDAERwf+YmWG1qYHMYD5/E/QJl2RaImBFvCgFnRhdE4CwxjIXUyA8JQHg8MPCSPv3n6R3shHqBP6NqSTZhFS8ZDDrsYPwJrw9R9fmK9fZ42F4kZBVp9oPrqhkLVV6EBT8ypaW IpnKDtBE MPHeApwaBG/KZJbUK1PurMRrHszrRr/lVytSMMy7I/LsRTEr8/a3ncO72AJ5yjoB3bjfF4PWCNXCwthmhKRDonIXiJ3Dv2vIbML3Vy8bCnYzIGbbYb/oRSqCwlkt30tAS7WgximoOfE9sgWAHCXWb38yY0LE4nW9X7wVacWwuqH5S4aEnj3gMBaVEScv0huC5W+SXnSSTYJcq6F+eQC9S4fksWcZt4YrHo9Ds9fOUwjXx6fqMIlOe3MfljOAUAruiy3lAM+L9kNe29SRNPPFbfIHPurx/PSplv4G1qJDo20hafVk5oeftyZQlsCF7Mcbwis/BZvGmKeIZn+eS1QkvWop2Mc/5eEMB67gwp1ymqwyrH81hMwLh9uEfKImthxB4+4h4yDFW31orrc06hngnOlOO7i7cRD9AFbS5gspzUtVPi0A5KG3ZGhhww19G1a/Mz0y/Xsekp6fCUeXAQS9zc5bMJ9mTNTbsecuIaEMWPZ84uA1bejF6oyBtmHgDD65NPK11 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 11:31=E2=80=AFAM Yosry Ahmed wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator for a long time. Johannes and I were chatting about this the other day. We might be able to disable certain zsmalloc behavior in the case of !MMU, making it available there too. Once that's happened, we can outright remove z3fold and zbud, and have one allocator to rule them all? :) > > In hopes of having a single compressed pages allocator at some point, > and following in the footsteps of SLAB, deprecate z3fold. Rename the > user-visible option so that users with CONFIG_Z3FOLD=3Dy get a new prompt > with explanation during make oldconfig. Remove CONFIG_Z3FOLD=3Dy from > defconfigs. > > Existing users, if any, should voice their objections. Otherwise, we can > remove z3fold in a few releases. > > Signed-off-by: Yosry Ahmed > --- > I have limited understanding of Kconfigs. I modelled this after commit > eb07c4f39c3e ("mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED"), > but one difference is that CONFIG_Z3FOLD is a tristate. I made > CONFIG_Z3FOLD_DEPRECATED a boolean config, and CONFIG_Z3FOLD default y > so that it is on by default if CONFIG_Z3FOLD_DEPRECATED is selected. I > am not sure if that's the correct way to do this. > > --- > arch/loongarch/configs/loongson3_defconfig | 1 - > arch/powerpc/configs/ppc64_defconfig | 1 - > mm/Kconfig | 13 +++++++++++-- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/= configs/loongson3_defconfig > index 33795e4a5bd63..89b66b6c6a1d5 100644 > --- a/arch/loongarch/configs/loongson3_defconfig > +++ b/arch/loongarch/configs/loongson3_defconfig > @@ -85,7 +85,6 @@ CONFIG_ZPOOL=3Dy > CONFIG_ZSWAP=3Dy > CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD=3Dy > CONFIG_ZBUD=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dm > # CONFIG_COMPAT_BRK is not set > CONFIG_MEMORY_HOTPLUG=3Dy > diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/= ppc64_defconfig > index 544a65fda77bc..d39284489aa26 100644 > --- a/arch/powerpc/configs/ppc64_defconfig > +++ b/arch/powerpc/configs/ppc64_defconfig > @@ -81,7 +81,6 @@ CONFIG_MODULE_SIG_SHA512=3Dy > CONFIG_PARTITION_ADVANCED=3Dy > CONFIG_BINFMT_MISC=3Dm > CONFIG_ZSWAP=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dy > # CONFIG_SLAB_MERGE_DEFAULT is not set > CONFIG_SLAB_FREELIST_RANDOM=3Dy > diff --git a/mm/Kconfig b/mm/Kconfig > index 1902cfe4cc4f5..bc6cc97c08349 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -193,15 +193,24 @@ config ZBUD > deterministic reclaim properties that make it preferable to a h= igher > density approach when reclaim will be used. > > -config Z3FOLD > - tristate "3:1 compression allocator (z3fold)" > +config Z3FOLD_DEPRECATED > + bool "3:1 compression allocator (z3fold) (DEPRECATED)" > depends on ZSWAP > help > + Deprecated and scheduled for removal in a few cycles. If you ha= ve > + a good reason for using Z3FOLD rather than ZSMALLOC or ZBUD, pl= ease > + contact linux-mm@kvack.org and the zswap maintainers. > + > A special purpose allocator for storing compressed pages. > It is designed to store up to three compressed pages per physic= al > page. It is a ZBUD derivative so the simplicity and determinism= are > still there. > > +config Z3FOLD > + tristate > + default y > + depends on Z3FOLD_DEPRECATED > + > config ZSMALLOC > tristate > prompt "N:1 compression allocator (zsmalloc)" if ZSWAP > -- > 2.43.0.275.g3460e3d667-goog >