From: Nhat Pham <nphamcs@gmail.com>
To: Li Wang <liwang@redhat.com>
Cc: akpm@linux-foundation.org, rppt@kernel.org, david@kernel.org,
hannes@cmpxchg.org, yosry@kernel.org, ljs@kernel.org,
Liam.Howlett@oracle.com, mhocko@suse.com, shuah@kernel.org,
chengming.zhou@linux.dev, longman@redhat.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, "Michal Hocko" <mhocko@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Muchun Song" <muchun.song@linux.dev>,
"Tejun Heo" <tj@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Yosry Ahmed" <yosryahmed@google.com>
Subject: Re: [PATCH v6 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback
Date: Sun, 12 Apr 2026 17:01:28 -0700 [thread overview]
Message-ID: <CAKEwX=PWiCcyX03YrZ6GOXK4MEOhos6TrTNMm=047xApqDJhXg@mail.gmail.com> (raw)
In-Reply-To: <20260402063714.55124-9-liwang@redhat.com>
On Wed, Apr 1, 2026 at 11:38 PM Li Wang <liwang@redhat.com> wrote:
>
> zswap writeback is asynchronous, but test_zswap.c checks writeback
> counters immediately after reclaim/trigger paths. On some platforms
> (e.g. ppc64le), this can race with background writeback and cause
> spurious failures even when behavior is correct.
>
> Add wait_for_writeback() to poll get_cg_wb_count() with a bounded
> timeout, and use it in:
>
> test_zswap_writeback_one() when writeback is expected
> test_no_invasive_cgroup_shrink() for the wb_group check
>
> This keeps the original before/after assertion style while making the
> tests robust against writeback completion latency.
>
> No test behavior change, selftest stability improvement only.
>
> Signed-off-by: Li Wang <liwang@redhat.com>
LGTM.
Acked-by: Nhat Pham <nphamcs@gmail.com>
prev parent reply other threads:[~2026-04-13 0:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 6:37 [PATCH v6 0/8] selftests/cgroup: improve zswap tests robustness and support large page sizes Li Wang
2026-04-02 6:37 ` [PATCH v6 1/8] selftests/cgroup: skip test_zswap if zswap is globally disabled Li Wang
2026-04-02 6:37 ` [PATCH v6 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-04-02 6:37 ` [PATCH v6 3/8] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-04-02 6:37 ` [PATCH v6 4/8] selftests/cgroup: rename PAGE_SIZE to BUF_SIZE in cgroup_util Li Wang
2026-04-02 6:37 ` [PATCH v6 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap Li Wang
2026-04-03 17:16 ` Nhat Pham
2026-04-02 6:37 ` [PATCH v6 6/8] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on large pagesize system Li Wang
2026-04-13 0:29 ` Nhat Pham
2026-04-02 6:37 ` [PATCH v6 7/8] selftest/cgroup: fix zswap attempt_writeback() on 64K " Li Wang
2026-04-13 0:15 ` Nhat Pham
2026-04-02 6:37 ` [PATCH v6 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback Li Wang
2026-04-13 0:01 ` Nhat Pham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=PWiCcyX03YrZ6GOXK4MEOhos6TrTNMm=047xApqDJhXg@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwang@redhat.com \
--cc=ljs@kernel.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=yosry@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox