From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965A7CF9C69 for ; Tue, 24 Sep 2024 22:16:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCE096B009F; Tue, 24 Sep 2024 18:16:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7DD46B00A2; Tue, 24 Sep 2024 18:16:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45346B00A4; Tue, 24 Sep 2024 18:16:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A7A526B009F for ; Tue, 24 Sep 2024 18:16:15 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2852A160560 for ; Tue, 24 Sep 2024 22:16:15 +0000 (UTC) X-FDA: 82601041110.02.83E2AF7 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf11.hostedemail.com (Postfix) with ESMTP id 42D0940002 for ; Tue, 24 Sep 2024 22:16:13 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gcyNIOCw; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727216113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=txeFjNw/6Qh5cqoMHgv3o9+mu42DVvB/pzMKlMLnc0M=; b=W5g0JJWMPYQzcMMjSmbs4AbxAfV6/cFNUqLFnn2OuGtdT3kcF4EWYTPVFk4a56G/yQ9Rlk PtNfDBkAIJB6HphOt79Cct17WGKbQB0PtuU+WNrhwzbxy6WL2zmXb+4XqjaRb2cHYskkcb G9d7FjPhtFygRYCHpDKY5fRgqrT7QGE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gcyNIOCw; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727216113; a=rsa-sha256; cv=none; b=ePy1r9/fZfIMHgdevb2w5bSTm/aEEngBEDpX3CWS0kbwqxyzGWlk3oibH902xrAAggcbyJ S47Ku85P3svQ3ijIZ3K380aiPEr/uQNOCZ79TITHx1l2MYSEmQzcl7HIFqCVND6f2sVKVR jF2ow6r7ZbcOkQ05PeHeVYRRNTGBle8= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6c51d1df755so48370566d6.1 for ; Tue, 24 Sep 2024 15:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727216172; x=1727820972; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=txeFjNw/6Qh5cqoMHgv3o9+mu42DVvB/pzMKlMLnc0M=; b=gcyNIOCwnY1iGW0weXdwLYCO7CCIAteIVxUHeRinbmeH2yHqR4VYsTQ7nq2L8xCDUL mzMQMpLNrKOswseW10kHvqrl1WMO+2a4jOffEbVrSPhvYrp+EW4k6xRnPL33lWtKRuzh cNS9hODjdW51vb5VhAB0K90eEYxXD86d8i2Slt+aKq6Hcu/byPTTIViz/4Z/Tm4E2fbM lHLwZjHIs9okr9uM9IZasaL6jIFHIdzRmY9qmfJ68L0ro/3wLxjuQGohah+DG6wr/PDO I6Ojd12kv9cklYvKLzBrWzWjRDtVeQs6dDpndnN175P5fwBf8THEEEvgmMyf5eu38Z7q IB9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727216172; x=1727820972; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txeFjNw/6Qh5cqoMHgv3o9+mu42DVvB/pzMKlMLnc0M=; b=sPRfT0c4lfoStwDEqLuLUQ1WbRmPUehaTKsg0TsdDkp3ZSRruIAJso7ZM1aOaJst9b KbXEMIoBWdxcfb4qGlpaAPw4/CCkt4t/q54cf9N5dFtEHkWy9jJ6dyzSccfiMk6jZeA6 6tBq59iMMVy7nwmSpUlDJWpUgu/sUt98GTvHt/Aj0c015uajSayITsJGKEQtvuWDpyRz nz/EhRsz7K7W26mcblCIGnfRK+dY92/m7Aps0985riDo7NrxpZFIqOrNR5ilhW1guZSN 0ysVC8BZ43A5/LFh4v2B6Cj+Tq+q7njfxGXfEC4jNfDfTpWBmFi6+WQzDsV1VlFq+v53 y2Sg== X-Forwarded-Encrypted: i=1; AJvYcCV5cj2qSBChh1eg9l4o0Loq5BSl0GmcnK30bbm6Z9QVTjJ9uXkAhOWiECcmumTyTRxjDRLJZcMH3g==@kvack.org X-Gm-Message-State: AOJu0YxlyAha/SppOaoWNZ6rJ/vMguFF8s1VktHrFmbA1X70NF5rTtNW ukSQzUOJuzUUszKTwUKmNwOBNRF8Uhb5KY4GUboT7e6DJeSKIPO82ZePpaXP1j8qK/ugYy++wBU +BrArXTTW7lLxR3mLCcImY3UZskI= X-Google-Smtp-Source: AGHT+IH4vxzFds+3F9h/A+qskezZSIuAqbvb41wRwBntXHr9rWqwFYWLvTsi4p7Ia30Sg2LeGBQLV9SCFXfHMtDVptY= X-Received: by 2002:a05:6214:534a:b0:6c3:5a86:6a29 with SMTP id 6a1803df08f44-6cb1dd6b2a6mr10609246d6.21.1727216172278; Tue, 24 Sep 2024 15:16:12 -0700 (PDT) MIME-Version: 1.0 References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-7-kanchana.p.sridhar@intel.com> In-Reply-To: From: Nhat Pham Date: Tue, 24 Sep 2024 15:16:00 -0700 Message-ID: Subject: Re: [PATCH v7 6/8] mm: zswap: Support mTHP swapout in zswap_store(). To: Yosry Ahmed Cc: "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "shakeel.butt@linux.dev" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Zou, Nanhai" , "Feghali, Wajdi K" , "Gopal, Vinodh" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 42D0940002 X-Stat-Signature: o1deeskrkfm3fe7hfxj9ygby1nh8b8hz X-HE-Tag: 1727216173-733273 X-HE-Meta: U2FsdGVkX19QSWmQwqJKwGavzOhrWKrzn+hg+s9xpzFFPHj9Sb05b1GP83wgcoTfGVg4PPqB6sbut1+TOP2Dvx5M7nbygVRMkoHkjQiLw/YRX/SRmSEubnbN2AiUYIbag9/1LbwDDzB4h8POAPAPHJN862QXAeHkNUhEyHxyxQelpQcAX6YjiLvUkPpDxl5To48wHezcI3HXw12czPRn6x1bVdnudvixGbsPa8yAYGOfx3T1TpVGwmffR6Wcr0ytk0wtYOnwwQB7rPz0n5MX/doWEGMcpxwIgIUD33l3C07xtXAcB6gylRRgRbQ+fYIkWJdRCbBfcOIL0FHILLkOzy7XsTVMBC/pm75yIrRtMOA6GOHq9HB+7QhF7LOD706rCTvpFdsDgII0k+H8gIQAJx1wUaGqmgBqUenzrpG+tlLmTLWlaPJqOygOI/WizMXIXYF9706DedvLJqID2dPNvSbT8rdyNARozo+TxcjUD5eJFIHx0SzYQRzfk7LCPA3O/CuX3hxrrQkgVIuFkj42WB0GFafHPH+jIIsior40tnGc39bSiPgBodWJANbC3bea/oFwkIGJ25ZAwn8SasK/hKc7S9RrECYPISxznVoojaf9IudSmBFcHmZgNyFsPXdy3yJGDlgNCas/cgedX/XnxJXr6WRCMX+k/FuGQzl10EuSn/2IjdIdogLJ9sdiLf7gNxTkPvmJpiY5kpL0AnGuraY20SK0xS78NRXjN6skETtUnhP4SnuVhmJg/o2IKwoskDzx7jqa2nf5ZnUcpckTHkCKHkDsWICXP5VdNxBI+/HtDYh3Oj+RElZ3i1AygF5X0x+w5UtOvrvd53jkgDWsIBZvOM3tz+fm+vuXOdmTJynYgA7h5ncOaTMjEu3IgcttjEFOUZY46RGvLqc5pSaBgT0ZT96sm9CE/djqpxsiCO2LyKCCTHqHS92frS6I3GTX+U6x5hbjiQEhRnE43Mn uxxjFu5O GG31IhiYgkyG3xhdEDQTjXjJdCA/t5yGb1gqqhLAtnS3L6O3ukro7ksLVjgCyX92IIqfsEXiSxfXlcqessE356Gl5WX1AxN+bY61Yi6Q4zD7FvwClFWI0VcVGCu2FDrU6Sec6Vlx3GfV732RUyzcUt2h2gzhuDiqhJYJIcyRHx+wJLazuNpM+X7wjgbNHuYqTBp49bHKBoGJjDFnsy1wKt2KU5EM809kX3K0ZJW8J0okLZEBEMeqhhGJn2YPZrbAgU9DB/GwaiVwbwm1zA8zViOH5hJKfeRX6eXVQnGffugZz7xd4ofqjZ1BK0cT3uboEZWAul2dUY0X63o/SdGzSwa69AccZ4I73NRUa7VJQTg4uwzaNp7eCoCBxqAmqoYVWvET6sewtd1n9BJhO3okhFZMuBgi+6ihL/WP/pQnCTFpH0+FhsHsBmGo7yg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.263867, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 2:34=E2=80=AFPM Yosry Ahmed = wrote: > > > Why can't we just handle it the same way as we handle zswap > disablement? If it is disabled, we invalidate any old entries for the > offsets and return false to swapout to disk. I think that was the suggestion. > > Taking a step back, why do we need the runtime knob and config option? > Are there cases where we think zswapout of mTHPs will perform badly, > or is it just due to lack of confidence in the feature? Fair point. I think the reason why I suggested this knob was because we observe so much regressions in earlier benchmarks, and especially on the software compressor column. But now that we've reworked the benchmark + use zstd for software compressor, I think we can get rid of this knob/config option, and simplify things.