From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF4BC67861 for ; Fri, 5 Apr 2024 19:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4029C6B0093; Fri, 5 Apr 2024 15:57:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2F66B0095; Fri, 5 Apr 2024 15:57:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27AFE6B0098; Fri, 5 Apr 2024 15:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F066B6B0093 for ; Fri, 5 Apr 2024 15:57:46 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AC11A1A1272 for ; Fri, 5 Apr 2024 19:57:46 +0000 (UTC) X-FDA: 81976538532.03.B25AEFD Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf01.hostedemail.com (Postfix) with ESMTP id D8B3840020 for ; Fri, 5 Apr 2024 19:57:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnXNUibn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712347064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; b=vR50UlhKFgpNsNp94Vxn99UmZeQwD0CcuSfe40ICQZIX+EfZVp92l5w8U7QC3MORzS+z0c r6ef2Hfn51S1o8md542i0AenFjYuLGzLxjGZkrgKCrXXSQDMrbuUuKHOma8sGgSfEsXS8i LcryjbHWjiLbTQk88+c7guxEBPPoWO0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nnXNUibn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.48 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712347064; a=rsa-sha256; cv=none; b=B0YvKYTEQbsR7od/C4M310ywNYSzN8+QZRL/VbhvCvYH4+O5Uu9qwHlTXI/5wBGnoYExNR /GODJgiIp/m7FVXnmevPNs4gW0n44QpLGI6ZEu6r8mjf1jXXZRMC1DubFQJDP6S+ypux5d Kq4cOjZQVPVnJIAKeSSNj6GZCskBnJA= Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6993bc144a4so7305196d6.0 for ; Fri, 05 Apr 2024 12:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712347064; x=1712951864; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; b=nnXNUibnVD0PRYOK4VK8BrwVyPDwUmZhxG8HNT883gCeDBnQBjBnSJEB19FRn8ZMGK Lqmt0A7bJjFQ0UKVilFYstxTFIdMtU7VEhxiW89BJv0FHwtcKfzF00PInrQSAbTzfA0m tjK5otBTdFNfhMMhI1Ilcl/8K4kQcGXQyhD1d3RcDhc924soixuju/B/ugmby76Xi2XO l9TThDyXFwQs5d+OdEZKEzHrB74LKnsTJoyk/yJLHlJjgQhu3xD6d4cwZrnIzRtCStaz 3l3vf1q6rDWWW52wrtcfXWlpjvR5pGhJJLJAHyYylkh4GKrZU55T6z6M4CjcBrMZmnZd 8yuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712347064; x=1712951864; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; b=v9cYWk6fHQ3Pqi2vFgsJues+yvW0koSXuFX1xYF1ZFaF/C5z+RUNKUcsUUa8cFIKVb b4cgfx4Z6v0fabEFjMN1zx7iYC+58GgJLCPPKYs6BmPdDOsgg93QHt9Us1EovWEClnt+ 1fO2H3XnZNmm0nQ9x6QeDSwxHI8UfUdBZhKkCk4+2oKv5WD9qtIMbIN3icgwXgD7/rJL hxhbUSVxstjT74pVxoUkj3lBeorCuq/cm2bufZIdAKE2gpJUavnG4lM+91n9IfEfpWQY oox5ELsNAtFkfJCLOpzdHliQghXxrgWJH1mauRhPKcB1n8bpoWhpMiQkzqU/THuAvdv2 ZGtA== X-Forwarded-Encrypted: i=1; AJvYcCXIsnJFFmVOewqQppM/nl/0GgVbIp2hv9Pg84XyJa2jSrtsz28DupbkK5iOZH9pNzYV4lh35cSC0VbGOwacCAda9Aw= X-Gm-Message-State: AOJu0YzN/F8hUmNkTpxWDzm+owW+17GAaAP0BfCE9DgcfBg2fKoUwjnU REt7m8Ibm5QbS/fVTHVQi3P/6VKDtjBg5ll7VJMagt5p2zm4n6z3963KTwn9ihkXBUzIHAMjNIe HKxDfu5+Mw8uXlfAdOlH5nUjxCZI= X-Google-Smtp-Source: AGHT+IFvOGEBh46q3rZivlR1LP+lSeeLx2CeRARRGod6UCZzgO9LQrKt7fakn8isiINl08uRWcvtPivkSTlFNiXY2jQ= X-Received: by 2002:a05:6214:246d:b0:699:3f45:44ae with SMTP id im13-20020a056214246d00b006993f4544aemr2973295qvb.6.1712347063962; Fri, 05 Apr 2024 12:57:43 -0700 (PDT) MIME-Version: 1.0 References: <20240405053510.1948982-1-yosryahmed@google.com> <20240405053510.1948982-4-yosryahmed@google.com> In-Reply-To: <20240405053510.1948982-4-yosryahmed@google.com> From: Nhat Pham Date: Fri, 5 Apr 2024 12:57:31 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: zswap: refactor limit checking from zswap_store() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D8B3840020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qf83trm6oinpeknodtqu65rqsfi1r6pn X-HE-Tag: 1712347064-249249 X-HE-Meta: U2FsdGVkX1+l6q2SUZZ+W3+977/ahr1apjAG9UbNHjZPJvag02uJwvD2FbTlAF8amjiDdn7UxiEj4XhOCObM7buEDlw4gEomWC3hLUSZNSjnYZxUft7vrbhrpB51CUE2LG2DokUwkQ0LtAF1T53BZ6aCa1Az9r6J1pUAyXRUIa585FNDwxOnxNnm9DmBUAEfZOTFkYK2qWut5JTPQjZrcUb65DrBq4S7uVGgjwe1vhS9lJaDYnai/+syS3ItFuHiiBFgjDDhmTdamxgCK0EyAVIRp8VjpbMtv2twUIsXMKVhKI81+l9+I/0AjzDwBxpFgij/RETMBwzRMVqlLcKrRasVQ7KDLZbj/7heKd8EG/DYeqce1p5KCePqJknvar1/2VLpbvfBqR3Z+qofGutdlgw0Qpm40EEvwB+tgOFaIybgIrsmi4Zfp0gI3bZd8LJJn+7hk5L0DhWqYPrxumlgDvuw9JHErDUQSYEXXq0PdQgP5bn3A3dWhfdes/sRkDj77Aq7IiISt6iZ8ckrF1W+zMbYw11r1BRnJ9+btbSaDKQtT7TSu3eWfsdh0+HHZ5Wsx0Bt0MdqpM/NNoP0/HGsbTvZfY1zGr+SRNC4zLDKCWoHtj3fNCy+hJvrl5o3W1CBB5EhR6RogXXEWfONwoaxb/J1vviZIbIZcKCSsIYL9IHLgbzxK9WEpu1INS45pduL2V+btwtEyai72whJrMxZlLQeLsFwGevdql+LADw6BtS9nE8m1JIKN4DmujwKkhWX3zC0uR56RJEacNF69wWdDfje5NSSqDkUMQBqJ+FXyOFui3gpcdwZPLuOyjQtIAekT+cgyJDoNLf8xA5HFUJSU9J3WRkU2232OhiJ5tXK/4KJ4W3RALaYlnUjqYoRTUOFT5JHp6+D5V73anlBNIBqfLCAYLJcxXkI4x8OeO6u2u+h82g0qljXwah2P4zNceJI7jvj+ihZDb6ZETvNHNH VsH6hmDD Xz/+yf/dYGsMItcUZYgzSb2K3jnXR/ZmbuwC+ww2y2QBzEVaeYmrY94q5u6n676ilGc1pCJmm+8YiYmTeP3I1TDCbKBIPJf8oKZfVQQgqIZmhopKo71frAWp8dLuG5e1VirhYbEcq1kmlb+sE3q26DLxaYjlPfDVtlwfFZwAfLoU+6p7zGG0JCUSbUcyVBxWJ6JhN5+zp87xUX2HFYYhGiyA2VH/UiJBrSVAYhc30iuIUGxolhnlBx2wOBW/mvUh1S/Zl7IELyYrJk/uAFpXAZx6BOmb3xvzUYk/hBLd+WOUT681kpClCblOiQ8zx11McWoZJcSRq1tiHT1txV3mJY8eBug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.161301, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 4, 2024 at 10:35=E2=80=AFPM Yosry Ahmed = wrote: > > Refactor limit and acceptance threshold checking outside of > zswap_store(). This code will be moved around in a following patch, so > it would be cleaner to move a function call around. > > Signed-off-by: Yosry Ahmed LGTM. Reviewed-by: Nhat Pham