From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCE4CF9C6B for ; Tue, 24 Sep 2024 17:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7126B009E; Tue, 24 Sep 2024 13:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7BF6B00A2; Tue, 24 Sep 2024 13:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B470F6B009F; Tue, 24 Sep 2024 13:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9642F6B0083 for ; Tue, 24 Sep 2024 13:25:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 35BA9140142 for ; Tue, 24 Sep 2024 17:25:22 +0000 (UTC) X-FDA: 82600308084.25.9D8E8C1 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 743D0140003 for ; Tue, 24 Sep 2024 17:25:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="cYvsrwi/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727198632; a=rsa-sha256; cv=none; b=Q60wE4XpRBV6WhvX3S/7CGFHOn48LY42PCGPK3DCKunCw8eZhzxxBUxOCqG/ZMFQmBOD6g aWqLsT/HcrZqX0T98QLzYACK56PSuEj3ptUPQo/JfUGZe+V+aVHXRDnGCE6mv+djsl6MX2 3jGOq3fHdkCsIGZqm5VLaC2WORo74F4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="cYvsrwi/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727198632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8A+G+yD79v8nsi7qfP72GsLdnaN9OlB3PgC0/4siGUw=; b=5WooNdRrLNqGV8QfsHrvQM7bEx+JYRBDMj3dMu43i9RZHCU5lKKGeqntRIEzz26FptoVLj y2MdVO7W0/0RJ6YFKZRukyY9yK6VtzVvd6841LLHQwFi4vFTRAKwfD2HcbAwxCW/t+QaWq tyJ3NcXpzP+tGr68YW1ONHKxBjLgLro= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6c35b545b41so800296d6.1 for ; Tue, 24 Sep 2024 10:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727198719; x=1727803519; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8A+G+yD79v8nsi7qfP72GsLdnaN9OlB3PgC0/4siGUw=; b=cYvsrwi/m6YikbAzu3atkfc7aHk+5CbggamkRrYdhjr+KqG4ZZCS/CwcK4GkjmnR1s Hkyobr5Si3bs+FzbsE4Q56+AFLsbeNKVxrCrodsZE8cFz0ibf0fCht4py4rkaJkrEaqO FkEvOAvlkzFsnem2b4ZOReXUCW/WTVpWW3Ki5S4GgFk6K3jQqDKvDhNXf77k4F/16Meu gFlRFawVAuDr5RjO/bmOWGF6gut4+ft4yMltiJHzE5fU+wsCwUClf0kF4aZpRtVCaTUb VxjOlHabZzQqthrLwrz4dDBu1C4NyfcUJgjFPszJHLkQzKWnYBUmT7On7o7ftOVvulKP Ovvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727198719; x=1727803519; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8A+G+yD79v8nsi7qfP72GsLdnaN9OlB3PgC0/4siGUw=; b=NwmANlPwUASFuuhAIk0RITQhmyrbRHmtRpiSJqlHaTU+WtAZPx7EA+G2nt9MFJv9vB iFORIkqDKj/I3a5t3Kifa5ipR+Gial7rruVR4AksrXOj0gIlE9lcxRCu+z3dDi0QWLVO QgLlg17DhspQF4/8fVolm9seQZhMolhfgUkptqiDrTfHeXtIHzGx7VsKyfpxsIv9Zbkg t6nYZLFfXypxCI4ihuhzEKhpcwIDJALUWXW4jfLKXoB8sF0cS1M+x+CCw0h4yJpeMNum WSYaz50M8a9tR22bnlpVHrQV1EWcLhZosnrf5Qiy2255Ys3Nop6lnot4yvOMXXF5hs3K ScIA== X-Forwarded-Encrypted: i=1; AJvYcCXeI6FPJKdt0DzRRQ/WUv9z6OUQD4/kLBzEz0rkGrQuAoYJLcWS99DxKLwkrrU04T1EC6Wbe6JTSA==@kvack.org X-Gm-Message-State: AOJu0YyXolTPOaM4GGyRMyOLDhWac6pdvbTmyuC77JAx4Vv23Ki/Wn6M Ahm1cXJK+OeY5nfjqi5VYq9H4azLjbM1s0ZHEZLxe6cuyvNtqc+RjwHggsNDew6tVihfHuI+ifY qP8Ivir+aUtzzrONEvSQDnaOWeTogYK/O X-Google-Smtp-Source: AGHT+IH69iGjuU6hz1mmyK9vQnX9dj7R7WIHP9vCiovvkIzF7Vrb4zuyWzd2mctBPKsoMxK/LkeHian/LBZq8OEqNwQ= X-Received: by 2002:a05:6214:3983:b0:6c5:1f00:502f with SMTP id 6a1803df08f44-6ca98b1245amr55744316d6.2.1727198719478; Tue, 24 Sep 2024 10:25:19 -0700 (PDT) MIME-Version: 1.0 References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-5-kanchana.p.sridhar@intel.com> In-Reply-To: <20240924011709.7037-5-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Tue, 24 Sep 2024 10:25:08 -0700 Message-ID: Subject: Re: [PATCH v7 4/8] mm: zswap: Refactor code to delete stored offsets in case of errors. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 743D0140003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s3s8utss549qrjn8dh9fa4xnu6tu3tb1 X-HE-Tag: 1727198720-706484 X-HE-Meta: U2FsdGVkX19Ea4rTErCpSxbloA1nV3gq8Kuezn49TTH7iujnMGiCOxy07uC42QNe8l1LKYUfUD4PIQmDLir1dVjzy34UMfSatZU+63Kp5JoErsvObGds2DVEikVetsiZcL7iNG53SPKFJtq9Dn0/MZLLcu9AqeRyWXB9Bn2KCFM/leywpx3nqhAxM9nTdN+uz5hlXisyDxff0yCndI+CxCsU5iJA/eMwuq4xwJiABaz62IffKD452wN9Hojq8Gw56fenayYgodURtsEd8VVQLGBHfJBmNvkXEDB5vSI7o54F1T63E6D3eud3qeE7LGa/qAB4IdvNyHLM1axTK1KsLkwl4KzM4mfBgcfJQVo/e9UI0JdmsXp0RrboW9fNyhgGsv7f8WlCG99YPnRFH7pLUtwE1+4Ds8BjaaEPxcYx6eIDlDXZruVStNTv1mcfGl4srzeUoXk/S1WUOfiN3WyW6YEpwitEkMMncvXSpGOr1HhPkRW0VMGIffd4N9alOW1AbxAqHU3h4UlVtnCIE94bAv7uNXKNPBE0g9Mqy5yn8nA+B3saqnhTeup19Rj8X95HJ7bD4M1oFDFHakM9GzhgbsGmstTjzOwpQ2CvrsdNcDghyOhIi3965FYxmgzLE6duCbKtcxwRshV70dINEFxaA9apJlkxAGv1S5UsT8y/+i6jzwdC1JDoOYMVLldSZWd31wjo6OK3c6PrLVtJsw3h2oRcFORUkW9knxtHVIKP97ZrpmGgfPhJuben0FGJ+6m2EyYwz4aF4C4NTlQxUuGEgTazQgOxzbXIqCJuc2vyuvFpcSw0hcSa3yYGwKYxPHNyYFXjIWOjO3xxHQgVhzOuRjLxa6Dtgabfb6Y9rClVUBPEDcYhSuiYTgVI/V7NI9T1bUXlLQX6tztzOHM7lDbuw0fhictCsuZLV4nLv8s11snA3GrAoXPFJz5iuEAvTaO18PiTqW1+pQw3yLxnPgg BNyFip0f sOpHia7nPByg6m9wgCwvnLBsnKIRbwC6DFYuca+0d2Y/s1h+p4buvxN67NFRezu0A9Ns1Q1OiETndaMZ9IGhhpEyZ12ewGpnmoPwBOX1qhP7iUIAVllmJYqZqa3mTmMGG8WkmLGIT8eeShC/p4+xIX7837693oIJ1fUDbuJxai31Oy3rLVRF+GMKUpEC+AhSoYzsadV4oCzuhmh+BPPGSTFts7WO/Q5n4/sbobJLzu3Vwz1a0cAsHF+IQ8C5Uu+wMLr8Q7L+65hmb0FD6FkKuXwOL/BIN1AUuIi/o9h8eR1I7aXhn/HGc4DG6wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024 at 6:17=E2=80=AFPM Kanchana P Sridhar wrote: > > Added a new procedure zswap_delete_stored_offsets() that can be > called to delete stored offsets in a folio in case zswap_store() > fails or zswap is disabled. > > Refactored the code in zswap_store() that handles these cases, > to call zswap_delete_stored_offsets(). > > Signed-off-by: Kanchana P Sridhar > --- > mm/zswap.c | 33 ++++++++++++++++++++++++++++++--- > 1 file changed, 30 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index fd35a81b6e36..9bea948d653e 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1435,8 +1435,37 @@ static bool zswap_store_entry(struct xarray *tree, > return true; > } > > +/* > + * If the zswap store fails or zswap is disabled, we must invalidate the > + * possibly stale entries which were previously stored at the offsets > + * corresponding to each page of the folio. Otherwise, writeback could > + * overwrite the new data in the swapfile. > + * > + * This is called after the store of an offset in a large folio has fail= ed. "store of a subpage" rather than "stored of an offset"? > + * All zswap entries in the folio must be deleted. This helps make sure > + * that a swapped-out mTHP is either entirely stored in zswap, or entire= ly > + * not stored in zswap. > + * > + * This is also called if zswap_store() is invoked, but zswap is not ena= bled. > + * All offsets for the folio are deleted from zswap in this case. > + */ > +static void zswap_delete_stored_offsets(struct xarray *tree, > + pgoff_t offset, > + long nr_pages) > +{ > + struct zswap_entry *entry; > + long i; > + > + for (i =3D 0; i < nr_pages; ++i) { > + entry =3D xa_erase(tree, offset + i); > + if (entry) > + zswap_entry_free(entry); > + } > +} > +