From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29783C77B7C for ; Fri, 5 May 2023 19:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9E3D6B007B; Fri, 5 May 2023 15:26:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4E166B007E; Fri, 5 May 2023 15:26:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D266B0080; Fri, 5 May 2023 15:26:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by kanga.kvack.org (Postfix) with ESMTP id 8982A6B007B for ; Fri, 5 May 2023 15:26:53 -0400 (EDT) Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-61b79b97ed8so10702856d6.1 for ; Fri, 05 May 2023 12:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683314813; x=1685906813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7ro+PQryLZOJM5OUIb5r4A2dnLf2HCWRpu2K+aKJJJo=; b=DWcwiRw0jv7cHw3V51vVQEq0ZakL9x0GuKh4qDURNfy/3TyYBFWd+N2L6/LyP6NpnS KejH6RxFkVetxFpTsc8J856/GdDuptEhsoPomIwFZkjxHD2lzt+7x0cby33ry1Qp4hvh GnYfDjt/VDi+KfE5cDZvvz/eCzcH5hkEVspGEWbeEs6MpaDIRxg8jXr8TBUtXhWKzI1X 3YJCP7HaeE+DLk+xX7tj1E1YGZeHgCc7awhxHMf6Jr4Ty4tGehsKlIlrc4bK1Ek4nyhA v9l5jFPynOvuVqupHWRneTyPCVU8E/RTOVc5wusm8iJhbbg/S/rQYuO+VNdREZ06Kh7g oYng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683314813; x=1685906813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ro+PQryLZOJM5OUIb5r4A2dnLf2HCWRpu2K+aKJJJo=; b=MEYsah08VcMkGfzbgq4XMJ8P8G0jvBPp3lDaFguYloIUN47P4LmISyt5iQxBO8j/9M +maC28cPTcDZ8E6cqA/LTD94w0KSYMLVPS+XjYgAY6T+F8DWTQuuWYZLZlpF1LL31LPW fmqaiIcE3guCupYDvss1hAiRKa9riuw+UGIIVOgfdUBTfrrwC0atbkYzXiER1dnWUj9T ZTq5bWUZD3hQYL2D8Bw0dbXi/jzQTbVplyH/OWTB3WNhGINWoi6pK3K4CrIMwGrUrFQQ Llf2mAh2M3AoZeaWIh3knDKNHz4GMEolG4I6VIhXYZc3lp5NCdo3Lm2CRPYRGUt2UBe8 8PXg== X-Gm-Message-State: AC+VfDwlWc8cE2rBOW6cZECXpDs9S+jFnoL680BvvexKKA1u2u2Ng23O uIEqKdGhSotY0rBRa+xMrS7uL7DJuRcoCFCTGIE= X-Google-Smtp-Source: ACHHUZ5z7+damzz+a/zr6hO9NJ48cEoYwtk33Qxx4KIkqzNlagT2sv4Yfwzo+OewEDet0ht2L5b1wUSe/rUGML8dZug= X-Received: by 2002:a05:6214:5007:b0:61b:743c:34f6 with SMTP id jo7-20020a056214500700b0061b743c34f6mr4173404qvb.30.1683314812962; Fri, 05 May 2023 12:26:52 -0700 (PDT) MIME-Version: 1.0 References: <20230505185054.2417128-1-nphamcs@gmail.com> <20230505121401.31826e1251fb8792fe64f675@linux-foundation.org> In-Reply-To: <20230505121401.31826e1251fb8792fe64f675@linux-foundation.org> From: Nhat Pham Date: Fri, 5 May 2023 12:26:42 -0700 Message-ID: Subject: Re: [PATCH] zsmalloc: move LRU update from zs_map_object() to zs_malloc() To: Andrew Morton Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000041, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 5, 2023 at 12:14=E2=80=AFPM Andrew Morton wrote: > > On Fri, 5 May 2023 11:50:54 -0700 Nhat Pham wrote: > > > Under memory pressure, we sometimes observe the following crash: > > > > [ 5694.832838] ------------[ cut here ]------------ > > [ 5694.842093] list_del corruption, ffff888014b6a448->next is LIST_POIS= ON1 (dead000000000100) > > > > ... > > > > Suggested-by: Johannes Weiner > > Acked-by: Johannes Weiner > > Signed-off-by: Nhat Pham > > Am I correct in believing that we should backport this fix into earlier > kernels? > > And that a suitable Fixes: target is 64f768c6b32e ("zsmalloc: add a LRU > to zs_pool to keep track of zspages in LRU order)"? > Hi Andrew, For both questions - yes I believe so too!