From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E09C678DD for ; Thu, 17 Aug 2023 22:59:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C2E094004C; Thu, 17 Aug 2023 18:59:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87306940009; Thu, 17 Aug 2023 18:59:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73A9094004C; Thu, 17 Aug 2023 18:59:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64273940009 for ; Thu, 17 Aug 2023 18:59:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3193DA0257 for ; Thu, 17 Aug 2023 22:59:05 +0000 (UTC) X-FDA: 81135113850.16.0516C7C Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 72C084000D for ; Thu, 17 Aug 2023 22:59:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QQNwAhE6; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692313143; a=rsa-sha256; cv=none; b=wm/t3CI+25UNq2PQ2vIGu0ft3SixVITVsNcUoiT7Zu8LqnhNHZZw2+BHaP1KTukRrhs/Ra 86umpahSzywD9mxdn7DrHXjuo1WXlniF2stnBy6bBA53vCI0OQiXnlAqej7vf09nmr/Fa2 wQ1NNFjxVpK1e0hhrFf2L5Cmy7IuCHM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QQNwAhE6; spf=pass (imf07.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692313143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KniUMBT92oZj7fT7qN2uycdi3niZNLdHXUNCqhPvRlk=; b=5lTehER+FXGZ9kixrz/bp931Wx64KkFSRMgYQBqXKECQBfT07tniW/TWlJYNxqb3x4WprR 3XE5enNpHEfw8/dcf+AiV2u4Vxr35soJi/+fJRqyx+qyN/aPn7PpSFkpiayXxWHjHeM3Ap 2tK6ClzlfhoDk8/CHePbv7UC4Q6OJ7Q= Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3a80e665410so200998b6e.2 for ; Thu, 17 Aug 2023 15:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692313142; x=1692917942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KniUMBT92oZj7fT7qN2uycdi3niZNLdHXUNCqhPvRlk=; b=QQNwAhE6sKDuBXAq7EhdG3MCIDWA3/tW99j3+kMGoV/2qtQPpdh2H+uHfFBs1EOt2J i4iNSlm0Ki9maktnZlXC+VAIOg7Nld3zjzZcoLtMMx7mYsPqMtgJnIHM/UkvOb5iRRm/ E6d6jJXmADcaEXi9Vkic2RgKMKrojJBIXVHnZQL92uwo8WEPkMLj5b3MmN+JJ19XgY6O DWZdjV7UFHo4Ejzt74IFF5rnN2X9YJJr9rQgRwASqHs/Izchq4GmCZsHETM2abgegU/H dfNZIvmMtRMzM3ZyHo7FSZxshJ3fDZeoluqv8jhbFvqQc7XehJ2smnbRH7si5gM95Yea /pJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692313142; x=1692917942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KniUMBT92oZj7fT7qN2uycdi3niZNLdHXUNCqhPvRlk=; b=Ai8rmhDEPRogKW2XlZdgEfJ8E8Gy1Ywz4U/M1JK1M/sBo64ue6Apy84LKuN0q2PxtT zc7WeXFqyZmzKZ7uktlP+wxlbGIM6KQYe+LG7TqgohUaZWFwYwKmvhSZBLhXpN7olkRe OMb9Yi3ImJxiUEHyE+smNOus1lS1gIdJO/uy8sVfO1W5eUFMknjmIcsu7y3ge4cbRudR NZ1ThGrNokBbMo2ce8qcyocjIJyUtIvChTg8VwvHQzz1AyEepHrT2mlZKw2xIS9RPtFD K3nglv1h1H92LBFJNanJ8OAxeGZNFjtg07LZgTvnjPalZNZpfFLUERY1hVvFbbX3O/n+ k95g== X-Gm-Message-State: AOJu0Yy1SzI8nNsVGPaDvte2F/N2aL92UekV7Bd594R7eeb+NCp5Uo91 cOrDtUF42TFWlgjlgzmLVNkvguTRU/fjnga5F4aFOGcbh/M= X-Google-Smtp-Source: AGHT+IFrBUPMu/bPjCTy+xRSKHysaPfQKY0KCqe9PXdSdMkcjklXThV1Jf/d7XkKBXEg3JtIvR12bKnmufWSexGYTTY= X-Received: by 2002:a92:c0d1:0:b0:349:8dfa:ad64 with SMTP id t17-20020a92c0d1000000b003498dfaad64mr1082542ilf.15.1692312815736; Thu, 17 Aug 2023 15:53:35 -0700 (PDT) MIME-Version: 1.0 References: <20230620194644.3142384-1-yosryahmed@google.com> <20230811141920.2f9bab6f21ab635ff1bd63ac@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Thu, 17 Aug 2023 15:53:24 -0700 Message-ID: Subject: Re: [PATCH v3] mm: zswap: multiple zpools support To: Yosry Ahmed Cc: Andrew Morton , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Johannes Weiner , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 72C084000D X-Stat-Signature: btzgdzf35u8k54hk9kp1a6zp4y1rz3y6 X-Rspam-User: X-HE-Tag: 1692313143-439346 X-HE-Meta: U2FsdGVkX19dWBrk4DYTJwwyUzsh12/S8MlPySFbMSAB2+ap5dDyFt1WAjKBtCSO9QWrpOzHIrfvall2YvOtAw1quupuruVLMI87uStZH9fMOW9ev2iegHvLvjRz/AW5DeflUYt13jNwlnYh0znRH/9nRpN0OO+os44rto0pCem0I7OBf+YX7f/Fq41xRBQxwSQrQSjm+hNedvjv1LwXKv2NsY3DdTMhsFIsGwgVUA5+vRJZg9PDb4yWR3M1jglHpDvtBowcx/bY68linfE9L3cfTLAFH136KfMy6AqNpkhTojzRw98lCTCMv0HfOTSmJop1uquOrvfwzX2+NIEvBhsy60DKOn6rF4U2cfPItDYFkCtlB/zrt55wVBiDpLP6fv3X+xtpL9IQCykplrejyRjf/3NhtZn4en3YkcubhtpytePS6th+63FQaDwqfNl7+vkv83hRZoNC5kxoWpZ2eM8g4dXyXlU0xtU8xoXAU3Z5Ep1TKpXV5mGt6Vr6BdGJFNyei7Ff1e5FC60CyQncy/C9LIMfJ8+snsunuxrl+hi+f7iRXYNkPecq3sFxYwY8sHSWtTfobtWYDUDhOP6CS07QZWxyfFllz5Qu9bEkC0BDHODI/tXw2et2RQ4qtdY6byHe3lfyUZ/5gMmI2YvIydXJaJytrTLxrEXJEtOcas9t/pMGkM4975Zz0FjzsqB9+YFXAL/jQMQKuAUL/GQihjp+IlNnoc+UR/0d7XekTvUdz6spHjkJyljpqCXj+bo/+Hf+6t2QjSmWflKtB8HJnzCfBteWQRv8YBfmBXyTo+TdZ0mqAScveyoyDKQLbYNtAZ2Ts6TLSHdznXXUmBpPmGDrl69/GvsGhYepYEB1VwbYTvnKDglOyqfef3pAowKA4TcSFBsiHZ7yJjbf8MQ8AsL7ZIEe/oVR9xkceN7zvbgwF7MmzR1jqO2k9MqGVbYJmAItpnpLEYG72l9I9KF RaNtp2Oj jJ1EL1bCA1tF6pHSu0dSSIGDN3X3R4KVmBy0wnQj/+PqvsAKi5KxwNBd8aw4e3KYX7Xa017Ax0Y0jqeYHY37rprWlRFGaxFPsRXXRUe12QTxN3QVBV7HuhEsyx55mHLeV7uMndsZOCSQD7BqZj1+Ad4aFm5RB5cmkX+f/ukZBV8oK9+dPxxbu7e/Iw4BkDq8jJz/6gGQ6RgZ3bYkBScdi9iS5ezb9NGZNDHAj4K0SpXikLm7Rmc1oEayEB3ziT0rv14lJa5/Y6Qq5bzhu9xVlAf/143/JJPj2NB5u8H7hQd5D3SQwicLDzh9esRjytmXwjDbu0XnGskon1h7ceN21rlKP+CSFp3PaCoCsWVm9NStMtJoKScOEyCPsw2NwH5edGoGBpzydEimMI+FUfDot7Dvdp7Nz5OkS+rkhqZcb4ISpwjc0i+qfdDdlb7suVlVrnexege7StB6OIY4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 4:21=E2=80=AFPM Yosry Ahmed = wrote: > > On Fri, Aug 11, 2023 at 2:19=E2=80=AFPM Andrew Morton wrote: > > > > On Thu, 13 Jul 2023 03:35:25 -0700 Yosry Ahmed = wrote: > > > > > > > > > > I'm experimenting with some other zswap changes - if I have > > > > extra cycles and resources I'll try to apply this patch and see how= the > > > > numbers play out. > > > > > > That would be amazing. Looking forward to any numbers you can dig :) > > > > So this patch seems stuck. I can keep it in mm.git until the fog > > clears, but would prefer not to. Can we please revisit and decide on a > > way forward? > > Johannes did not like a config option so I proposed it here as a > constant (like SWAP_CLUSTER_MAX and others we have). This is a value > that we have been using in our data centers for almost a decade, so it > has seen a ton of testing. I was hoping Johannes would get time to > take a look, or Nhat would get time to test it out, but neither of > these things happen. Apologies - finally have some time + freed experiment machine cycles to put in your patch :P And gotta wait a couple of days to obtain sufficien= t data. Result is quite unexciting - no tremendous gains or significant regression in a bunch of internal metrics I was observing. Of course, it's just one particular workload that I tested on - there could be regression/gains in other workloads (or other metrics). But we can always revisit this when it happens :) With all that said, the code itself looks solid. And while I'm still not in love with the change, I don't have any further objections, as of now. I'll let you (and Johannes) continue from here. Reviewed-by: Nhat Pham Tested-by: Nhat Pham > > I obviously want it to be merged, but hopefully someone will chime in her= e :)