From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9121C46CD2 for ; Wed, 27 Dec 2023 23:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FFBB8D0002; Wed, 27 Dec 2023 18:22:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AF378D0001; Wed, 27 Dec 2023 18:22:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477168D0002; Wed, 27 Dec 2023 18:22:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3594B8D0001 for ; Wed, 27 Dec 2023 18:22:00 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBCAB806B2 for ; Wed, 27 Dec 2023 23:21:59 +0000 (UTC) X-FDA: 81614173158.26.183CCB1 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 40A23C000E for ; Wed, 27 Dec 2023 23:21:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ft942faz; spf=pass (imf10.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703719317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=swUUhVhGR84IN8e7Uhazo2gmUEhU/6ZIWjlBrcgxqH4=; b=aMObryY0sBO2IS0vIFpewibE7c95yD5u1ygSPKPU/hAJ0qIlSYdVoRkIYTExZhGIzNUvnr oVg/PNnYASgJ8+iXGjnOTuDkeSDG6NTKkY6ZSD3JeLA2JPZws+Cd38gTtoTUbkChoYThU/ vLnlo98CVY44aeQgyz8S64FPlIwt0K8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ft942faz; spf=pass (imf10.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703719317; a=rsa-sha256; cv=none; b=ka7uXOQRtSo4eoooJBCPUKuPQjaH7R1Lc8fLb7CdZlmapJlDS9Cbn3M76e/XKvkCigYanv KYgGW0V43ToCwCpd2mOCcBB9OhfP1BcgZus5veUIjJcC1z5mFHT4gcG6C++0M9OyJS/MT5 v/a+WdMSl0F0qu5v8G+6JNZg4Uexplg= Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-7b7fdde8b54so290695039f.1 for ; Wed, 27 Dec 2023 15:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703719316; x=1704324116; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=swUUhVhGR84IN8e7Uhazo2gmUEhU/6ZIWjlBrcgxqH4=; b=ft942fazKzi1+/d3HAl5o7EaiK3+BFlREx3BL/CVThcloF6Afm94iuVyj5ypvbbLYX 3WjeH9NMSELk3CGzrVqxhoNY8oXIkypGVptWIGqJBKrG+SBp3Rs7RI4R2oRdP5L8c5Wa P11xX/RZZea3iVnTqRI3+gHWwhrg1XTMgHOuca7v+TS82P+Kq5VXG6Le2KEC0Shu2d7o CvVGfO/CvRtvW6IAEd+vnAWHDuznoFGL2FZOdfnSzjDYH8VkXF0OB2zhqQOjDyaSV9Ew 9Megf5NlR0OfHfFNUJCeY2z5U8NUIEECSG8ngQKoqlJX3chQwGbHL5sZb9BgzPFvF8XK uFFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703719316; x=1704324116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=swUUhVhGR84IN8e7Uhazo2gmUEhU/6ZIWjlBrcgxqH4=; b=C1HxUGu16x6oSEUw449uPacOXuNCUdi6yJAPbj+z2CRSOm4oraIEgvhTsA2YpWan0c rPI7ilqnPd0CVgbioUHKnaGYgI8SFQ2hSg3rveMKmoyUwrhKqvLXphIAPGOebLuTLBYu 6VJh2edQQM6nKFMA0LLXzw+P1cc+2Hfev0tVI6BJdSn1yMNdC9mv13qum9woNUmrMsZN bgbrx9O7jSd/nbtz9j+B2W8tnkV52Pqf0xM0w9LhyU3DERXR8mCX4wuSGg9e+Oib8y61 1ep4kRndYgRw1K06ZlBwEomTQS0mUlXPaP8ODSRdRUc9UaQHFrSY9eeqqSxAtmjxNena vYdA== X-Gm-Message-State: AOJu0YxiXVSoTK+lTwlu1YOTuA3XRt1bz5mD01B9hqz2jE8/5qXOJOn7 hpTvmfsrUay32RncbhuKYwz8MmwCAtLCWoMfMoY= X-Google-Smtp-Source: AGHT+IHVYxypehbwk3MNttN5Sm11IW2Tbt1AEIEuT66pXQpHxhPI6Juwt18rpONw4KzLliPKQperlMc4LM53mS4RSbI= X-Received: by 2002:a6b:4f04:0:b0:7b7:ae3:442 with SMTP id d4-20020a6b4f04000000b007b70ae30442mr13877651iob.10.1703719316273; Wed, 27 Dec 2023 15:21:56 -0800 (PST) MIME-Version: 1.0 References: <20231213-zswap-dstmem-v4-0-f228b059dd89@bytedance.com> <20231213-zswap-dstmem-v4-1-f228b059dd89@bytedance.com> <20231227125853.2dd07cd61f8a8df95042677c@linux-foundation.org> In-Reply-To: <20231227125853.2dd07cd61f8a8df95042677c@linux-foundation.org> From: Nhat Pham Date: Wed, 27 Dec 2023 15:21:45 -0800 Message-ID: Subject: Re: [PATCH v4 1/6] mm/zswap: change dstmem size to one page To: Andrew Morton Cc: Chengming Zhou , Barry Song <21cnbao@gmail.com>, Seth Jennings , Johannes Weiner , Vitaly Wool , Chris Li , Yosry Ahmed , Dan Streetman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chris Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 40A23C000E X-Rspam-User: X-Stat-Signature: dihz8gn11o54ybjpy6despewiaun48ta X-Rspamd-Server: rspam01 X-HE-Tag: 1703719317-978001 X-HE-Meta: U2FsdGVkX19GymZuASYWsUsNMFLD4bl1KMMqgUWSfvfUz9vAAEfYBMXn6au2xtcb/C89NTAaxauDMe0+4g+0ikMpVJUbC97oKSANHcWcMOMLnS7t4GyYHlhIW1gNPwP3IqZWWnzYeDqPLRfCJAi23oAfPId8K0gMWqADeMNH/qVwC7f2v1W8yqJrOOlY1Usb/IU9/ryPR5uN9IBkxllPwvxHZDdn++lF5WQxapaOXZK0GOQ/3kh9QtOxn4CofDAg5CZKcI1wLX3LQ3dDXJP5e0k2FzXmEv1oZ/99ku7+Qhoj+0d355uXoqDdWeFdGmXZiPkJI6EO1LRDnw3zHqXxJRaSx3u5/Ri3yYxg6BOobLRrAEGM8fjOmLZIePhBh0eFroHMbtxsswZC4KCJjjT+Dbd9IyCYsGGfPPMzuHIfd3pxmQRlKNhvNy710AZTcXRY94fGWeHqw7rWyMmJJTUjbGrZfTNn7/clkwrXTpr87WFX2S+vyoKXHBDllX5iq5VMWqelafdjZOlXPcOQ29uAFBb1wf9mCt2cWyKQT5utfNvu2dT3UbDcFXmU26JZlMCKF7LTIkV8Kq/h1MVWr+0lIF+AQQt78Z6EqGbVICfQ5DGWD4c2fU8VgtBcMZxknapN9x+z5kpkmiQ/5EwssWnsk3/wES6U4106VQvTLGfLc5pcMoCDFLBqEAHNI3weM89xvc0F5bT5udHiBti3/MRcsGKmKMH58JRi6oCsn3iazn5WBdAPHs4BTzt1WORtu47g8jlmiGwFYJHoopfuZArql/PrK06vh5C54niGvBr42lStaJYqCKr86bGtNuKGNPTu/jy0tKV/2yxacVooHUSi/d9MX+KSREHZ+pRLeJ+NZju9LnhuylhBXZ8I5Lj9ioFU4oAZDYXL2tqP62j+F94g54GrM8M/orbQyfqJsxkXyuQEz9p2hem1EZIf/0lzk4LTXKUsnfojZBpO4mYaXM3 HqC/ye9Q 3cZhisMFPHEj31ySknh/Y4aHBXawwhycOpbUOE48io2+FC/NPsg3LL3dOykcOOCWMUoYQEu4GklRzK3rwJ3SPslkVCKB380dTGiwryq81ko1Vc7RkCfj4Tkk/X1hiPuwK28K1zt/0+oVh4hEzA74QliMlgpoxIh5xiptlZiNssJa0L2ksG0ie7rpiTK5FvxaydaOG5WfGtNs1+lnYgPNcmNlSEwz/rUrbl81+/0RxV9t0DE9r63OOcUJfqSIkceSHJohfb7vVWUuy/ezr/OvBE/otpxsS1eZnUbNGec3Xm7IIMw+ep4gs4Ri5QQlovdz5vIOUathu/T/moK2L4xJ22Iv2K7aHWu1DbejAeJxyeqfUN9jw1J/w5bkyZajMbmwF04nBFShZg7cBv983+rJq6tsUL7qlTIOQ1+Zb6++Ma/AUGzHhXpAZG+0Ddwk6nWOYF5fVZdLOGH1SU94= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000100, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 27, 2023 at 12:58=E2=80=AFPM Andrew Morton wrote: > > On Wed, 27 Dec 2023 14:11:06 +0800 Chengming Zhou wrote: > > > > i remember there was an over-compression case, that means the compre= ssed > > > data can be bigger than the source data. the similar thing is also do= ne in zram > > > drivers/block/zram/zcomp.c > > > > Right, there is a buffer overflow report[1] that I just +to you. > > What does "[1]" refer to? Is there a bug report about this series? I think Chengming was referring to this: https://lore.kernel.org/lkml/0000000000000b05cd060d6b5511@google.com/ Syzkaller/syzbot found an edge case where the page's "compressed" form was larger than one page, which tripped up the compression code (since we reduced the compression buffer size to 1 page here).