From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57630CCFA07 for ; Thu, 26 Sep 2024 22:50:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E68E96B00A5; Thu, 26 Sep 2024 18:50:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19EE6B00A6; Thu, 26 Sep 2024 18:50:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D083E6B00A7; Thu, 26 Sep 2024 18:50:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B14966B00A5 for ; Thu, 26 Sep 2024 18:50:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 64E9312063C for ; Thu, 26 Sep 2024 22:50:22 +0000 (UTC) X-FDA: 82608384684.04.AFD66D2 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf30.hostedemail.com (Postfix) with ESMTP id A54F180008 for ; Thu, 26 Sep 2024 22:50:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lhei8a3q; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727390959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5QMfdq3/Pvsbt60PVJC9Jtm6nQiaNCIJWpvSDaqQirY=; b=hWx67BOs9ZErfVODiFq3GrquF8qEn93VbvEWrOmDE2rLmNGnK2AcDE7N8SWEu3U6WvAWUH s7Np7MAFYqxXYYDPVrXaboPH0elt7mGF50JfmfJuBzyUleR7sEjqEGEU2xQBuq3TuM+Ph9 gNPhVUHBVimYn8YXdydBW2gyG+rE6aQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lhei8a3q; spf=pass (imf30.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727390959; a=rsa-sha256; cv=none; b=mRPb2u/0K3fl3e7TGxNfVqCiZwdyoZLR3Bn5MJKOwQCXGR6FC7skZF3bVn5DiQhEJuet0q WonSNlpASIhdYJ4DC0N/4RWzzKq8pJLbflTSWlp+h3xLGftuvUg7sjhQmV2lP4dVzwc9vL NYTvFQUTy/yo5ZvJGOxck20cyTZ5JkY= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6cb2a6d3144so7851196d6.2 for ; Thu, 26 Sep 2024 15:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727391020; x=1727995820; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5QMfdq3/Pvsbt60PVJC9Jtm6nQiaNCIJWpvSDaqQirY=; b=lhei8a3qTrRyVayFJPki/W15VWpH2d6DMz6RIa/Z5rC99u0GyTUKSiZF4os1ZnFnQ4 /mxqI0mHaRU5SJS8JvzKNDmehPCAxJV2ZQynN6GLZsN7tR+++ln9EvwL6PrELj9SuDcp DkA6KCH07PKjdIp5RKg4n/hNFPB549VgMRCLy0CC4JzfCuSB8XMOq4hDUWIB8eCvVljp PPRd0lwCHQvy/WU5lnfIubxXJyslws1jEvsBffHJ3vj2kyUQUbN42OwA196W+XJumwU2 K3E59RNnm3cuJBackBH6c1Et97zVNHQLPoUuLYM6oLXn01S1yUKp6FdS/8Z6ZNhzaWk7 cs4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727391020; x=1727995820; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5QMfdq3/Pvsbt60PVJC9Jtm6nQiaNCIJWpvSDaqQirY=; b=PYzztN6rtOi/cHdCxZP0T07PZOUx7xJ+++ewj5XM6YNDFJJoxV4U8CrhZ3P0pkNjwO 6GCd8XmkpL9gm3IonDIu/FlDYoU/h78tlVOSjLcfcGJBPz5GkACoU/uyZRDFPSoJe/+A dmJiXD88rUKfBYhGJg8ro5K2C7AmToopXyE9G10gxYPfNFYtTsZJrElSCs2+uShVLPeg FsCuIWDi5pBqfc2tauWRuGTm5OC7tBrj7KxAPyEhhxgTiXNaIoyzFyjSlAPOf0tBuRyD Ym3UmgC+95NrsRWlyTY7xV6bLBaB+3gpdeRw7lUFwwkPO6gN4pY2Gaz+2s8A6lWQsUjf nccQ== X-Forwarded-Encrypted: i=1; AJvYcCUrx7u9azYB4VFyVQ0Z5AQT+9iir9a4bE+Fv+x6pZL8dmAyhsq7YzbycmcU0tTP9WW1E34pN7DnbQ==@kvack.org X-Gm-Message-State: AOJu0Yz14DxPE0MPnpU1KycxniAX0IfgMAhV7rALjU0/9yPZUDljj20W 23r1G60zxgbHWOUn3SkNLbDOXp8vHMFQRMZgS5+8pjUXmyTdw/aj5FMfBwDeBUenSQrHqhpU2Az MQOdpcfNUSmhzoTqpBuYN4ci/kRY= X-Google-Smtp-Source: AGHT+IGzX/x5c/SyLBqexGC/TEAZkqdoPqG1WhTIJsQ26Gck4xATCL54AtMI8ZHwRwVJ45Nq85nEZ9BaflbU8P1Mxxc= X-Received: by 2002:a05:6214:5549:b0:6cb:2ab7:56df with SMTP id 6a1803df08f44-6cb3b64deccmr18195796d6.49.1727391019651; Thu, 26 Sep 2024 15:50:19 -0700 (PDT) MIME-Version: 1.0 References: <20240923231142.4155415-1-nphamcs@gmail.com> <4d38c65d-760c-43a5-bb47-8e0235c13a51@linux.alibaba.com> <9a110f20-42ad-468b-96c6-683e162452a9@linux.alibaba.com> <85a2fd61-93d3-4cd9-95a3-e9eaef87286b@linux.alibaba.com> In-Reply-To: From: Nhat Pham Date: Thu, 26 Sep 2024 15:50:08 -0700 Message-ID: Subject: Re: [RFC PATCH 0/2] remove SWAP_MAP_SHMEM To: Barry Song Cc: Baolin Wang , Yosry Ahmed , akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, chrisl@kernel.org, david@redhat.com, kasong@tencent.com, willy@infradead.org, viro@zeniv.linux.org.uk, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A54F180008 X-Stat-Signature: jzy7oi4wgmkysutkembpg5iigd4uya1c X-HE-Tag: 1727391020-850326 X-HE-Meta: U2FsdGVkX19o7UaXMNahmcaz4VAlh7yv9uGtPH08Eyxvt8rz8ARe7yBl8RVwozXT3EKYB6mHWxt/8PIfFDBjp3maYvHjO/cUZtMnD60jtTzeho8S78a1P83QB7asxCzO+UY85QnxF9fkVzwETvHCn1hYGZHk9VwTySa5xhZAQnx0mwbVO2S5Ne/gPLAKC/9l7zhLqWonRs9mYB3HYWmRMBTcAfPrgzCQDafj2JedFAKiIBGuP+TGmzAblAuQr3q9lOGYfwxHxgN7NAWidxS2ZkkHkeUV86JL9Vbe1WTAZz7ylynKETG7xTRhXXVu0oPbB8anXh0Giw92uQtnq7ofJfnpJJfPvsqMjyOp5Q7oy452hXhhEMv44tT8rizOzNeK0vNScrr+pgdJ0LDWU6B1ncNe7XdiWzScM8nlUuPfSrhqV3LSwN+EBuGVORPZgtwMd8LaoN2VpAZdRO1xJZ+jy0LY/cTx7C0RHbZqEPT3Y/2mDhzD8eMB58Oz+bc0FuKCXP3CVIuFy++cEhfjJ5tJZka1uko/Ar17K8nd5dybaKHFhLSNB/1pkx/T+DIox5cwWstbNVmD2XenIULuSOZGeXzii6KWdCdej/OLCI0ZzEKiBpbJmQdlIDv+cpSPT9gk/7VzfzDv6xyTJKjR/IsVBZNyaILxG0w1YKbB0RgZwLT7VfErZmtN+q+TTEFpPm4Sju8E+8yo1TQgDRSkvd+UKq232g1tWHrL7AMHw+2UJpVGAZ5PL5mg6QdHV3s9/+pYeW7fMWBIfsB6WRpn468aXnisrm6hPOB4bq0mLfKvLfXvE8bIBAciZXhCDzaCBlO8r8s1Mv6fKZqWlHYd/iGSikUQtI1KbHkYvg0d4LhpSPuVu75vrOpSTsX6BeL/Uz080vgAj2dItEILllVA85rq5iYTHdXIbeawlJE656TBxbh2ejG/cFf5lj/EexoUGaNYajW0L9DY5ULsBvQ0Y2c BzXpH1Qu eaM+tziRigDpml6SlujEOefDkoF1UtcC7/vYf+BVXuul0Hm4J2pA0++Oaeqa13m3qQRhxCM2giyZfVcjsrBHggvU08j/a43QqRtMWHGCvOIU9izgK3GE71CjEAzfm0RbVFeaCkPiBJwx3GVSLRZpKJJcnivTlqlZ9oiiJ1RODUiebPtkXht3bY+Xm6sMYa4ITrIGMjer7a8B2blYSE069Q4kgLTrkJvuvmhf0SeI0DzVOfhA+sT9m16W7l0IXP1C6lLtwbbtS6VtVNCKCpiR1JDM71wb95ie0mcILmus5uZrMmpXa5Abrd+WOPY0Dxd3Lb+UKHuVcG+1TUOFG1rT9V0JO2GSoWw4n8VXcf8UGRTacLNMIuEvSmLpGqNhNGWWIylUvaNAAi/D+UH3EXp2bRUkmSJSCAuoempzq X-Bogosity: Ham, tests=bogofilter, spamicity=0.010052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 8:59=E2=80=AFPM Barry Song wrot= e: > > On Thu, Sep 26, 2024 at 2:37=E2=80=AFAM Nhat Pham wro= te: > > I=E2=80=99m not entirely clear on your point. If your proposal is to supp= ort the > case where usage =3D=3D 1 and nr > 1 only when we don=E2=80=99t require > CONTINUED, and to issue a warning once we determine that > CONTINUED is needed, then I=E2=80=99m completely on board with that > approach. > > It seems that your intention is to simply relocate the existing warning > to the scenario where CONTINUED is actually required, rather than > maintaining a warning for the case where usage =3D=3D 1 and nr > 1 at > all times? Ohhh yeah we definitely agreed on intentions, but I think I misunderstood your request :) The code below was an attempt to satisfy that request... Please ignore it. I'll submit an actual patch taking into account our discussions :) Hopefully I won't forget to actually test with thp swaps this time... > > I wasn't actually suggesting a rollback as you posted: > err =3D __swap_duplicate(entry, 1, nr); > if (err =3D=3D -ENOMEM) { > /* fallback to non-batched version */ > for (i =3D 0; i < nr; i++) { > cur_entry =3D (swp_entry_t){entry.val + i}; > if (swap_duplicate(cur_entry)) { > /* rollback */ > while (--i >=3D 0) { > cur_entry =3D (swp_entry_t){entry.val + i}; > swap_free(cur_entry); > } >