From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1894FC46CD2 for ; Tue, 30 Jan 2024 09:12:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3C436B00AE; Tue, 30 Jan 2024 04:12:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ECCD6B00AF; Tue, 30 Jan 2024 04:12:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B41C6B00B0; Tue, 30 Jan 2024 04:12:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 799EF6B00AE for ; Tue, 30 Jan 2024 04:12:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E6FB516040F for ; Tue, 30 Jan 2024 09:12:12 +0000 (UTC) X-FDA: 81735410904.02.F78FCCD Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf02.hostedemail.com (Postfix) with ESMTP id 2D7C380018 for ; Tue, 30 Jan 2024 09:12:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=esqQS4K1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706605930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wnbgnwm8mX0qqmyFdPhMbkalXQKPaabeF8Z9Wu1HI/4=; b=fF9IQ4y2vhVxeOO5CDRr7IyAeLDgHoAI4s8YglXfw3DxfyIeCQkEIg86DZaecSMog3PqoV DoqUqnBuj+w3xsrV+VFVgxfu3tDAGgA6K0Pc+p68EwG5CR0r87jKRwi7naNnD7xqdlDPCa jRvCriLdAUlxHAbKzox9pN1ssFeQK9A= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=esqQS4K1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706605930; a=rsa-sha256; cv=none; b=rPkSWQbwAjkiEGcUP0sqoLooS+PJVzsfNeIaLdsqbaDZUNmXV+0Z+v63uobENQ5rCuqwUV yYHh8Vm5URrQWWHQPWDU78DFptBz5gXNMnW9WJlyB3w7Irel1hjc2pvl03QxZE/PG4/RNZ 27S3gLDilpV6pH9zIWziWG0+QVdVCXo= Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7bf0f3bf331so144070739f.3 for ; Tue, 30 Jan 2024 01:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706605929; x=1707210729; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wnbgnwm8mX0qqmyFdPhMbkalXQKPaabeF8Z9Wu1HI/4=; b=esqQS4K1adu+melFEaKWbok+xJ2091GCf0CJ3wc5vvygrABz7O8CkaQzSDPIgrcbo1 c2wK/8KRXk2hUsT+7SxDAB2+s/nnDBBDjFu5urUe1HW5IEfL9OFVRIQ/IalPJ7Bhy7xa jjnsJwJa8h87MnMvJ5TMNPSC52TYnY65SfIqYT2Dt3L0LIiR4z6pIc7n/wFjsl38BDHY QVq8xBhGpHO7QY9G2faPYeZnSpTaO4ATAC7acb12JNDpHdzZcw8KZGpTQf6nnRnaP3up jBrvGWicqrl+gX6+mG6gX5hY39J+hy5aXv2dM4AEMWoc5f4q6H1u+B3XeXW+DCGQUY6A JXpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706605929; x=1707210729; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wnbgnwm8mX0qqmyFdPhMbkalXQKPaabeF8Z9Wu1HI/4=; b=CRawwlOPypnwNw3htGKhCzKLF+TYBCC+wan0BIxkwzcAx6FQkL8wOYrOJn05XJwZgz 9u9tGfMFd85kbwDNEVUXaoI3BQssyBFBZR24NrDYEEPLsV9r4i5or05r88sO2jSg7jZK 9/0qSxzHmlrYx5w5zarXb91qn1J7QqM2ZVavHEqaHBia+n22VPA8C3wbzS+oi+80nN77 G3xrqxO5CEdx4F5sBgmPgJkBpt9K7G5MM+Ui5dM4fWfWxk/0J0IHfrzSeECpXOl5iju1 ylVqsCiwXFiQxg8ATOTWaTZJ+5YxPPLYCK3gk4L9wPYA+J0q1kJLp2OT+F9anuekB7Jg ZVgQ== X-Gm-Message-State: AOJu0YwN0enwPDQ+TgQosO+S7rnV1LenXy9TxeTxOAenvcIPxCppT+zz 5XJSKspDZ9D+t2pAeW/P6uu6PJKPMhz5LCRdxqbseBk3nhIPte5UgPc9Jpo4NLlv3FCvQAPKRIx YR9afaAJM0K7cZc3Ig0R/0nCNUUU= X-Google-Smtp-Source: AGHT+IGSqOqPVind6OqnxzJZZaJI3aTGoi16WEMWn2uwjgvCzSlAT9qvLAwCLqQKFmhSa7LYAzgKAM+8cOvA2cbx3uc= X-Received: by 2002:a05:6602:29b2:b0:7bf:fa4a:990f with SMTP id u18-20020a05660229b200b007bffa4a990fmr4054925ios.10.1706605929213; Tue, 30 Jan 2024 01:12:09 -0800 (PST) MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-2-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-2-hannes@cmpxchg.org> From: Nhat Pham Date: Tue, 30 Jan 2024 01:11:58 -0800 Message-ID: Subject: Re: [PATCH 01/20] mm: zswap: rename zswap_free_entry to zswap_entry_free To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2D7C380018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: n76pgr9sbbf36j4o4pnhkgmwiet4mc6e X-HE-Tag: 1706605930-296578 X-HE-Meta: U2FsdGVkX1/m3E6kpQ0TA8ADT5oFkuo/+/Ok19PdynkAVrYsb/AtP88vbepCh8dqGb93Cnu7Js+aQHyYBQJlqVXatWARcwqGkmL7m4fim2/56WwWDfUfNlKLSUWkS7YLiwlwgdp9vYbfCsBMA+qZwybJQreHxi9GrBKH7dbpjYWT91PrcEuSu8kzVlyvjhzs8T5zRqueGJseAMVkxVnbU+8kmD3QaXoQ6rhbfhOGQ6wnbRL05UU1Is+e/J5qAjR/sA30oPtxyVKHjAVO42OuOsLVJPQ/zJy6m6Zvu8uTI4kFiQtDLMnpENfeR0HNzpo034gI+u/Hmhr+bp8++FyxbKkkprBJl+JCWT8+Bg2TxmAA8UjovNKr+L7OK+XrTzCE298umPdKqXbFWbnKIOp4mU1xUa+F9LDbAQ+52Rdpaxj1DNr7ltyJ7an5fGtMYwAWInVrxOPncLwqq/75d/buqZl0asOsQNGFrVOOUM35lLsZtIedhbzd6KrWAnvSIqx1PiPd47j3aS5noFOYCxrQlGnaeYamF9MMuW0G0NNAHFIxWMBga7HT9ahYsOSLEEr2e+gNEcIwsXbEDdFRIP9AnddPwomPrfwYmxb95t8MyotinU+SdFwDf3WhB1DSPeiSUMnyHn3R51DhX+6+osW5NTrBT2XLiPyo/PlDNn4/ILFq7Zr0k2KQ3Nlja6uQpxmwfaFjgMFn4s7DEuLzFyy6rAbUwo6ysjd3lfWLDm1DNIxIIu6HdM+sxH/VsSk1BVoPOPdwIbnHu/ZmWnh5PcWAMknpFKkpi3dYDbAur3eCwl654GW2/CJ+6egosr7/0GsjKafIGEvkzOBoJ3XadfjAwmT2KZAuCi48nVUSwnSj8WNfl1Vok8opKTsyh5QaCkVAuHXAQO5yJLwt4AE87QxCzL2byFZ38QaoX87B49pIvRkMz5p61G6eSRPar5zMYL+O8LJvvInweyV3RCNdyfs teaCFshk 0nuItNhZsD06RZacc26x6JMWgXcw9AjSpFb5CgsRfdxjm0nIGdGQLAYjTIe6dhOTUcc3PP1X7vETxt9e8ajn0HbWijWnHW7pwCAg2UW285bkkByTLFRG8L1XJJuSoWGiTfUJaQCzJYQspO3e7J/g6KjviTXR50CZiGVmfaYRrZJ3F8g8+I/K7h4cJcLtJQnAO5maNukPnX+hMYptfop8joNPmzlC1mKIAM/3ypOPt2D2pjUxnz4mWBddoUanpH8l7WTMQ4yoDKWmrdIahBOl2sOf4MslNp1SnDjwY35VoymHZFK2me3ZSahWW4PpfpL+16Axpq+q7cGj0E6frBRzWWILANrc8zH3k4nFcWSRZDo5fJa/HbXN+HO6qXruWpoQMMFbk X-Bogosity: Ham, tests=bogofilter, spamicity=0.003721, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > There is a zswap_entry_ namespace with multiple functions already. > > Signed-off-by: Johannes Weiner Acked-by: Nhat Pham > --- > mm/zswap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 7f88b3a77e4a..173f2e6657de 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -520,7 +520,7 @@ static struct zpool *zswap_find_zpool(struct zswap_en= try *entry) > * Carries out the common pattern of freeing and entry's zpool allocatio= n, > * freeing the entry itself, and decrementing the number of stored pages= . > */ > -static void zswap_free_entry(struct zswap_entry *entry) > +static void zswap_entry_free(struct zswap_entry *entry) > { > if (!entry->length) > atomic_dec(&zswap_same_filled_pages); > @@ -555,7 +555,7 @@ static void zswap_entry_put(struct zswap_entry *entry= ) > WARN_ON_ONCE(refcount < 0); > if (refcount =3D=3D 0) { > WARN_ON_ONCE(!RB_EMPTY_NODE(&entry->rbnode)); > - zswap_free_entry(entry); > + zswap_entry_free(entry); > } > } > > -- > 2.43.0 >