From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9164E8FDC1 for ; Wed, 4 Oct 2023 00:02:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DBEC8D00A4; Tue, 3 Oct 2023 20:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38BDD8D0003; Tue, 3 Oct 2023 20:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 254888D00A4; Tue, 3 Oct 2023 20:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 134948D0003 for ; Tue, 3 Oct 2023 20:02:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD005A04CB for ; Wed, 4 Oct 2023 00:02:49 +0000 (UTC) X-FDA: 81305828058.03.2CDAA31 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf13.hostedemail.com (Postfix) with ESMTP id 256C020020 for ; Wed, 4 Oct 2023 00:02:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TO7Q4zIh; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696377768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0lwvi14RsM0b+xzGuDXKW8wweEZca0TccO+tNNSAvQs=; b=d0DEMC67CIeEuziUTHxiHohFfvMnSmyq9QPp8VjlRiUXwMz+zeC8kw3tP8OGGw1e3uwN/x HJO3wJhcvqpB+ChQi3t3dP6qvochsSd1tr9+yvNco2P724Bam4GtKnRAfy6fVKUkG6ea1+ OUKJrY39o0Hvwa7lE8VzGY9SE3WLMx8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696377768; a=rsa-sha256; cv=none; b=XQ6xyFJ+SEGALVFnqpA9rrH7T2x2jvLPV0gHkVxngGoWc5+kSkEYevD6yNV+nkxJ9SFDYk mC3a/x8eJkwRTenCgus7U/gJnPStGzujwhaK4kz8AVbBNvCFrlSAtKRZPyfuWxdlRfZRRr 8HG6HYY96cwiaDGlGCZFUvzuMTiBhGE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TO7Q4zIh; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-79fe612beabso61499739f.3 for ; Tue, 03 Oct 2023 17:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696377767; x=1696982567; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0lwvi14RsM0b+xzGuDXKW8wweEZca0TccO+tNNSAvQs=; b=TO7Q4zIhC7NypOubkf9qZpMb/yjh9zewMWx6fZOVLgPnP9Zz0/xN7KOOKJbHzIwRyg 69rJ/vI9LXFWOlHRLUcQ06FCtZJvvDXoCQhgeYty9YBoDAkTAwsEDvrDi5X2uUROKi8F qyRw23dPLgA0agN9o9ksoVvPMEVzA+0plMJmhpZeiae5nj1mXTVQpdPLpXWt7fYfr3UY /CgG7y56LZx3yk6m1qy/+/y07rsfSnOxUvdADjQDalcwjVV9KvHt6Vh76lWptzwe2DAQ etwonyVg+y4aOcsWCLHmdkol2WhOw7UPMO8OwXv213kQzSrC2mcNSkPNvqNaEC7pGgYD 2ujQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696377767; x=1696982567; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0lwvi14RsM0b+xzGuDXKW8wweEZca0TccO+tNNSAvQs=; b=BjXDVilj1PaxaJyGAEIeI/I5uuhBIA8szS6f63YCQNyhQnyuhUs0bgmwbk/SIh+Ume o9UDw5a+md5fVm+JU7u7UBmc7UK3UxbnKOo0ZS48R7DqxteX0nSshTkb/Lq/rn9apPoj OwF0mKfQpofw78HlZRhWtPs+Gi4oYwnwEOZ7d4gX/3kiMZFc8fThf7SvgTuoPvd/dhHb Ri3iQFa59+AJlrpVVFykNH5D90EhQHNfYhc7pMimhrbXQy+wEiLOHHUqNh4XZocRS2uQ dfuTUlJiyf21pcd9zHA0E58C90FTqheNjNGAz90JsnI3xzrXEKuWyuGIppxdvEVrXfzq XydA== X-Gm-Message-State: AOJu0Yx7ebPaPBspDjecnPQg281ssMlt7T0+JrfHbB2FQYiHilogbr0S qEwXWzx68pJxJobfhYJLKdvz0L11k39Q1RCdh8Y= X-Google-Smtp-Source: AGHT+IHcMIAN4OhnLftpHP2fzQsi/adjXqQ2orkVpNfzXoJ5ibSH0Kn6foJOqL6FgXDTmUE3LdgpnXokJym0q1jdzEc= X-Received: by 2002:a6b:a12:0:b0:787:1c51:ff99 with SMTP id z18-20020a6b0a12000000b007871c51ff99mr1026524ioi.11.1696377767238; Tue, 03 Oct 2023 17:02:47 -0700 (PDT) MIME-Version: 1.0 References: <20231003171329.GB314430@monkey> <20231003231422.4046187-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Tue, 3 Oct 2023 17:02:34 -0700 Message-ID: Subject: Re: [PATCH] memcontrol: only transfer the memcg data for migration To: Yosry Ahmed Cc: akpm@linux-foundation.org, riel@surriel.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, mike.kravetz@oracle.com, fvdl@google.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: e1jyb1yud9dd7nr3mmwjc8aguitgxft8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 256C020020 X-Rspam-User: X-HE-Tag: 1696377767-918688 X-HE-Meta: U2FsdGVkX19+o0bAWlrT6XFSvwuwvda18Z8wRW3EOmwmHitu4CU4Plomb/EAm/0sKZAnYRozngPzxtyLFsG9Q1lWe9m3I7GyoYxXzMvzm9uT6SA6nnTTx0uTIeOqrvN9OZ4gFQyTPb/+dBe+vb1SnwsmD0Qdd5YUiveZhHHSqNeejxcOLx0mLlocEBAnmjW3lHReeewah0ySM+ZLJRSU35QkJV4dBz23S/cX/nST28o7t6yLMO/a9jLnlGphiUZi3b4RmMqdPPvXpiAhCsrqw/FQurK9Xwj8Hat6gLESLPNfpRU1ao7ZOYSzwFtXikdVnI6m0uLttGAFOEKQjl4mDhi7YZghfVnSpdyBaA8WQyaXlnFkGlWX0n6E9fYKKw5k6oD1VF05NLa+Y+cIUG6SQ631f0DLpUtrUPVuveG59P90q5bx6sGUe+ntCgxC/6DSwLa6Y0V+6/Boi0blJB4uRbmKqTvPHmpNSF20542U1HZOG0TGuTzqUUJOQ36dD0oW3epTgg0e515KJ6LnzuQjQPhFylt1MbrC5vYRZBDbbtoUqQ3DGp8s0vKjchkwZE2ufY5bXEOQY/mf9mAX3qkZIPCyxybng15/VZ4qx5IskqbsWHbpZ15dOCmF19yV6OAtrJf+Ze3cnI24fPbwsdGEVb78B3UOZ+sl8No/JLts63pYnIQCPClzAMQve97ltaSFI15hfzqv8nZhl37tiidh3QOawjnmyeYITmHYfZ4VErXm9d1xDPO579ADRuqDMlY4G7dyZIM3VgD7mwDBbvvclGs8+XXtbka7tCQMwkuHknpxl89h5MLHgXRXB2QseQ4133/I3vg6gfrt0tQOgs6FypKI1eUkpw553omvNQmcZd4/hDL6b36CLNF96P+LQuj4me78WTsfvoTQbffLp3EhXHpunoC5NV1XkAbrELoCUNgwsZx2xaj7cNYt95dAfOIDuqrwof/1cNLG0LJPjxt 3UQgtjqx /HTqcdC8Pos2NuHLAoS1t18IvlNNeeDCHtNNXupro4J9rqn9Fd1FpLGNPf9TkaPiPw0g//oq5YOHfujN6kM0AGvZmkDfXLAGV1esITir++xwctHO5KijHItj/p6BCufDae4R33vzpZ+y6npmNGKAGTRIgn7dOp97SD/eelIZgh/oIJ8El5fUTXOFR65SOpJHbj+Drqc5ZMfzmoRAMH9aAJtLd0x8VrzEtq5TWirK9CY32kkHJRIhuYATvmmg1kSE9IfEcaTuIR0YZFB0M7NDy0qQDEzs90xrbsDMlsbkRc5n+XFwpApQCrYgy3ljlTjieU/vG4uOi8vr0Z/19+ciXppBHE/fg/KwZZod5yWCCH8D7O8xMSCl7Utj+yDntA83ob4gPwtxrVDz4+OavY9i4S8pa5Y+x9Jpw2ELhAKJLQy04mZgLwTY12MzfiKLTZResI2UrkmuyFfES4zijFpyRMxYbyMxJ5xQa0GEBe6G6wEi9H9bS3t3rPFCyti3r73EM/c2Gl4i1lndBrwUt62RLaJa1A/tLRZgpjXFi X-Bogosity: Ham, tests=bogofilter, spamicity=0.013920, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 3, 2023 at 4:54=E2=80=AFPM Yosry Ahmed = wrote: > > On Tue, Oct 3, 2023 at 4:31=E2=80=AFPM Nhat Pham wrot= e: > > > > On Tue, Oct 3, 2023 at 4:22=E2=80=AFPM Yosry Ahmed wrote: > > > > > > On Tue, Oct 3, 2023 at 4:14=E2=80=AFPM Nhat Pham = wrote: > > > > > > > > For most migration use cases, only transfer the memcg data from the= old > > > > folio to the new folio, and clear the old folio's memcg data. No > > > > charging and uncharging will be done. These use cases include the n= ew > > > > hugetlb memcg accounting behavior (which was not previously handled= ). > > > > > > > > This shaves off some work on the migration path, and avoids the > > > > temporary double charging of a folio during its migration. > > > > > > > > The only exception is replace_page_cache_folio(), which will use th= e old > > > > mem_cgroup_migrate() (now renamed to mem_cgroup_replace_folio). In = that > > > > context, the isolation of the old page isn't quite as thorough as w= ith > > > > migration, so we cannot use our new implementation directly. > > > > > > > > This patch is the result of the following discussion on the new hug= etlb > > > > memcg accounting behavior: > > > > > > > > https://lore.kernel.org/lkml/20231003171329.GB314430@monkey/ > > > > > > > > Reported-by: Mike Kravetz > > > > Closes: https://lore.kernel.org/lkml/20231003171329.GB314430@monkey= / > > > > Suggested-by: Johannes Weiner > > > > Signed-off-by: Nhat Pham > > > > > > Does this patch fit before or after your series? In both cases I thin= k > > > there might be a problem for bisectability. > > > > Hmm my intention for this patch is as a fixlet. > > (i.e it should be eventually squashed to the second patch of that serie= s). > > I just include the extra context on the fixlet for review purposes. > > > > My apologies - should have been much clearer. > > (Perhaps I should just send out v4 at this point?) > > > > It's really up to Andrew, just make it clear what the intention is. Thanks for reminding me! That was my oversight. > > Thanks!