From: Nhat Pham <nphamcs@gmail.com>
To: Li Wang <liwang@redhat.com>
Cc: akpm@linux-foundation.org, yosry@kernel.org, hannes@cmpxchg.org,
mhocko@kernel.org, mkoutny@suse.com, muchun.song@linux.dev,
tj@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev,
longman@redhat.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v5 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap
Date: Fri, 27 Mar 2026 14:25:31 -0400 [thread overview]
Message-ID: <CAKEwX=P4kt93-5iG6o34bjG7jb7CAmSRBNvjKHfMTuFN7v8gQw@mail.gmail.com> (raw)
In-Reply-To: <20260326032658.96819-3-liwang@redhat.com>
On Wed, Mar 25, 2026 at 11:27 PM Li Wang <liwang@redhat.com> wrote:
>
> test_swapin_nozswap can hit OOM before reaching its assertions on some
> setups. The test currently sets memory.max=8M and then allocates/reads
> 32M with memory.zswap.max=0, which may over-constrain reclaim and kill
> the workload process.
>
> Replace hardcoded sizes with PAGE_SIZE-based values:
> - control_allocation_size = PAGE_SIZE * 512
> - memory.max = control_allocation_size * 3 / 4
> - minimum expected swap = control_allocation_size / 4
>
> This keeps the test pressure model intact (allocate/read beyond memory.max to
> force swap-in/out) while making it more robust across different environments.
>
> The test intent is unchanged: confirm that swapping occurs while zswap remains
> unused when memory.zswap.max=0.
>
Acked-by: Nhat Pham <nphamcs@gmail.com>
next prev parent reply other threads:[~2026-03-27 18:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 3:26 [PATCH v5 0/8] selftests/cgroup: improve zswap tests robustness and support large page sizes Li Wang
2026-03-26 3:26 ` [PATCH v5 1/8] selftests/cgroup: skip test_zswap if zswap is globally disabled Li Wang
2026-03-26 3:26 ` [PATCH v5 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-03-27 18:25 ` Nhat Pham [this message]
2026-03-26 3:26 ` [PATCH v5 3/8] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-03-26 3:26 ` [PATCH v5 4/8] selftests/cgroup: rename PAGE_SIZE to BUF_SIZE in cgroup_util Li Wang
2026-03-26 3:26 ` [PATCH v5 5/8] selftests/cgroup: replace hardcoded page size values in test_zswap Li Wang
2026-03-26 3:26 ` [PATCH v5 6/8] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on large pagesize system Li Wang
2026-03-26 3:26 ` [PATCH v5 7/8] selftest/cgroup: fix zswap attempt_writeback() on 64K " Li Wang
2026-03-26 3:26 ` [PATCH v5 8/8] selftests/cgroup: test_zswap: wait for asynchronous writeback Li Wang
2026-03-26 6:29 ` [PATCH v5 0/8] selftests/cgroup: improve zswap tests robustness and support large page sizes Li Wang
2026-03-26 23:06 ` Andrew Morton
2026-03-26 23:10 ` Yosry Ahmed
2026-03-27 0:57 ` Li Wang
2026-03-26 23:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=P4kt93-5iG6o34bjG7jb7CAmSRBNvjKHfMTuFN7v8gQw@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwang@redhat.com \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox