From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8139D3399E for ; Mon, 28 Oct 2024 16:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21DB76B008A; Mon, 28 Oct 2024 12:33:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CE056B008C; Mon, 28 Oct 2024 12:33:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 095A56B0092; Mon, 28 Oct 2024 12:33:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DD2EB6B008A for ; Mon, 28 Oct 2024 12:33:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 635F340B50 for ; Mon, 28 Oct 2024 16:33:27 +0000 (UTC) X-FDA: 82723555572.25.64101E9 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf25.hostedemail.com (Postfix) with ESMTP id BC596A000F for ; Mon, 28 Oct 2024 16:33:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PFr2/PXw"; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730133047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ZfZjSCAWP9ZXz6uYSpe7KSiByIBqtwjG5huOvmkf6o=; b=PYBTeOeGh5fY2lACdZ3pJ2qM8VqjtTSG7G4jarKn8laTGUD3yNjmYfK6yv2p4dbG6/f3ST Kmx5bNWc1SG73eJ1ZOloWZAayHpBfED1YLPPydZ+xKxDWlIHpZtS3c0Yn+ylC+UAUAO3b+ oKtY1GoH7Rg0u5C52LMO3SGl18EWbQU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730133047; a=rsa-sha256; cv=none; b=LWHgREDI5IOphBipg22cxcLXt9md5DbPoBmofOEdRSff3VcYtJdUeVGVF4eyO/hj8m8xYJ 4lafv3osh0So5W2QK36bLg6407mlJXx7g1Q0VGW6qsLAd9Y94k4jzSHq0dtYLPyzp0hdOh Ieq7VX1aQMlgxzJ/RVH2p+HA9Qh0iLE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PFr2/PXw"; spf=pass (imf25.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6cbe9914487so28203406d6.1 for ; Mon, 28 Oct 2024 09:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730133204; x=1730738004; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2ZfZjSCAWP9ZXz6uYSpe7KSiByIBqtwjG5huOvmkf6o=; b=PFr2/PXwy9bc7+yERfdelypVB+xKXv3bED2TYVkK12vdqTiYhXda3oFt5JQzHY1Vid NgYS1iCOgtgAgoVgdFhnGEII9UukJKPrhGDrZ7B6U8FxUwYuqjO0k+0DuUeqAWJWmsGh YfKlEHL1b6HXGuBEskPbpTVTiUDopXM07AC9VJKGWlPVvt7IwU1dM5IzHJs6uSvAjjOi Cz4l0nUxntvmJZ8/Y208ttaPhftS+hVAR+5SlwuLs16V9YYM8XOcOpSBbZJCp3ApNpHL 6UuPgvukrvNsXX/xXBuawWdDSKNns5IpDgDrQ3/MbDr7yg2KQCWJJIYK9nFpqSo3+Tcl LNlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730133204; x=1730738004; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ZfZjSCAWP9ZXz6uYSpe7KSiByIBqtwjG5huOvmkf6o=; b=jf/Td94vrz8I9ti1zfsN8oJh1CkMH0r0Xij0tFv7y24LVX1ctGEqeuYXrqlt1xEcYk GBtBNPFuaYojaHtxJ3eYjiWxDW6+v/ftZ4Z9YwIPRt3wmwzJkJL+Q+OkfbfZVWPmc+GK pHBvDGmY2tDn8HdYtjkCXsE/tjzNs7x97DoIxTtUWSa/z4eFSb8vIZ1Q2yRUDQSNHOWB I+9Nj1WmBC0Hx0r3PqdDq6K4lD3r//hKJXaG1eL3vpeTL/5MP1vkocYZ7c3TcWHHz81l LD7SDr8C8byCQ7w+S+2iXybEMwS2kbPmD+BSIz1WcjEPr0cnRJIK8Qp4MYIDxw3VaZF1 pYWA== X-Forwarded-Encrypted: i=1; AJvYcCXxjtGNykOUzJa1zHchdsS7CJfZVcy8Ac8EH29y7EsrQpGkIuMuSyS4ob0sAyJ39fN2+QhXg7rRCQ==@kvack.org X-Gm-Message-State: AOJu0YxT5MhwRRc+zAtiSrcF3X8rLzUxEgbN8HuIEx35BIpw1P8eaMtw V6tNgwoVyuLgvvj0IKHd9tLrJn74T6DDcTuYJRdm6u4WYmi7kgTZ5fcfI0fbpFgiJSIYUvdY1tD lqDtaG2IK9A9ILGgqPp/BHaYcbaQ= X-Google-Smtp-Source: AGHT+IE6KuA9hX9cuGFxAg10exsTgpHnLr4uoSkhocTMYWkpFRiyqcAJnXVhz3E01lnR4gxT7YgmQVHssnm/1H0uPks= X-Received: by 2002:a05:6214:3d86:b0:6cb:c70e:4e9 with SMTP id 6a1803df08f44-6d185675955mr174266846d6.10.1730133204627; Mon, 28 Oct 2024 09:33:24 -0700 (PDT) MIME-Version: 1.0 References: <20241027011959.9226-1-21cnbao@gmail.com> <678a1e30-4962-48de-b5cb-03a1b4b9db1b@gmail.com> In-Reply-To: <678a1e30-4962-48de-b5cb-03a1b4b9db1b@gmail.com> From: Nhat Pham Date: Mon, 28 Oct 2024 09:33:11 -0700 Message-ID: Subject: Re: [PATCH RFC] mm: count zeromap read and set for swapout and swapin To: Usama Arif Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Chengming Zhou , Yosry Ahmed , Johannes Weiner , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts , joshua.hahnjy@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BC596A000F X-Stat-Signature: nmxqdokktay1a8pzho1jbz59rky3tbwr X-HE-Tag: 1730133188-548384 X-HE-Meta: U2FsdGVkX1/iEhhGwXFvKZIySr5ZrYvsqFZtr+M/gwmhcrjG3Axtyc3s/QEJBZrAlW9bxiXLCEvY+ujwZrz+kn3akwz1YMSpvAtsVeD3B8HIInW5+80Ob0TL63dEGx1pm00SutGPZD3fpJEXIaPeZTg5SNZ0yyPw8S8SjN1IHV6j3tIIfApxwhVLVLa3aMZh4xPle9Osic+eFIKoeVXcxnRcyKpAdt6tOkHIGuCAJs+T4y5K2oO1wEX5h6YdqFNy0b6WR17CIgHE7bJk5RsL5EiHYEuwZgkv5E2Lagj5Aemeziiyb+nUa8rdTHnStbhTZnehUCfKPi9aZzQXgtYpDYh3Lp/4GR5O5+4WvRdNi0LCynnJbFUMHgBoe0qabJLO/aEibDar26XrS27tDm6g3hYi7oBwTI5rBMr6jOgLIwxxzKevg5G/3EJXz4oPw9m77PJXsTwQ7WW0V/6xMe2htw5grPY9mI2U2G6DZt4PlTDPVOEQ1iH2erDWg72mFyqHp7xWyxE3kw10oGvqGOEaSL2ZemeqLyD2qK7QVHAL6/8dW7r5WJPqcltpM5QEHQPgwdPQY0ew3keS5TkFMpFzA+1gHttmOgOFwCwrGcfDjBGyY06WQYjZZNvY/eKoPEnvBSAFpS7RpK5/eoefp9brZMM6LBMFF4MOrYPE3eHTCVrU9J4hXtGVkp3nGT/ICILK2YwdF8JGIflMgP3rnsBsrttPrENIi6hBeDH29eC1wwGCFrBZCOBj3HycstlThBSEgRM8uCkibKlwrw+I42yKHQyn/tFWKuc3/SSZ54RHc0v2RIzAnXAxFyDpJaaRhj0Jw+3cB9Q4JsOaPedAz7GQ4Wf23dPM0wpyMSbBavKQ/kB60ycRAUJ+BRpVVX09GurOkHQrLNtpVmpV0r4KXsMSqQCWJuYoavdZeDaSl2vGyLlze5w67apAgxV0VIxgEgWZpVMG0wm64l4BlVNNDxQ Ocz+LD07 Kx+haLwjZmfizv6/d/fsKLz54BoRgEEBPNH9Jikm6Y8PgojsrIwqMKff71fyF6L/uk++GbkJs+/GTzujtTWW+JpebA5G0hTJP4PoTTTOc427THiD2gSdfR2Z7CJZ8ifkgyZx6g5S4zJN+xl2isNuI/yU+E2eBy3w9ZUkRMkVNgsvdjCYcLn3G1XW8BOvnSlBYYCgBhwdulSES/RX7WjzVE86WXNCa1t7k+dMX45qWX7hunR5jgqP64w87hI9Ho4GBJW0sZcvyqhMMsbwKUL/ewOGOrslg1sbZUaawBYOiBxZzHKjLeFYkj9BLVxF+Y7xUPemYcZmnqchhm2zqjLX76BWT6McnbPXqPWBWxEyzkmaEoOEzx8dqgVYs6f2JVPxHttT0YTl7O78FVrG640iPhFtWz3KLy8FOdjyq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000074, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 5:23=E2=80=AFAM Usama Arif = wrote: > > I wonder if instead of having counters, it might be better to keep track > of the number of zeropages currently stored in zeromap, similar to how > zswap_same_filled_pages did it. It will be more complicated then this > patch, but would give more insight of the current state of the system. > > Joshua (in CC) was going to have a look at that. I don't think one can substitute for the other. The "current zeromapped page" counter gives you a breakdown of where memory resides, whereas the in/out counters explain past performance based on events that have happened. That's why you have zswap, zswapped, zswpout, zswpin.