From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB02C19F32 for ; Fri, 7 Mar 2025 17:03:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 039D06B007B; Fri, 7 Mar 2025 12:03:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F05286B0082; Fri, 7 Mar 2025 12:03:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCC326B0083; Fri, 7 Mar 2025 12:03:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF8166B007B for ; Fri, 7 Mar 2025 12:03:46 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 88A55140E5D for ; Fri, 7 Mar 2025 17:03:47 +0000 (UTC) X-FDA: 83195376894.05.34AEF2C Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf29.hostedemail.com (Postfix) with ESMTP id AE931120016 for ; Fri, 7 Mar 2025 17:03:45 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f242o4lb; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741367025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QiKTsfH4WXXUP4h2ca4OnXKk4k04SEzwaACzL1m5raw=; b=L3nJVflSnaNLz1zqRYcC0nTvFwmdyEyy3M3X6yqCyxdNTtOhq/y/IZwucg/1ab1TmSYhz6 7Pfyq7CNmAu7TiCkMwhMC3xwWGIg4BRA+I+5bVGM0ue/V3IhpxDtYhfpgciWrizUYdy+Ig uXIi4mAA/p4NK4w1tNL8ojUhpPAY0L4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f242o4lb; spf=pass (imf29.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741367025; a=rsa-sha256; cv=none; b=PkMRLyV+clB1Njn25DhZZVprNDxwSCnm0pQtcLdrextG4PSpAkDI9vaPe40RKnN8Un1Vix pUID+HT6Gnm8UtA9YwC9Ag+QDI4MBg5fpdxDM8uEekCp5DuLf36XsmLfxE50rpYffzzc86 ahsmcX/8vWeCa4lGv+0rXcx6oErTHUA= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6dd1962a75bso14329396d6.3 for ; Fri, 07 Mar 2025 09:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741367025; x=1741971825; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QiKTsfH4WXXUP4h2ca4OnXKk4k04SEzwaACzL1m5raw=; b=f242o4lbn2Gz5EIOkriDOiRYu7wh2g+huWpCVYFtRQ+yD6lzbA5wZBrEUdx8fdWpEU 0M7IPzTnRszOvWpktk3bvSXhmPvAXq8Qvy5/3AsTvSO49cuZMnuSStZ8Bqyh8RJYzxDD NLBdvo0NmEyjC0Faa1xGHh31OPtBxSdmZlxr+gZV9FI9TuEaXkz979Nqm3rEkBBvLtZ3 Qgvk28WPFvDMwID5Ikg+5Z73/R+iHIIJNWa2rlhexw/SVyTt7N5vHWKiU+NpNd7smHal o9sG3WiNBs22bPBdoqr1zD0MIyoVIvMBSLIAvOc8Yt8K9UFHJB1qdUICsy3gYJ6IRw1G 3y1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741367025; x=1741971825; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QiKTsfH4WXXUP4h2ca4OnXKk4k04SEzwaACzL1m5raw=; b=DDNsomylgt31+t1Los4OD4i8w46pyL7x92uzmJJrR8A9P1fcXFIC+5WLU7p1U9oB23 qiH/0kR5c/rJpgKnFRgSvrRAD5V3KYsXGwjF7mym5YR5luAEsJk2C5Y7dgfhaKBkF3pl Lmy2aupRk40IRT0GFUiX0pSdrN60LadiJhqaHLivwmbn48AFZcaGis6AeZ2mXX3yUsaE BPqKlSyHvVcR6KcfnE8YwvSdPszD1H5FAg4boqQnLLGdw3c/iEZVtEoNTKMCrgSngYnU 2B1sAoQ+ui68x83SIO6Bb8WQIlMP5C/wQN+8T2pHjVbzO3zX644QX7ozMNtwMgC2PUeh BT7g== X-Forwarded-Encrypted: i=1; AJvYcCVhj+txlVanc40HD6rRJEnQt/owxt8Veqg6q5Ij0xzYNupQNFlKZO4WYzFHgmlAKGlp9RkFs7sP8w==@kvack.org X-Gm-Message-State: AOJu0Yysecnh8D0RpMyttDl/sBvBOTgQdugw8THZV51QI1GskXS1rQGR 6/1xqaXdmEUqmieb/oM7jEYPcjejfmZXcYUwHfoi5MsyLQoNsfY9Vk1sGNY7GonmEUL8CZ9MFPc VfhR4If7Ht3lDaWIiBMGXO06e9FE= X-Gm-Gg: ASbGncuaU07G98uIU3jifnEXoT+h6DoaYMKENsSK6SJ4HXJI/Yu/9t1NxIgLMTTibGh h7jAglr2zUclX5jTLbf45FLDxFfHdbWZqd0/7SFxlmnEuAFfXwXFIxBhQe5Gz2T6SVv7cP6h+mq rb8JB2bpbRPWsc9gvIY8MMunb0WmCDljQPN30f0Mdq4ezykTyDZnpDVQtPRA== X-Google-Smtp-Source: AGHT+IFDUByAKqeG8kqL/TqrXOQ3VWLLMyvQiLw5d3pGfsiCMMwZjVs1Ffmr17Euv9p8n7myqeOQBp4rksyFy+cpusY= X-Received: by 2002:a05:6214:226f:b0:6e4:4331:aae0 with SMTP id 6a1803df08f44-6e9005b6680mr47282826d6.1.1741367024662; Fri, 07 Mar 2025 09:03:44 -0800 (PST) MIME-Version: 1.0 References: <20250306230015.1456794-1-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Fri, 7 Mar 2025 09:03:33 -0800 X-Gm-Features: AQ5f1JrgxbP54B3olz9OKTba3hhi9h0SB_F7i4XiV2ykaR3qfQRC6OQNfCjFJ9s Message-ID: Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() To: Yosry Ahmed Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1iu4jhtkbtrz4678wxu1noj81frwk4kr X-Rspamd-Queue-Id: AE931120016 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741367025-166642 X-HE-Meta: U2FsdGVkX19jWZdOUfcsjVh93pzLTxEgZeer8vMqECIWvYvIb09tKg5n1QlGoYdXjSiS39kJ5WUVhdtN6ynxOV8Cg7HKpoZquhAJCtF35U4FwVVGEwsCZGI8jSsCjPty189b1Mtf0Jsx3onXs4ie7xiGCd0o0ezYK4SWa0hNcSbjaYZOFfzFuhrPa4xV7xm3RurYEECkmOFh3GM8GvJI//nr+P7iQOTV/FvZCNir1EaO/UJREm6aE/mIxvHCAhyllqPeVPOy+yM7rJZKdW8nCMZpN6wwTf3OBlbQvA+rGBhEciQbJJvFKIB08BNMY9J0EcT0ZmWLF/C+B2VpMjak/dbQK5fvAzRh/mwEcv4SFN3K3COvNWJycobp4AGselRQb4h1jo587qkf5zcLccEjzjj6VT+dR4YTanXZaaxVxhLyLkwzkzdn9PYiZdPz44hNPQRoiXpMVKynhVCFG+wlmpu4FTDvOmOeWUUmpzZEh6HAmUW/dxFm8TpTPbKz3op4Xfndn94PWl4FXNu7M/7Gqopwqf9D83phOdXKOeCvBBofTUEwzV2rQYRL80IRR7E3H/3ADHiQ5N7BuZZzKgh9d7AIPNwE0ajxnLd26eRx4tCkmJo9CUzYmlthivxxdhU0SlaqyGP0OLQKXRDfFZBi+3pDjq+HNW8CYr5N6pHPR9VyvtvHIXLBgrlSYNCF35SIsULVXm4grjziwm8d7ea2T8H2dDpjyzoR2ehci8dZ+9kG03C143ggR/aCBylR5mvZH6+n2Cb3o2qm8r1INMBf3e5mgwc0/F1euz9EmDBX+2JesWePE93bV0OaLfplGUTVHy4o5WIilSjjSqhPYhAm9KpGtCD3KJKuwztqWLYuHdoTi7BWViA5JhjkZzMVNY/iBhWSsAk+vqTh9DFyx/cbKW3JiQ2DQUww5rtm6BW8ch90y1lcF7I26XhT3oDm1hIOHJCfGiN2764u1nO00xn zO0hUyLc k4TEy0/jPIIQmhbXP6OnLs/zKbhQDf8AA12xRxHrP2quphnUhHqFcgEb2MQZOegYXYiHHl2U01TUfprbPJYXFZqQAY7y/dGT0iDyGQBO3rOgjoMVmB7U53TQrTekud87DuIcygSxw5f5KJZ5p/xI3um1fqpXKARHvO6pDcD8hKWAD84mRzyeXUpAXfvoqRvHlbi4HrTLR16+rnO/hQvrt6bduVb/8oAyKVQkCjqOm1wg/XUT9ORme+lritqwrsMpYKfw01zDol81VXyrfxqtYg5XyArj35JCcC9AITm/Aph/HzfVT7RuH90s1t90Z+RWC7QrDXOppnyeSs3dZdk09W8D2npxEdm9WayfSSbG8yPwRp/4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.262477, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 6, 2025 at 3:42=E2=80=AFPM Yosry Ahmed = wrote: > > > + * > > + * -EINVAL: some of the subpages in the folio are zeromaped, but not = all of > > + * them. This is an error because we don't currently support a large = folio > > + * that is partially in the zeromap. The folio is unlocked, but NOT m= arked > > + * up-to-date, so that an IO error is emitted (e.g. do_swap_page() wi= ll > > + * sigbus). > > This is a bit repetitive. Maybe: > > * -EINVAL: The folio is partially in the zeromap, which is not > * currently supported. The folio is unlocked, but NOT marked > * up-to-date, so that an IO error is emitted (e.g. do_swap_page() will > * sigbus). > > > > I would drop this whole comment now because it's mostly repeating what's > now documneted above. > > With the comments fixed up: > > Reviewed-by: Yosry Ahmed > Ah I like both suggestions :) Gimme one sec to send out a fixlet. Thanks, Yosry!