From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240A6EB64DC for ; Tue, 11 Jul 2023 17:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAB226B0072; Tue, 11 Jul 2023 13:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5B4C6B0074; Tue, 11 Jul 2023 13:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 923326B0075; Tue, 11 Jul 2023 13:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7EF9D6B0072 for ; Tue, 11 Jul 2023 13:52:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C81F614029E for ; Tue, 11 Jul 2023 17:52:15 +0000 (UTC) X-FDA: 81000075030.25.0686CF6 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 0A7331C0022 for ; Tue, 11 Jul 2023 17:52:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ASi9RGXO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689097934; a=rsa-sha256; cv=none; b=v0BIbyzevMYbbkb4XfxKKTHZqtEFMoakm+YyoCUn39abVoilpfsE5VFhX1HcHxvGkWB5ka qjYmGzXAL8EjbgpatxdC8pMUYZyO9f+kazou/+t5+CJZ3e2nMHqSZUGJcBWXxzHnA+Kn8J 1ZRB1vtqbk4pVlN8MGxMsbu9s6/ySYY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ASi9RGXO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689097934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ODLr3pmtPj0GV9rbQznJdLVVhcXFKDW1ZMX+SWOB1NA=; b=Zi/8VL8IoVGYqmMcl0dSr8ukRTB2wGfhJxct+tn58n4/PWhWHQNe4uEZ9AnAOWB+3/UqjM UevUOVlifUH0sBba5ChoXjc/3FJY4Os1f77bZayBq9C5Jxo8/wstu7DPzP39oagUtgbgW0 1qcTRrI7M9u8BmIBEFutX5epPIQNgSU= Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7872d448c5aso11093139f.0 for ; Tue, 11 Jul 2023 10:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689097933; x=1691689933; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ODLr3pmtPj0GV9rbQznJdLVVhcXFKDW1ZMX+SWOB1NA=; b=ASi9RGXO+8zyQX+7QmWah6y1BAL6V23QYPA1ByJlh5aVcrrCa73OzndDFLzfPsUe0y VniHduFu+pHA3/R/aoN02fsd8QfF3V7Cfo7bmfELSgBGCai7KOBLPJ4nHfnZEJVfTWos 6S3GuytLAdM1yUcjnv4tMf6BDBFIVsGmJuWiSHgF1MY2gSuGrJl8fLVF4ofRx8a7dGkS QHo6DT1qprGezK7iEcb/UMVGOEZIRQclRf2PJre9o/KoMka9GardPZdLli+MSVyAIEhn kKovtKuj4nDLQsSgLFNw4ZWZa1cEzM+AHZ+BsNSAK0rDesTCec5ztb688ODw7V3yF8Tn +ghA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689097933; x=1691689933; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ODLr3pmtPj0GV9rbQznJdLVVhcXFKDW1ZMX+SWOB1NA=; b=eX7b5P/sgSPtQDaC69/8EzjhlwARvynNCGIV+K6VSFbaeBwUd5FqYu9zbcSNooy0X0 lpuZAZclzJYTaibJtOpIklZFTnHcE7nqLW3KDiE/+oEm4VwnZFmdYfEhR669oj2Ue89j 7HkldZnTy1YBQTuHT1SVK9SVq28uENS1AZGan1MFibySVcUX69MG42TyM6oAzRYZWjOl bFeJbhcMkoF+WdjEOWXMrW1aCG5xqGOi6Or8+YJmzMlREv+7m0hijb7J27mGLayBidJp ZJDl0aaXDuq6LEHdbeEX39N5c1JwNUrffwEOJzpmy1bVflfjYFcQwyaogjdCh2Vy9r2j HRaw== X-Gm-Message-State: ABy/qLYKaC1sB6eR3DYk5g6GLMSHypDPCIyMHPTqu2R9L/YdscAzji61 Qxr5TDXVFeN9lUPWiGKh0pXXojycdhXYD2xIK+Y= X-Google-Smtp-Source: APBJJlFpThJX0UW7iLw/nua5l4yY5AHOkr+TUIhEeSbubuXdfifANYwxqTQN9SrljtLhznpHLy3cRCAqRkKkql9asdI= X-Received: by 2002:a5e:8d18:0:b0:787:5ca:e24 with SMTP id m24-20020a5e8d18000000b0078705ca0e24mr8267494ioj.3.1689097933102; Tue, 11 Jul 2023 10:52:13 -0700 (PDT) MIME-Version: 1.0 References: <20230710221659.2473460-1-minchan@kernel.org> In-Reply-To: From: Nhat Pham Date: Tue, 11 Jul 2023 10:52:02 -0700 Message-ID: Subject: Re: [PATCH 0/3] zram: use frontswap for zram swap usecase To: Christoph Hellwig Cc: Minchan Kim , Andrew Morton , linux-mm , Jens Axboe , Konrad Rzeszutek Wilk , Seth Jennings , Sergey Senozhatsky Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0A7331C0022 X-Stat-Signature: sx9cthpdedsz1yw17sbetthpngqxgana X-HE-Tag: 1689097933-875612 X-HE-Meta: U2FsdGVkX18KF0KTzIiRekEAgmwuosqALwQ/+w/7K6kHoGoXxcHaoYVgnciyUaiDqRJxpEmTJiZ+GjnCoOlQA+pilF5cyxKYOtWTvWdn+2u5tuvROjy7GxOufpixF+kJRplEgYBhxYqIJGX+M/QeZ/TV9P+IyBsA+JEQqu2n5jy7esptCD1g4fonVsfppmPdyZVj7b5t/1+lECCWdYnIyRSGOwwOq/m+hICvs66Wjn+EQMwgTmxxqsqs4EMPxm6Jnf+eD67BGehVSxUZfkAefH1Q1ur1DsVP3762+2Q52pFMtXRwrtcEUaj8Ujx7dN8Hg7JhPDbL/Lhh3err2vWVfShxrR/YHL2QJzuP9HYOXtzway95PCaCL1wim174g5V5A3nom5KSEy4U8KNzJ9DmU0KRP7Cqldq3/zqaviLACiZjQjPurb1nSPtfEPZgyXSQFgH1vaNqopETCchAx3XSYdPOoy3e1cv5zUCRb5cte+CkJXL18Y2ZGV/KU89DTrpYNDjgYG4558TqWDynzvLwf7bh0LCZVfCdW6WjOueUJCbCck8RMLrJoity1Hgx5utXUEIVpwDkeBqreTa9qKJx6GjKCQ2psHSK7dEpQcNUBq7kblQ1OsILW/fZvxGlXIUiPVrZxHj6SMeiWVBcGP6UVesAkMOji+ltY1lDvhDPTl39GUC5FVc62sc1/EuEAjZ4gNa6BgeO01P+HTpWLMsWDtLeyQYbesIFoFUlkWhfcS4lBOR2uxRpT+EGLBlUn/NaP9OKKW7nx0iYXzs4HP8v0cMtenpjfreA7WXPyG6UE7nk/oygdszsO0J7PO/08+Ewgls5TQRdUdt+VW2IGUCXlHoC9BOUi725XapBK+nL3Jg2UTbTzduiRzmjZeiO6tqymMF83J2pkO7NatiArtU4G1a9NrWuJFYncy6E4ZCHDFucDM1NwvY+grsIdRzTutNUVQXMzDhRMoKe3WprD/Q FEeE1+Pi STFU4blSl3ey4yHdR/rgHCSY/PuStIc47CgRGJkT/RpvHTuunoukPvkFqE85J0xXNcfYRRiZoUZM4CeDEMO9DKi1NPDhDxnSzTvcwPczmybAny4WK7p2o4IEzo4fH6QhkkNNFdpkH2OCaFKB4LKv2P0RbMHasFjKJ+ayefsONxNflXvkv7PXXFs1nlrHBVuRGq5Im4wQOnzYGrxNYEuFKQ2+OjYRSq2kOFtfXCEiXvWJ91bYdY3MUaVxZXKwrbaNlfMqlWztd9wJe6IvOKaveEsSNdxOwyRSFKjh/P1E3eMWxQB2faqqXM30DT+B4R7oF3mY78qnwtIY765g6zdYd0zZvd3Z4D+YUzgJ+QBArn2Lz7X/3COlug9ihnP7AH3Dr2tkPwARmwLbC05GTEtsJld+4c38JSri9Lcap0lFrytRPqG5I0j163OYOtYNEW+hK0enBzKE8Q1zPkvsl0Jv9sXef5ZqH/fkb9S21EBPN6ljhrPICWffno8ZVwEBhItr5KUB5tPXc16Wagk+vjj/gLIQfbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 10:18=E2=80=AFPM Christoph Hellwig wrote: > > On Mon, Jul 10, 2023 at 03:16:56PM -0700, Minchan Kim wrote: > > This patchset uses frontswap for zram swap usecase and remove > > swap_slot_free_notify swap specific operation in block device. > > It shows 13% swapout improvement for MADV_PAGEOUT. > > Err, no. frontswap needs to go away, and not be tried to a block > driver. If you want compressed swap without a block driver please use > zswap and help improvig it and the swap abstraction to not require > a backing allocation for it. > > We need to fix swap and not pile hacks on top of hacks. > +1. Based on earlier discussions, it seems like the agreed upon way forward is to remove the frontswap interface: https://lore.kernel.org/linux-mm/20230530235447.GB102494@cmpxchg.org/