From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: riel@surriel.com, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeelb@google.com,
muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com,
shuah@kernel.org, mike.kravetz@oracle.com,
yosryahmed@google.com, fvdl@google.com, linux-mm@kvack.org,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hugetlb: memcg: account hugetlb-backed memory in memory controller (fix)
Date: Fri, 29 Sep 2023 11:19:07 -0700 [thread overview]
Message-ID: <CAKEwX=Ozp4sTG-g3gT8FCmg4ZAr7ScUoJpODixpRLhmyV1rH-g@mail.gmail.com> (raw)
In-Reply-To: <20230929181712.3723495-1-nphamcs@gmail.com>
On Fri, Sep 29, 2023 at 11:17 AM Nhat Pham <nphamcs@gmail.com> wrote:
>
> This fixlet disables the hugetlb memcg accounting behavior in cgroup v1.
>
Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
> mm/memcontrol.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d5dfc9b36acb..de6bd8ca87f5 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -7081,6 +7081,7 @@ int mem_cgroup_hugetlb_charge_folio(struct folio *folio, gfp_t gfp)
> int ret;
>
> if (mem_cgroup_disabled() ||
> + !cgroup_subsys_on_dfl(memory_cgrp_subsys) ||
> !(cgrp_dfl_root.flags & CGRP_ROOT_MEMORY_HUGETLB_ACCOUNTING))
> return 0;
>
> --
> 2.34.1
next prev parent reply other threads:[~2023-09-29 18:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 0:57 [PATCH v2 0/2] hugetlb memcg accounting Nhat Pham
2023-09-28 0:57 ` [PATCH v2 1/2] hugetlb: memcg: account hugetlb-backed memory in memory controller Nhat Pham
2023-09-28 22:59 ` Frank van der Linden
2023-09-29 0:33 ` Nhat Pham
2023-09-29 0:38 ` Yosry Ahmed
2023-09-29 0:58 ` Nhat Pham
2023-09-29 1:07 ` Nhat Pham
2023-09-29 1:18 ` Yosry Ahmed
2023-09-29 1:25 ` Nhat Pham
2023-09-29 15:08 ` Johannes Weiner
2023-09-29 15:11 ` Yosry Ahmed
2023-09-29 17:42 ` Johannes Weiner
2023-09-29 17:48 ` Nhat Pham
2023-09-29 18:07 ` Frank van der Linden
2023-10-02 12:18 ` Michal Hocko
2023-09-29 18:17 ` [PATCH v2 1/2] hugetlb: memcg: account hugetlb-backed memory in memory controller (fix) Nhat Pham
2023-09-29 18:19 ` Nhat Pham [this message]
2023-10-02 13:43 ` [PATCH v2 1/2] hugetlb: memcg: account hugetlb-backed memory in memory controller Michal Hocko
2023-10-02 14:50 ` Johannes Weiner
2023-10-02 15:08 ` Michal Hocko
2023-10-02 15:25 ` Johannes Weiner
2023-10-02 17:32 ` Nhat Pham
2023-10-03 9:17 ` Michal Hocko
2023-10-02 16:21 ` Johannes Weiner
2023-10-02 17:28 ` Nhat Pham
2023-09-28 0:57 ` [PATCH v2 2/2] selftests: add a selftest to verify hugetlb usage in memcg Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=Ozp4sTG-g3gT8FCmg4ZAr7ScUoJpODixpRLhmyV1rH-g@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=fvdl@google.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=riel@surriel.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox