From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB98E6C5E3 for ; Tue, 3 Dec 2024 00:17:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CD46B007B; Mon, 2 Dec 2024 19:17:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D4ED6B0083; Mon, 2 Dec 2024 19:17:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 675486B0085; Mon, 2 Dec 2024 19:17:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 46EDF6B007B for ; Mon, 2 Dec 2024 19:17:43 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC00B80415 for ; Tue, 3 Dec 2024 00:17:42 +0000 (UTC) X-FDA: 82851734238.28.74DFE37 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 26FBE1C0010 for ; Tue, 3 Dec 2024 00:17:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="HV/RGAip"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733185049; a=rsa-sha256; cv=none; b=pPLcJOQnTA/WqGKFCl0IYCRPAUI8AicR+XMlskhA1jd4hOdQKLKsGXt0h3ZvWHE4Imb/Pk b031rV8WyO6tlAk58kiJkix7FY1ZBG0DgrJHaxIxIwSzdMl5TQHssiAelaw/MNwaiy9bUn dTfkts+Q/aW2lkIh8XGCv3F4eGMVeKs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="HV/RGAip"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733185049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=krGF3mlNQ8d+J7M3u+OrOilG5NzzZ6fC1XLrijBYY9k=; b=OW5aKQcz3a228WV9PM+62uGEY41BHcfU5dkjuf4R8oVzxhuWMKKwdcihAHz+qms8wwLoWB Es6mwiqBBpe4EJXhWqpkCWSWAo4Icb3MtruXjheVOeQn5glAbUCLm6jlJ12pH7xUbhzWz1 yluWEWE5jeijJROCs8bWaH4XcIzL4jU= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6d8843c44cfso31873776d6.3 for ; Mon, 02 Dec 2024 16:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733185060; x=1733789860; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=krGF3mlNQ8d+J7M3u+OrOilG5NzzZ6fC1XLrijBYY9k=; b=HV/RGAipnN92HLZqq83cw6DQtvgkN44gY/rqKy20qLTjo1JRu4cCb2R8k/KdWwrGYx F4ENkX5tuhVmo2bdOK+3rncmvswUvs3z/T8A+c0a8eFApbfJ8kws/XiDqjxKbBIMwTCU eBdBITL+kMMwRSBJcvT6DPrzpwa3jjs/jX50QJbI13KNanKpn3X/bGV11nmfj9mE4/j8 f/wjFrt+hdhILqiDmOJxKjqWLTpd6cAovH53Eg690IZep4wBmCzCJkfEFoPEJOWv5tp2 w0dNBoUNH8++08eyskq8xCNv22JVOKWRpu3hu2AFkKQ4thE6wuK+PBCC6hqUfGCal/XF 2GBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733185060; x=1733789860; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=krGF3mlNQ8d+J7M3u+OrOilG5NzzZ6fC1XLrijBYY9k=; b=ID6NLjsZ2I8N4jyhcoaOanYuRk1iMlW6j4vxYFYGIACgEhd+uaus4N9WAlQT0kN81C +WTB8JhV1C8/btxApJCv+S/SHu4P8FO8j6AdISToleV+MkadcGlAyQA0WToiNwQBQw0V 5O932+4sHPNLTEt2Rwu7afA7rRFOKP8KJaDASgMTNgmTo5x6JFCUdEz4yYuRbwgPcVzV jm4YxasJJ2sxaauuqY+ubnhjCBrs08uicKj+6NLU2BKn7QzvYlkx1Cs/983NkDBjZUuG pHNFK4drp+f324LzYfcVYLwP/V0oylt+3HcYfL3LaNmS1P6bIqR6wdqViG5n1OhKRHpH j/eg== X-Forwarded-Encrypted: i=1; AJvYcCXThB/Qf7Gqk4g3rGVOwGpB5PgWNOeVrkoy6A5aP5e85ILFn1zcncGyE9Mt8STI0LFOla2dIfPShQ==@kvack.org X-Gm-Message-State: AOJu0Yx+y5zLFqEcIuEUuouogRkHGDgX6M7sZ7i+WK48ttXeRhDMyDqf sY/8oNmsL9LSLOfgJDmmZPjE1D1amphek/z+tytGEkXzDeKskfrqfi/5P3ZW8M584TtLz2elbrK cl5XxgRbBcYsV/hlBVCQBsPaexdc= X-Gm-Gg: ASbGncs+OYZ9vAVVmS9XpaPo17B+GlEW4zEA49SIhrsLQNxuNfFfmv194QcZ6Je8WNv oEbVO3ti8ldWb5oXO9a/JZYYVbpACJg== X-Google-Smtp-Source: AGHT+IFI3RRX0sc4tNfzQIw22CJwi4WTZGCYXnLnpD5mChTG9YssqvqmWD+fX2tORqmxM/maI2BeW/OVRPTMUKl4nSo= X-Received: by 2002:a05:6214:e86:b0:6d4:22d4:f5b0 with SMTP id 6a1803df08f44-6d8b73b7668mr9909076d6.33.1733185060044; Mon, 02 Dec 2024 16:17:40 -0800 (PST) MIME-Version: 1.0 References: <20241127225324.6770-1-kanchana.p.sridhar@intel.com> <20241127225324.6770-3-kanchana.p.sridhar@intel.com> In-Reply-To: From: Nhat Pham Date: Mon, 2 Dec 2024 16:17:29 -0800 Message-ID: Subject: Re: [PATCH v1 2/2] mm: zswap: zswap_store_pages() simplifications for batching. To: Chengming Zhou Cc: Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, akpm@linux-foundation.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 26FBE1C0010 X-Stat-Signature: pdr9ityj57r61m4dbebzy6abfswdi4sk X-Rspam-User: X-HE-Tag: 1733185037-182453 X-HE-Meta: U2FsdGVkX1/UrgEDwOCj/mbZg7iiSWE+/HB8vUF1kvDv08EygBfQDnwm3K5KvzOqJ5Lqy7y7+vYnfGrxHUUVmzKg/eqN2d6JL53T2pgZL+Jl/by92bw9Gw67MKrrmnQNKTi3V9qvBS9exdaDlL4dvGKUuibqdISAALXFxercDrv90fKsiFDoVJmXQrr477llLs+D2IXVFgoY+wmdX+E+c4ARKBgJDGfbVlBcmWNBleLEfTFtO1NxABxGjJRBlA5Sg6nH840ZcKHvZIEF0ySiuDDhDljM7fKM7N16EJTqppERkaa6U44mBk9kfLrTNtFaikbwekk1bZ3MqhtWnNSs1yClg8A/WOZ/fDmML7b7j4an1oIoTc0fUnXRWGe2Vw1vPwc4h9xsf6XtnDzGdPyX2/Dn50dOuUYbAIsr5yyzW3eEKSGnvuaBmoI5l0waHGe7FXLRPkr9ZYGaTq+w03gFglrO1DbzeemsNwdZX3cjL/1RkwIAVH97yqiEZZvhvK8DZ/376LXbosgreiPZcECVs2HUDmV334ah+XOv9FqheddP8Azoyq72JqP9MA/UAKk+91VSyeHPivpWV7Q0EKVNGWC1BYGX9JqHlUd+fRgoR47ElZ7oeqPhIaANC4+uR6SKszhtjLTpvKVI0DPY87Z86kdGg0Mg39OoAREr+PoDyxBr3AUbSM6OjruL4ZWLM73lfwpCHuA9l7lEw7ShsAuaOVcT6OxQpRAbun6QQwh+utW7dADfRBbgehKMWRGTZ/3wuAHZsJ4LFjLL/RENLuuLzS3h4eRbbBnUmwLuCH5xRTvcvcgAUYXSUtbr16BRS6359iR5ICLrKq+G1GDht9XoZElLe+iR7m7NhqYUhTsGxWbAFWoWLX4Or0R3UPpcF1mVyuSvjqc5Q3BKqr6gI+nMdrPn7GDpa1wynZhwH89+SvxlVbGl0xE9B3eupO35LcUNK7uN9KzMN33IuGuYHrA Wx3+D/m+ socdwgt+2tj8NzG8PUW8fRyhl1RtwxAD4kyUpH5cH2AgQXsqC09KFuJ6aTo5IMsYN3UJbDs2VcuwB8lA/OmVMADdNzY5FuCS9lblk+c6BzQBHFgdV+06TlM65Pmjj0xeir9ek3a9F0IHK2+yi3J5FmArbJXvHeto3Wz7VMjRNrYqSbOgW1szIe7jocQHs87vBJCGGQNnz5uCoEK6w0l76/EGK5mrOhnwiL+0sjYpiCjfYtrckQ5kY3WZY9UDgNtAEUkzm9VijYKSYCFNJ9pfqUf3ZvAD3vWAUiAeJ6fkA1Va1LJbFhxH9A74xVK2pQ4BmFyuuYJRopsLe3c+RqmQL6DE7nLDh76coE+nVCpnvDjDNeaRGw8qEbXjVxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.027799, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 11:00=E2=80=AFPM Chengming Zhou wrote: > > How about introducing a `zswap_compress_folio()` interface which > can be used by `zswap_store()`? > ``` > zswap_store() > nr_pages =3D folio_nr_pages(folio) > > entries =3D zswap_alloc_entries(nr_pages) > > ret =3D zswap_compress_folio(folio, entries, pool) > > // store entries into xarray and LRU list > ``` > > And this version `zswap_compress_folio()` is very simple for now: > ``` > zswap_compress_folio() > nr_pages =3D folio_nr_pages(folio) > > for (index =3D 0; index < nr_pages; ++index) { > struct page *page =3D folio_page(folio, index); > > if (!zswap_compress(page, &entries[index], pool)) > return false; > } > > return true; > ``` > This can be easily extended to support your "batched" version. > > Then the old `zswap_store_page()` could be removed. > > The good point is simplicity, that we don't need to slice folio > into multiple batches, then repeat the common operations for each > batch, like preparing entries, storing into xarray and LRU list... > +1.