From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C77C46CD2 for ; Tue, 30 Jan 2024 18:37:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F63D6B007E; Tue, 30 Jan 2024 13:37:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7426B0080; Tue, 30 Jan 2024 13:37:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047736B009A; Tue, 30 Jan 2024 13:37:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E746A6B0098 for ; Tue, 30 Jan 2024 13:37:28 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 853DD120369 for ; Tue, 30 Jan 2024 18:37:28 +0000 (UTC) X-FDA: 81736835376.16.34CCB23 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf11.hostedemail.com (Postfix) with ESMTP id C9A6E40025 for ; Tue, 30 Jan 2024 18:37:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OA8IQEOZ; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706639846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hM9ej9K+8Z1VJp/yGHaHZXuJOYSDyYzm2GNeYFRuOio=; b=3LwD9ApHSBSY/BTVw1vZgElSymj58r6Mm45PwTM5czUPg+AFdygBJl0USpNt8o/4BuK442 Jrb7/IyLsXlINRlQfLzsVW3E/YUdRWBmajrwPBBDyxZ5lAIwFUyPVTNozmxrvbTxP4GsQM lIMW2GN6c16tG/1K47fIVHY+OvhpqoA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706639846; a=rsa-sha256; cv=none; b=TXVqFgR8wyMwXO+4hGircau2l1oLhdTeBbEaG/t4opx6r9c+K+VAa1v0UecNQxTSP8BDcB M1mGmU9vZZL5+kJ50LOB7MNkI4toWaoHFEwTRtZMw/J01Jgh1VAliNPELTpHYv8mhScRdJ 4E/2dy66ZOdQgxKwyceK2SxcvETi9gU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OA8IQEOZ; spf=pass (imf11.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7bfeacc32d2so114776439f.2 for ; Tue, 30 Jan 2024 10:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706639846; x=1707244646; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hM9ej9K+8Z1VJp/yGHaHZXuJOYSDyYzm2GNeYFRuOio=; b=OA8IQEOZcWCA9mTZAB1ugq74+eh67UeHcHKC+D9yNoP09Gj1QEebjVz9o8t2oat4v6 s6hMmgzqFBJ9xYHBrQz3ERnpyTqiJDx8+JbFxrGfG0PtUmE00Y6H0VrlOMLGVSP6uppq WgcaRJSlmgzmUp9pzhpAint59/q5oeHFL5b06X7kmZm/HUIYvVpwg5MpbmcKG3aO/axl pNprvA4vvcMoGLuMIXj00nstGuofjIpX7Ih+PQbWA9YIC2muHuDB48YC87EIAZVdnQnT VG+Az4oJasftcpX74r9CEnUAa27K4mfj8Q6km/HUWg/vEwZ83i1kFb4Es/muNHKvDyY8 5N1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706639846; x=1707244646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hM9ej9K+8Z1VJp/yGHaHZXuJOYSDyYzm2GNeYFRuOio=; b=KSq0a2lOK6tozgddcZoMHbzpZ50yaRvJYSSQxPNj48CgCvoVLpqQ0SYz/M69bZ2Fcc sOwUOu5uzEZ9Tvd7tYgcQUWl9BNtbEwOrLjHvXZIxFoFIFQpDEHBbc7GkASKCrgH+kNq +jjVQVNcvobl8j/hq/mLv2Ez3btYysgA8ClYAT4MMK0bl7kWxCrixewJ/eoF+UiMi26q k2VfUdq7TMtvC0J4JZXP1YZI3aKRPE55ObC3zrV8Qc0Alj2vLrdwQ8YC8hcmkoqKqYl1 a158DFI5eA0C+fmanuh/xGzyRy6OwKmTRW6KHyGw86z6tEXF3oUHaWzRGGbHpyunmu4L H7Sg== X-Gm-Message-State: AOJu0YyHuHX4cPDkCLxX28nWbtubM1VTVOpTnuKHWYJpffzUQfXHSOPM oVgHbPtiGKCbKIjZpjTqAXtKJb2qMggFUkqZT+PsEJ6II8io4ozk4idYfsrq0jKyTiKBajLTgYn 4QLKUARoAlfrqqSw3TMUwZPIvK1M= X-Google-Smtp-Source: AGHT+IERoa1G5FtsZFo/vtPsaqg2DfIVxKvUU5JLdo3L/X1OxY9spoX0SrOT+0nfO/bBF0zz61CYZCV1tV831AGsjD0= X-Received: by 2002:a92:d5c8:0:b0:363:900b:fa50 with SMTP id d8-20020a92d5c8000000b00363900bfa50mr1933229ilq.2.1706639845877; Tue, 30 Jan 2024 10:37:25 -0800 (PST) MIME-Version: 1.0 References: <20240129224542.162599-1-nphamcs@gmail.com> <20240129224542.162599-2-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Tue, 30 Jan 2024 10:37:15 -0800 Message-ID: Subject: Re: [PATCH 1/3] selftests: zswap: add zswap selftest file to zswap maintainer entry To: Yosry Ahmed Cc: akpm@linux-foundation.org, shuah@kernel.org, hannes@cmpxchg.org, tj@kernel.org, lizefan.x@bytedance.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C9A6E40025 X-Rspam-User: X-Stat-Signature: 8gth9r815ea49a8kmq1jb4tbw6f8pabh X-Rspamd-Server: rspam03 X-HE-Tag: 1706639846-325324 X-HE-Meta: U2FsdGVkX18rrRVGLE0TMMONa5RI/nlXOYbtG72iFFA0HhUSzskYT8DI/TvWbL1fSJGUg43Y25itYl8KQjRmYyQs6BLouop++qRsZL4NsWPoF5eAPbA6vVrHzPcWC/FTuJiUiqSJIxp/Jz2dhNxepNSAlyQfQp+Crqe9Votoh4v9xXp22nnLEaavM3ZNiMRbAWM3hdlJftseuDpPbzKleGmvTD/m39NDK8ABDzZPDQNvEv88ItK+wgGsDrO8Vo7IS6DGnCet0mVAFKajFT996av8MA35Twy/D2V9DMqead/miMS381lnoc7bAaxiBjxjJvLz82FLlJPiQocjksO93qgABdUWXrmEZmv5viglr9JztDvYXJrT2Ih9F4Fykq+9PuLUddwcJYY1p7McBlSBj8GG/OS52YlS5aiHqQoL6nWLRDF4b5D7nKTixgIB7F5OteR6eyI3Ee0vODs+yivZ9i5ZSpw9Le/yNW8jrwlxPP3nLuZN0+VRkiLnzB54AKlSxOxYd4uyqN+Faai/GsbeNZoCjtyn8umHusocVyOZbofV9S3KOB2QlN/wu1CDax1w945W3U4tIuQPkIgxTrVYikL90aOcM0tTV3NwTrO+Q/wVpLW5bsFtCrVWuBMX3VwRS7F8CDMX/0CBCA9ozb1jyXXySPKfE5sb6TZ0i03+pdaah3irsO7FScdzrSJqedameQo3C++d4NzKW/Yg2J142gXy1y/+btr7MHsaGKMuI155xZKR53W9TrvhgWCxapVBMUdJFYJj84jtAOYq5caTnYKBXesnRPn+Qjy9bc/TPSzs9TaaGmiVLwXifzq7/nU0R/53y3ZGKYbhMe57kNpMtSH8Xw9eWpmdszLPJ1gBaMFNkvJbiB1UWB2BcWmHZxmz8CgLj0aof9Q/PVwddyxI/LEktAjEKe/SmMhw8pJRSJF/acv0akw+HxB1MvPDYxRKffqIzvQe+85u2ccKOi0 hQFL8OnZ HqBDabCn6gfNVdyv25D3h4qoVskWtT9t1B7grPq467xvzpEJZ5bpjpxhRH6+9EtVYrgUhom5r2Jc0Dy6Ngbf0qcJOjC2pOsYlayD2jbnjdNHkCyMCrZU46KjLQxlvtMNb/tFqpBZcHXghVhSBBRXk67iPThiMbYVHjiXTMixe8E+evAMR/lU3whI9gHJ477GNoeiDQc/4g4ehk80XohNJUv6Z7+LjTgGdhct+1LjzNMN96nXkXfE/5eX9FR043rqIV0zYKMWauhz+npmbRmbp5oDH7YHinjWcGkD23E1mmHSAl48/idUV9cXCWC7WyLfzNETW2qX6OfyG66ht26XiG9KvNhVMBXuwLoMsG0fIeUBeL723bF/m7QO80y41IF3oPWtVaOuSqmVgMKZltzp3cliUfjsZOUgPqB5xPTww/U2sFDfHOsXHnAB6LjS4E/NhyCOKzV7xG5h5yhk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004322, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 5:02=E2=80=AFPM Yosry Ahmed = wrote: > > On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > > Make it easier for contributors to find the zswap maintainers when they > > update the zswap tests. > > > > Signed-off-by: Nhat Pham > > I guess I had to check the zswap tests at some point :) We sorely need more zswap tests :) I'm one of the offenders of adding new features without including tests, so no judging anyone of course, and admittedly zswap is quite intertwined with other parts of MM, so it's kinda hard to write unit-ish tests for zswap only. I often had to resort to scripting stress tests to iron out bugs. But there are still tests that we can write to verify public API (cgroup's zswap options come to mind), simple tests that cover crucial code paths, etc. that we should probably add in. At the very least this can be a quick/sanity check for developing and backporting patches into the production system. > > Acked-by: Yosry Ahmed > > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index fecebfc4c0dc..5f60faaefaf2 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -24396,6 +24396,7 @@ F: include/linux/zpool.h > > F: include/linux/zswap.h > > F: mm/zpool.c > > F: mm/zswap.c > > +F: tools/testing/selftests/cgroup/test_zswap.c > > > > THE REST > > M: Linus Torvalds > > -- > > 2.39.3 > >