From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C296FCF9C6B for ; Wed, 25 Sep 2024 14:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48DCB6B009C; Wed, 25 Sep 2024 10:29:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C9D8D0003; Wed, 25 Sep 2024 10:29:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE248D0001; Wed, 25 Sep 2024 10:29:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0D54B6B009C for ; Wed, 25 Sep 2024 10:29:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8053FAC625 for ; Wed, 25 Sep 2024 14:29:13 +0000 (UTC) X-FDA: 82603492986.13.A7C78D7 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf28.hostedemail.com (Postfix) with ESMTP id B6D6FC000B for ; Wed, 25 Sep 2024 14:29:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTsEZoXq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727274419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xUQYJ75vXn1lLVXVNdsC5J0RATkg/QsIAKyS6ZPN07o=; b=Jfin0eEst0Rka4RXDLeibocU/oqaq9DPEpeWU2+7RM1xZVLXjhVCaBkWQv7bUy4HBkflFZ 8yp1J8C7vl+7yD+qj9zHRgZomr8sp7HjHEtzFKBKXROpY1oB01ABI2C7uUW4+EWunQVeaV NZQM/6J0mf8C3qXRVN7ER2vgPgGRD0I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727274419; a=rsa-sha256; cv=none; b=6eW2qUPcXLcyqc+wKi0GRmqVFElj4G9OyiTJK62Bww98FY3vzcgI8uFBkzig0T8vFkPHxL yOXDLVRN3Dc75nD3hX8tu8JRQSYXBu3ShoB3sN2M4+7aFMancW8H6X4U0mPv9up1iUxtG7 1A+vzFhMG9XdPId/kXZ/LTP/dO7OavM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DTsEZoXq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=nphamcs@gmail.com Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6c353f2f954so51053136d6.3 for ; Wed, 25 Sep 2024 07:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727274551; x=1727879351; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xUQYJ75vXn1lLVXVNdsC5J0RATkg/QsIAKyS6ZPN07o=; b=DTsEZoXqORqqnL5NNad1nfruhHSJRQCMrNjs5Gjezlqf7wYn7dZHxwBVC2CaJHYQbx oIGDxpzcIBpyB2t/NjFw4vvkEQifvfAIie/c6BqljLYINBWwfD+jgyv7dwP/PdLYzQnf eAOKu2R0MzqXpSAcyTboCJZyjweCWqex0OrPcwNV7w45P8GP5jACvsfACHVd9meLIwox 3CGpzZEYVmpnRt7d99l+kvbS78NVWjCGK2nAxAAHLbnGFmXKAHypI3k/C6nYXFkO7SL5 pDA/iZ6Po9PShBqMx1/JS3/OUa6n4DoUTmau5hktWTJgbl7DX+mF9nEoitO6zOXRhCi9 /kWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727274551; x=1727879351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xUQYJ75vXn1lLVXVNdsC5J0RATkg/QsIAKyS6ZPN07o=; b=aBP0PBX10UsLy1RWK7whngaCQi0GWg95MTT0ddxvMyZZL+PqtQNvVLvjZSX/2cKYXy XhsEzZD5lz/olWHIjEYYyje71JncRTMDOyOrTCGJRNK4o7xzUPfJuVM5bMlGeP1WfoLZ v/MIK4QhuDGACkZOb1yj6+OSeVT4mXte+6plSLmtaMNgQSrZ+YV0k9VRrwtM9jIs3b95 6vyQ+kiatQRSNBwkUhnLNS2zvmLRmJtGntgrDPRDUj8Sirc8jUzFJ6NEbsoLdCm3Hh5I CeiQbKRDxUECShEtV2AuGFQbNmnks/cgHfJzgu2brY00Ru5bZZ10P0w90ono3aLIQ2e1 68Ow== X-Forwarded-Encrypted: i=1; AJvYcCWU3ra8TzLjQ1KcE0RH8GvVT49cVeq6UozUU4tg57av1yuvf6TpHELbeClVPS70fdXJRPWeQ2wicQ==@kvack.org X-Gm-Message-State: AOJu0Ywhf1bPx3Bc5TYazfjPUdLkJBoXhHhaKkNdLTioKDiDeBWnDXdy E8vQf6lrmhT63dm8bUYupkVvPG4iW9f0dLruQu9+hYW78+rzKuxuY0610vEXaD7CDHFuHG3nxoZ 2WoJLWYp9YIV7klw+GwCvoa/eqv8= X-Google-Smtp-Source: AGHT+IHGx8Ulcf5JyspZf37Tqz9M7joMNTp8Z/DRQsZdQXRmnrjqEhkPVUefdfbJH9Fk4VUq4OM5xcOR2p8/786qqb0= X-Received: by 2002:a05:6214:3213:b0:6c1:6d4e:535c with SMTP id 6a1803df08f44-6cb1dd0a7afmr41846946d6.4.1727274550719; Wed, 25 Sep 2024 07:29:10 -0700 (PDT) MIME-Version: 1.0 References: <20240923231142.4155415-1-nphamcs@gmail.com> <4d38c65d-760c-43a5-bb47-8e0235c13a51@linux.alibaba.com> <9a110f20-42ad-468b-96c6-683e162452a9@linux.alibaba.com> <87o74cryhu.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: From: Nhat Pham Date: Wed, 25 Sep 2024 07:28:59 -0700 Message-ID: Subject: Re: [RFC PATCH 0/2] remove SWAP_MAP_SHMEM To: Barry Song Cc: "Huang, Ying" , Yosry Ahmed , Baolin Wang , akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, chrisl@kernel.org, david@redhat.com, kasong@tencent.com, willy@infradead.org, viro@zeniv.linux.org.uk, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B6D6FC000B X-Stat-Signature: 7pojjrtm8zwbbifqxbz5pjfqbck6huwc X-Rspam-User: X-HE-Tag: 1727274551-129255 X-HE-Meta: U2FsdGVkX1+MhdBumXSwhcgkswEgnQGRB6DSn9pbem0WpEFYmQeGNLR3TZHJeajPtGa/X6fAHxTblrzPkuB0J9UClB/uANWw6PL+s1argJJNwrC+ODiGvKOpbhnuS1GUd/lVt7bGZ3yPB4qfVF1zY+8EOAHjNhWBiC6GNHgc7ZyVodh8M6hleLEB/vKgIgVsj9tnszGHFAvejCwpZpUimerZjoZ4eNuNxnc4pmBN4kKQ48WyHfWmmHvjV3J4WiLwUyq8sx/mtEcvUxEELWbJJSds9lg/mK662jmKwvNBOg4DnLAgPIwwdjiwt4xpzu9ORE74xCq4ShkjXNSVID0NS6+WBfskhhWkrZ5aI1gW0nL2oLzIDyJ/VITzNwahAULf1h+KqyAv7fxkX8OW3QJpb6lsL/3CAAoB3B+jZD49SoDnPXGaIs5Ot37220uDLfQJ17pro1Vfs/wgdTQnE1o+jtfMHFSeTwyu9J3M4p47QviCLfWQOQd7U+AC3XTgI7lQ6AEy5ePXQgriKzshtM1IIpLC8caG0oUEZ/+yuTBFQGGtGehlYS0PX6Sf+XR/Jggu9bdyeT50Cp5ABuBJHopEVm3yi8iQ/5btUDWLuuzmvV/RFSppI8CzT+bxd2y/5CBLgUicldG7Nw3wOUnoRiK1fapdMfr42iWS6aPj7dDQ5bnN+nJDbL1aOynlG5wshqYXxh3ShvB0S2r5Kv7rz9hHk6j5NC0fuFibrD0oq76lKBAakdxxEYjUFEv+eIJhJbqhwZFHIDzDkT9m8WS6HN5JG/Tutb5iYRYgNNHYSiUIVuDNM8zLaQ8DOPwUwbXEydHrb+IAJrcuPTIovypLrIF49pTCfYCx5+3Ym+kpCZj9oZeTE0yoD39rzkkvr9TujzrkaQSDeOmRrN4KVIDVeY1zYJSyOI5zv/2CPVjz4PePdOJOjXW6CJM+4wLnSAQTpM+gdtcq5TYZneYpWXhQny3 nsSrU+OL +l6NBOGK3Juy4RMXduTiSQsnK4Xp/vVBAABebqraQdyFb8RJSnVaBnCgvFS5pg93IhIxQgaIdtWcCYgZtbLHSD7xp6iee7UVfCSx1bujRkx2U/B84rGVSv4vA4bAAerRFWD2ML4kJzMe2WXGJ77nERo56dom167FVPKTlNJjO82yyZMgjddth6CrkyWs4URi04cMFmkTr+NHgH8ehkgap0db39p+tifdKyy6ixha3tew4o63uthtRxnQGOk6tS4ePvnaOcxO1uhq5CtBFblByWQuPkAtK+QxFsDaPIm1FTXS3UnmRmdUlPgqz+alXGt974d/gXCMGOmDaY0cef/5E60uYw3jat7j2+zXux3EkNhH82+SJNBmG0lam8yU3ex+G78bMtSZYD1+dicU1wNiRWweRGfIX0ZMCa5a3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000114, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 7:21=E2=80=AFAM Nhat Pham wrote= : > > On Wed, Sep 25, 2024 at 12:33=E2=80=AFAM Barry Song w= rote: > How does this look? My concern is that there is not really a use for > the fallback logic. Basically dead code. > > I can keep it in if you guys have a use for it soon, but otherwise I > lean towards just adding a WARN etc. there, or return -ENOMEM, and > WARN at shmem's callsite (because it cannot get -ENOMEM). Oh and another point - I plan to rewrite this swap entity lifetime logic in the new abstraction layer. The swap continuation part will go away with it - I don't quite like the way we're currently doing things. So this added complexity might be unnecessary.