From: Nhat Pham <nphamcs@gmail.com>
To: Barry Song <baohua@kernel.org>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Yosry Ahmed <yosryahmed@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, hannes@cmpxchg.org, hughd@google.com,
shakeel.butt@linux.dev, ryan.roberts@arm.com, chrisl@kernel.org,
david@redhat.com, kasong@tencent.com, willy@infradead.org,
viro@zeniv.linux.org.uk, chengming.zhou@linux.dev,
linux-mm@kvack.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] remove SWAP_MAP_SHMEM
Date: Wed, 25 Sep 2024 07:28:59 -0700 [thread overview]
Message-ID: <CAKEwX=OtpnH+i4FtZ66HPoe7zRRtEBuMbHQ9+LW4k5yLK+yHNw@mail.gmail.com> (raw)
In-Reply-To: <CAKEwX=NuRuu9qXA9mRMqb6Okcwa86mEkp2Ac8sQjwb0ACdS7YQ@mail.gmail.com>
On Wed, Sep 25, 2024 at 7:21 AM Nhat Pham <nphamcs@gmail.com> wrote:
>
> On Wed, Sep 25, 2024 at 12:33 AM Barry Song <baohua@kernel.org> wrote:
> How does this look? My concern is that there is not really a use for
> the fallback logic. Basically dead code.
>
> I can keep it in if you guys have a use for it soon, but otherwise I
> lean towards just adding a WARN etc. there, or return -ENOMEM, and
> WARN at shmem's callsite (because it cannot get -ENOMEM).
Oh and another point - I plan to rewrite this swap entity lifetime
logic in the new abstraction layer. The swap continuation part will go
away with it - I don't quite like the way we're currently doing
things. So this added complexity might be unnecessary.
next prev parent reply other threads:[~2024-09-25 14:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 23:11 Nhat Pham
2024-09-23 23:11 ` [RFC PATCH 1/2] swapfile: add a batched variant for swap_duplicate() Nhat Pham
2024-09-23 23:11 ` [RFC PATCH 2/2] swap: shmem: remove SWAP_MAP_SHMEM Nhat Pham
2024-09-24 0:32 ` Yosry Ahmed
2024-09-24 0:20 ` [RFC PATCH 0/2] " Yosry Ahmed
2024-09-24 1:55 ` Baolin Wang
2024-09-24 2:15 ` Yosry Ahmed
2024-09-24 3:25 ` Baolin Wang
2024-09-24 14:32 ` Nhat Pham
2024-09-24 15:07 ` Yosry Ahmed
2024-09-24 15:48 ` Nhat Pham
2024-09-24 18:11 ` Yosry Ahmed
2024-09-25 6:26 ` Barry Song
2024-09-25 7:24 ` Huang, Ying
2024-09-25 7:38 ` Barry Song
2024-09-25 1:53 ` Baolin Wang
2024-09-25 14:37 ` Nhat Pham
2024-09-26 1:59 ` Huang, Ying
2024-09-26 3:30 ` Baolin Wang
2024-09-26 3:59 ` Barry Song
2024-09-26 22:50 ` Nhat Pham
2024-09-26 4:00 ` Barry Song
2024-09-25 7:19 ` Huang, Ying
2024-09-25 7:32 ` Barry Song
2024-09-25 14:21 ` Nhat Pham
2024-09-25 14:24 ` Nhat Pham
2024-09-25 14:28 ` Nhat Pham [this message]
2024-09-24 20:15 ` Chris Li
2024-09-24 21:30 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=OtpnH+i4FtZ66HPoe7zRRtEBuMbHQ9+LW4k5yLK+yHNw@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox